Update patch set 1
Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
parent
649cdf5cf5
commit
77bf718e17
|
@ -89,6 +89,24 @@
|
||||||
"revId": "a9d8c3ee3cd5babc3a141061beb3182a6aecef14",
|
"revId": "a9d8c3ee3cd5babc3a141061beb3182a6aecef14",
|
||||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "906940f3_5886cd39",
|
||||||
|
"filename": "library/L1CTL_Types.ttcn",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 859,
|
||||||
|
"author": {
|
||||||
|
"id": 1000010
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-13T18:02:53Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "\u003e Just adding those would have been far quicker\n\nYes, but I would still want to understand how would this affect the validation/compilation/execution, rather than quickly (and blindly) doing what you suggested. My current understanding is that adding `(present)` to receive templates does not bring noticeable improvements. I am not convinced by your arguments, sorry.\n\n\u003e It\u0027s a discussion like adding \"static\" or \"const\" to a variable in C\n\nIn the case of `static` or `const` in C, I do see the benefits of using those keywords. And many of us could provide enough examples how `static` and/or `const` improved readability or prevented them from shooting their own legs. But here it feels more like a theoretical improvement.\n\nOut of curiosity, I even compared the resulting C++ code with and without the `(present)` in the `tr_FooBar` definition: no changes, except the `module_checksum[]`. So I am assuming that TITAN implicitly defaults to `(present)`.",
|
||||||
|
"parentUuid": "a138a37e_2ecba5d0",
|
||||||
|
"revId": "a9d8c3ee3cd5babc3a141061beb3182a6aecef14",
|
||||||
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"unresolved": true,
|
"unresolved": true,
|
||||||
"key": {
|
"key": {
|
||||||
|
|
Loading…
Reference in New Issue