From 4858184bd4f5b5fc30525d27317518cf01c59c51 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Fri, 26 Feb 2021 12:40:37 +0100 Subject: [PATCH] StatsD_Checker: Enable by default It was previously disabled by default in order to avoid test breakage with older versions of osmocom projects not supporting them. Since we just did a new release, all -latest contian now master which should work fine. Don't remove the moduleparam yet in order to avoid breakage with some cfg files in docker-playground.git still setting it to true. Related: OS#5042 Change-Id: I4e2049c109986906d3c985ca2282174b1abff581 --- bsc/BSC_Tests.default | 1 - library/StatsD_Checker.ttcn | 2 +- ns/NS_Tests.default | 1 - pcu/PCU_Tests.default | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default index c5d1559fa..50c5c0a0e 100644 --- a/bsc/BSC_Tests.default +++ b/bsc/BSC_Tests.default @@ -29,6 +29,5 @@ mtc.FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING | DEBUG_ENCDEC; [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBSC"; -StatsD_Checker.mp_enable_stats := true; [EXECUTE] diff --git a/library/StatsD_Checker.ttcn b/library/StatsD_Checker.ttcn index 540e479b0..1c8fd1230 100644 --- a/library/StatsD_Checker.ttcn +++ b/library/StatsD_Checker.ttcn @@ -38,7 +38,7 @@ import from TELNETasp_PortType all; modulepar { /* Whether to test stats values */ - boolean mp_enable_stats := false; + boolean mp_enable_stats := true; } type record StatsDExpect { diff --git a/ns/NS_Tests.default b/ns/NS_Tests.default index 951c1c285..1c61bec86 100644 --- a/ns/NS_Tests.default +++ b/ns/NS_Tests.default @@ -8,7 +8,6 @@ ConsoleMask := ERROR | WARNING | TESTCASE | TIMEROP_START | USER [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoNSdummy"; -StatsD_Checker.mp_enable_stats := true; [TESTPORT_PARAMETERS] *.NSVTY.CTRL_MODE := "client" diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default index 4d6c0a23b..6f633d22d 100644 --- a/pcu/PCU_Tests.default +++ b/pcu/PCU_Tests.default @@ -30,7 +30,6 @@ SGSN_Components.mp_gb_cfg := { }; Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoPCU"; PCUIF_Types.mp_pcuif_version := 10; -StatsD_Checker.mp_enable_stats := true; [TESTPORT_PARAMETERS] *.PCU.socket_type := "SEQPACKET"