ttcn3
/
osmo-ttcn3-hacks
mirror of https://gerrit.osmocom.org/osmo-ttcn3-hacks
10
0
Fork 1
Code Issues Releases Wiki Activity

don't use setverdict(inconc) anymore. Use 'fail' at all times 

The problem is that Junit-XML doesn't have a mapping for inconclusive
results, and hence they show up as 'passed'.

By introducing this change, we make sure all tests that don't pass
show up as failed.

Change-Id: Iddd13d0055c91f9bd304ce9833fba0485abf4c4e
This commit is contained in:
Harald Welte 2018-03-21 11:26:23 +01:00
parent 61c11e9234
commit 458fd37fb9
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bsc-nat/MSC_ConnectionHandler.ttcn
View File

@ -146,7 +146,7 @@ function main(integer connection_id, integer e1_timeslot) runs on MSC_ConnHdlr {
/* Guard timer has expired, close connection */
[] T.timeout {
BSSAP.send(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);
setverdict(inconc);
setverdict(fail, "Timeout of guard timer");
self.stop;
}

2
bsc/BSC_Tests.ttcn
View File

@ -1674,7 +1674,7 @@ private function f_tc_err_84_unknown_msg(charstring id) runs on MSC_ConnHdlr {
setverdict(pass);
}
[] BSSAP.receive { setverdict(fail, "unexpected BSSAP"); }
[] T.timeout { setverdict(inconc); }
[] T.timeout { setverdict(fail, "Timeout waiting for RR STATUS"); }
}
}
testcase TC_err_84_unknown_msg() runs on test_CT {

2
bsc/MSC_ConnectionHandler.ttcn
View File

@ -682,7 +682,7 @@ runs on MSC_ConnHdlr return PDU_BSSAP {
setverdict(fail, "Received non-matching ASSIGNMENT FAIL");
}
[] T.timeout {
setverdict(inconc, "Timeout waiting for ASSIGNMENT COMPLETE");
setverdict(fail, "Timeout waiting for ASSIGNMENT COMPLETE");
}
}
log("g_media ", g_media);

6
msc/MSC_Tests.ttcn
View File

@ -161,7 +161,7 @@ function f_init_gsup(charstring id) runs on MTC_CT {
alt {
[] GSUP_IPA_EVENT.receive(t_ASP_IPA_EVT_UD(ASP_IPA_EVENT_UP)) { }
[] T.timeout {
setverdict(inconc, "No connection to GSUP Port");
setverdict(fail, "No connection to GSUP Port");
self.stop
}
}
@ -1511,7 +1511,7 @@ private function f_tc_lu_imsi_auth_tmsi_encr_3_1(charstring id, BSC_ConnHdlrPars
self.stop;
}
[] BSSAP.receive {
setverdict(inconc, "Unknown/unexpected BSSAP received");
setverdict(fail, "Unknown/unexpected BSSAP received");
self.stop;
}
}
@ -1578,7 +1578,7 @@ private function f_tc_lu_imsi_auth_tmsi_encr_13_2(charstring id, BSC_ConnHdlrPar
self.stop;
}
[] BSSAP.receive {
setverdict(inconc, "Unknown/unexpected BSSAP received");
setverdict(fail, "Unknown/unexpected BSSAP received");
self.stop;
}
}