BTS: fix as_l1_count_paging(): do not count PCH filling messages

Since build #842, both TC_paging_{i|t}msi_80percent started to fail:

  "BTS_Tests.ttcn:3051 : Expected 271 pagings but have 284"
      BTS_Tests.ttcn:6414 BTS_Tests control part
      BTS_Tests.ttcn:3051 TC_paging_imsi_80percent testcase

  "BTS_Tests.ttcn:3075 : Expected 543 pagings but have 553"
      BTS_Tests.ttcn:6415 BTS_Tests control part
      BTS_Tests.ttcn:3075 TC_paging_tmsi_80percent testcase

As it turns out, since If5339c7a91b4e0188194f1cd935798f153974e01
TITAN can decode PCH filling messages with no Mobile Identity.
We should not count them in as_l1_count_paging(), as they're
sent by osmo-bts itself.

Change-Id: I420f36ed000b1c2488fbe500c33a8161e27d20e3
Fixes: OS#4475
This commit is contained in:
Vadim Yanitskiy 2020-03-31 14:33:43 +07:00
parent fb3edf951d
commit 36aa07cb89
1 changed files with 4 additions and 1 deletions

View File

@ -2866,7 +2866,10 @@ runs on test_CT {
check_pch_fn(dl.dl_info.frame_nr, cfg.bs_ag_blks_res);
if (match(rr, tr_PAGING_REQ1)) {
if (match(rr, tr_PAGING_REQ1(tr_MI_LV(t_MI_NoIdentity(?))))) {
/* Ignore empty RR Paging Request (PCH filling) messages.
* TODO: does it make sense to count them? */
} else if (match(rr, tr_PAGING_REQ1)) {
num_paging_rcv_msgs := num_paging_rcv_msgs + 1;
num_paging_rcv_ids := num_paging_rcv_ids + 1;
if (ispresent(rr.msgs.rrm.pagingReq_Type1.mobileIdentity2)) {