mirror of https://gerrit.osmocom.org/osmo-tetra
75 lines
2.3 KiB
Plaintext
75 lines
2.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2f6f3f28_d1d41a66",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2022-09-18T12:55:16Z",
|
|
"side": 1,
|
|
"message": "Would be good to see the motivation for this change in the commit message.\nWhy is it needed to shift the timeslot number value from 0..3 to 1..4?",
|
|
"revId": "8000c6059710a86a4f5a3f2857e1978398170ebc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1749fae9_1ea77205",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000225
|
|
},
|
|
"writtenOn": "2022-09-18T13:03:24Z",
|
|
"side": 1,
|
|
"message": "As you can see in the tetra_tdma_time struct definition comments in tetra_tdma.h, it is always supposed to be in this range. Also, tetra_burst_sync_in increments the timeslot number when synchronized, ultimately using the function normalize_tn in tetra_tdma.c which also only works properly on the uses the 1-4 range.",
|
|
"parentUuid": "2f6f3f28_d1d41a66",
|
|
"revId": "8000c6059710a86a4f5a3f2857e1978398170ebc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "67aed41e_928c7f9b",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2022-09-18T13:10:07Z",
|
|
"side": 1,
|
|
"message": "Thanks for explaining. Please add this to the commit message.",
|
|
"parentUuid": "1749fae9_1ea77205",
|
|
"revId": "8000c6059710a86a4f5a3f2857e1978398170ebc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "72a048ee_2839319e",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000225
|
|
},
|
|
"writtenOn": "2022-09-18T13:46:43Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "67aed41e_928c7f9b",
|
|
"revId": "8000c6059710a86a4f5a3f2857e1978398170ebc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |