osmo-tetra/40843da7bd30c17fb1c99bc08bbc66b29820eccb

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "4e9c20e6_86624c56",
        "filename": "src/tetra_llc_pdu.h",
        "patchSetId": 1
      },
      "lineNbr": 80,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-09-18T13:07:24Z",
      "side": 1,
      "message": "unrelated ws changed",
      "range": {
        "startLine": 80,
        "startChar": 18,
        "endLine": 80,
        "endChar": 20
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "55e91c83_fd285847",
        "filename": "src/tetra_llc_pdu.h",
        "patchSetId": 1
      },
      "lineNbr": 80,
      "author": {
        "id": 1000225
      },
      "writtenOn": "2022-09-18T13:57:12Z",
      "side": 1,
      "message": "tl_sdu_len needs to be changed from a uint8_t to uint32_t because, due to defragmentation, pdus may become longer than 255 bits. As such, I feel like it is related to this change, however, I now mention the change in the commit message.",
      "parentUuid": "4e9c20e6_86624c56",
      "range": {
        "startLine": 80,
        "startChar": 18,
        "endLine": 80,
        "endChar": 20
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "a75dc52c_27c6ef83",
        "filename": "src/tetra_llc_pdu.h",
        "patchSetId": 1
      },
      "lineNbr": 80,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-09-18T15:49:43Z",
      "side": 1,
      "message": "I meant to say \"unrelated WhiteSpace change\", sorry for not being clear. What I wanted to point out is that you\u0027re adding two tabs here for no reason. You\u0027re changing the line below, this one should remain unchanged.",
      "parentUuid": "55e91c83_fd285847",
      "range": {
        "startLine": 80,
        "startChar": 18,
        "endLine": 80,
        "endChar": 20
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "090b7175_8e946ef0",
        "filename": "src/tetra_llc_pdu.h",
        "patchSetId": 1
      },
      "lineNbr": 80,
      "author": {
        "id": 1000225
      },
      "writtenOn": "2022-09-18T16:03:16Z",
      "side": 1,
      "message": "Ah I see, same tab issue. Amended.",
      "parentUuid": "a75dc52c_27c6ef83",
      "range": {
        "startLine": 80,
        "startChar": 18,
        "endLine": 80,
        "endChar": 20
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "32eca4db_e3c142cb",
        "filename": "src/tetra_mac_pdu.c",
        "patchSetId": 1
      },
      "lineNbr": 64,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-09-18T13:07:24Z",
      "side": 1,
      "message": "In this particular place, it\u0027s a good change. But it should be done in a separate patch.",
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2910a82b_bcfbb131",
        "filename": "src/tetra_mac_pdu.c",
        "patchSetId": 1
      },
      "lineNbr": 64,
      "author": {
        "id": 1000225
      },
      "writtenOn": "2022-09-18T13:57:12Z",
      "side": 1,
      "message": "Removed these changes from the patch",
      "parentUuid": "32eca4db_e3c142cb",
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "877cd340_dd50c049",
        "filename": "src/tetra_mac_pdu.c",
        "patchSetId": 1
      },
      "lineNbr": 97,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-09-18T13:07:24Z",
      "side": 1,
      "message": "Please keep the original formatting in this patch. Unrelated changes make it harder to see what\u0027s actually done during code review (and probably later).",
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "c0ffeaa7_7c6328fa",
        "filename": "src/tetra_mac_pdu.c",
        "patchSetId": 1
      },
      "lineNbr": 97,
      "author": {
        "id": 1000225
      },
      "writtenOn": "2022-09-18T13:57:12Z",
      "side": 1,
      "message": "Removed these changes from the patch",
      "parentUuid": "877cd340_dd50c049",
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ec5bc71b_677ea78b",
        "filename": "src/tetra_mac_pdu.c",
        "patchSetId": 1
      },
      "lineNbr": 387,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-09-18T13:07:24Z",
      "side": 1,
      "message": "why are you changing this?\nmaybe it\u0027s your editor doing this automatically?",
      "range": {
        "startLine": 387,
        "startChar": 19,
        "endLine": 387,
        "endChar": 21
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e10a0629_3c39e6e0",
        "filename": "src/tetra_mac_pdu.c",
        "patchSetId": 1
      },
      "lineNbr": 387,
      "author": {
        "id": 1000225
      },
      "writtenOn": "2022-09-18T13:57:12Z",
      "side": 1,
      "message": "Removed these changes from the patch",
      "parentUuid": "ec5bc71b_677ea78b",
      "range": {
        "startLine": 387,
        "startChar": 19,
        "endLine": 387,
        "endChar": 21
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d9f119f8_845d348f",
        "filename": "src/tetra_upper_mac.c",
        "patchSetId": 1
      },
      "lineNbr": 51,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-09-18T13:07:24Z",
      "side": 1,
      "message": "I don\u0027t think calling msgb_reset() is needed right after calling msgb_alloc(). It\u0027s already reset when allocated. Correct me if I am wrong.",
      "range": {
        "startLine": 51,
        "startChar": 2,
        "endLine": 51,
        "endChar": 12
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "7aa4150d_d951feef",
        "filename": "src/tetra_upper_mac.c",
        "patchSetId": 1
      },
      "lineNbr": 51,
      "author": {
        "id": 1000225
      },
      "writtenOn": "2022-09-18T13:57:12Z",
      "side": 1,
      "message": "You\u0027re right, removed the msgb_reset() call.",
      "parentUuid": "d9f119f8_845d348f",
      "range": {
        "startLine": 51,
        "startChar": 2,
        "endLine": 51,
        "endChar": 12
      },
      "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}