tetra
/
osmo-tetra
mirror of https://gerrit.osmocom.org/osmo-tetra
4
0
Fork 0
Code Issues Releases Wiki Activity

Compare commits

base: tetra:e6bf4cf8fe155e0e91d526e5f7c245f3d7fd7add
Branches Tags
tetra:master
tetra:users/tnt/dmo
tetra:laforge/sq5bpf-rebase-20161218
...
compare: tetra:5b39e82d6807e5fe455c0b52744cc18e9f569df4
Branches Tags
tetra:master
tetra:users/tnt/dmo
tetra:laforge/sq5bpf-rebase-20161218

4 Commits
e6bf4cf8fe ... 5b39e82d68

Author SHA1 Message Date
Gerrit User 1000002 5b39e82d68 Update patch set 3 
Patch Set 3:

3 passed:
* [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-tetra-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/24/consoleFull
* [endianness] https://jenkins.osmocom.org/jenkins/job/gerrit-pipeline-endianness/5408/consoleFull
* [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/10223/consoleFull

Build Successful

Patch-set: 3
Tag: jenkins
 2023-07-29 11:12:13 +00:00
Gerrit User 1000002 df48ad5b72 Update patch set 3 
Patch Set 3: Verified+1

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-tetra/23/consoleFull

Patch-set: 3
Tag: jenkins
Label: Verified=+1, 8ae51c818f168632ab5be4f1f9265963f66a1946
 2023-07-29 11:11:38 +00:00
Gerrit User 1000225 60c248b07c Create patch set 3 
Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.

Patch-set: 3
Subject: Fixups and clarifying comments for msgb tail modifications
Commit: 86796c6c4a
Tag: autogenerated:gerrit:newPatchSet
Groups: 6a95eae91e
Copied-Label: Verified=+1, e522a376697e5d944f4451efd38af3d966d0fc0d Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>,Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>:"jenkins"
 2023-07-29 11:11:12 +00:00
Gerrit User 1000225 360fec95a5 Update patch set 2 
Patch Set 2:

(2 comments)

Patch-set: 2
 2023-07-29 10:02:40 +00:00
1 changed files with 41 additions and 0 deletions
Show Stats Expand all files Collapse all files

41
cea0df5899bc859b619be5fc9c460780214f9de9
View File

@ -17,6 +17,23 @@
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "54bc9b7d_98634b20",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000225
},
"writtenOn": "2023-07-29T10:02:40Z",
"side": 1,
"message": "After further inspection, I find the msgb_trim function uses msgb-\u003edata as a reference, which is a problem, due to the multiple-resources-per-timeslot scenario. It would work if l1h were used as a reference, since I move that pointer forward in tetra_lower_mac.c. I\u0027m not against refactoring all the manual field manipulation to an osmocom buffer manipulation function but can you suggest a way to do it properly?\n\nWhat\u0027s the semantically correct way to deal with multiple upper mac messages in a buffer?",
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -64,6 +81,30 @@
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "173bdf49_1109459c",
"filename": "src/lower_mac/tetra_lower_mac.c",
"patchSetId": 2
},
"lineNbr": 347,
"author": {
"id": 1000225
},
"writtenOn": "2023-07-29T10:02:40Z",
"side": 1,
"message": "After further inspection, I find the msgb_trim function uses msgb-\u003edata as a reference, which is a problem, due to the multiple-resources-per-timeslot scenario. It would work if l1h were used as a reference, since I move that pointer forward in tetra_lower_mac.c. I\u0027m not against refactoring all the manual field manipulation to an osmocom buffer manipulation function but can you suggest a way to do it properly?\n\nWhat\u0027s the semantically correct way to deal with multiple upper mac messages in a buffer?",
"parentUuid": "c0575652_18ca0744",
"range": {
"startLine": 347,
"startChar": 0,
"endLine": 347,
"endChar": 16
},
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {