tetra
/
osmo-tetra
mirror of https://gerrit.osmocom.org/osmo-tetra
4
0
Fork 0
Code Issues Releases Wiki Activity

Compare commits

base: tetra:5b39e82d6807e5fe455c0b52744cc18e9f569df4
Branches Tags
tetra:master
tetra:users/tnt/dmo
tetra:laforge/sq5bpf-rebase-20161218
..
compare: tetra:e6bf4cf8fe155e0e91d526e5f7c245f3d7fd7add
Branches Tags
tetra:master
tetra:users/tnt/dmo
tetra:laforge/sq5bpf-rebase-20161218

No commits in common. "5b39e82d6807e5fe455c0b52744cc18e9f569df4" and "e6bf4cf8fe155e0e91d526e5f7c245f3d7fd7add" have entirely different histories.
5b39e82d68 ... e6bf4cf8fe

1 changed files with 0 additions and 41 deletions
Show Stats Expand all files Collapse all files

41
cea0df5899bc859b619be5fc9c460780214f9de9
View File

@ -17,23 +17,6 @@
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "54bc9b7d_98634b20",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000225
},
"writtenOn": "2023-07-29T10:02:40Z",
"side": 1,
"message": "After further inspection, I find the msgb_trim function uses msgb-\u003edata as a reference, which is a problem, due to the multiple-resources-per-timeslot scenario. It would work if l1h were used as a reference, since I move that pointer forward in tetra_lower_mac.c. I\u0027m not against refactoring all the manual field manipulation to an osmocom buffer manipulation function but can you suggest a way to do it properly?\n\nWhat\u0027s the semantically correct way to deal with multiple upper mac messages in a buffer?",
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -81,30 +64,6 @@
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "173bdf49_1109459c",
"filename": "src/lower_mac/tetra_lower_mac.c",
"patchSetId": 2
},
"lineNbr": 347,
"author": {
"id": 1000225
},
"writtenOn": "2023-07-29T10:02:40Z",
"side": 1,
"message": "After further inspection, I find the msgb_trim function uses msgb-\u003edata as a reference, which is a problem, due to the multiple-resources-per-timeslot scenario. It would work if l1h were used as a reference, since I move that pointer forward in tetra_lower_mac.c. I\u0027m not against refactoring all the manual field manipulation to an osmocom buffer manipulation function but can you suggest a way to do it properly?\n\nWhat\u0027s the semantically correct way to deal with multiple upper mac messages in a buffer?",
"parentUuid": "c0575652_18ca0744",
"range": {
"startLine": 347,
"startChar": 0,
"endLine": 347,
"endChar": 16
},
"revId": "cea0df5899bc859b619be5fc9c460780214f9de9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {