tetra
/
osmo-tetra
mirror of https://gerrit.osmocom.org/osmo-tetra
4
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000225 \u003c1000225@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"wbokslag replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"wbokslag replied on the change"}
This commit is contained in:
Gerrit User 1000225 2022-09-20 14:01:14 +00:00 committed by Gerrit Code Review
parent 8567077e37
commit f8d9f43ba3
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
4a8bd75e1e5f05a62291f7271d7e4c223d122e06
View File

@ -23,6 +23,30 @@
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "6894bd91_c3ed915d",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 44,
"author": {
"id": 1000225
},
"writtenOn": "2022-09-20T14:01:14Z",
"side": 1,
"message": "The lower mac allocates a global context structure tetra_cell_data with global pointer tcd. I\u0027d figure that it doesn\u0027t belong in that context. We could, however, add an upper mac context (upper_mac_context umc?), which, for now, would only hold the fragslots. Would that be preferable?\n\nNote that passing the context by parameter will not work without changing a lot of unrelated prototypes, as that would imply the lower mac (and burst detector, etcetera) also need to have it. It would not be a bad idea to create a context in tetra-rx that contains the respective states for the burst detector, lower mac, upper mac and possibly layers above, but that would be a significant rework.",
"parentUuid": "33b82f9f_99caaf4d",
"range": {
"startLine": 44,
"startChar": 0,
"endLine": 44,
"endChar": 1
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -40,6 +64,24 @@
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "32214bbc_8fb3be83",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 50,
"author": {
"id": 1000225
},
"writtenOn": "2022-09-20T14:01:14Z",
"side": 1,
"message": "You\u0027re right, I could allocate them on demand, whenever a fragmented resource is encountered on a slot. I\u0027ll do that in the next patch set",
"parentUuid": "a2b9dee1_9d5a3db1",
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -62,6 +104,30 @@
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "fa659b74_5992edd1",
"filename": "src/tetra_upper_mac.h",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 1000225
},
"writtenOn": "2022-09-20T14:01:14Z",
"side": 1,
"message": "You\u0027re right, it\u0027s kind of underdocumented. I\u0027ll make sure to annotate the fields. Booleans are used nowhere in the osmo-tetra project, so I sticked with what seems to be convention. tetra_mac_state for instance uses a signed int for the is_traffic field. If you want, I can start using the bool type or make the active field and similar fields a uint8_t.",
"parentUuid": "48383659_ca5a1eda",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 3
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}