tetra
/
osmo-tetra
mirror of https://gerrit.osmocom.org/osmo-tetra
4
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000225 \u003c1000225@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000225\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000225\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000225 2023-07-27 13:54:28 +00:00 committed by Gerrit Code Review
parent a88f7719c7
commit cfe1aae905
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
db674c8824a2b55db37580d2fbc5c72ac48200d1
View File

@ -22,6 +22,30 @@
},
"revId": "db674c8824a2b55db37580d2fbc5c72ac48200d1",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "35370629_c776ea50",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 301,
"author": {
"id": 1000225
},
"writtenOn": "2023-07-27T13:54:28Z",
"side": 1,
"message": "I agree, but it is in line with what\u0027s also present at several other locations in this file. I\u0027d suggest I file a separate commit where I replace the \"msg-\u003etail -\u003d var\" construction with msgb_get(msg, var) calls. I can then also properly test the change doesn\u0027t inadvertedly break things.",
"parentUuid": "b09ed4e4_47cac60e",
"range": {
"startLine": 301,
"startChar": 0,
"endLine": 301,
"endChar": 4
},
"revId": "db674c8824a2b55db37580d2fbc5c72ac48200d1",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}