tetra
/
osmo-tetra
mirror of https://gerrit.osmocom.org/osmo-tetra
4
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000225 \u003c1000225@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"laforge replied on the change"}
This commit is contained in:
Gerrit User 1000004 2022-09-22 06:24:19 +00:00 committed by Gerrit Code Review
parent f8d9f43ba3
commit 78a424bc9a
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
4a8bd75e1e5f05a62291f7271d7e4c223d122e06
View File

@ -47,6 +47,30 @@
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "7e02e433_691dc283",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 44,
"author": {
"id": 1000004
},
"writtenOn": "2022-09-22T06:24:19Z",
"side": 1,
"message": "OK, then lets keep the global/static variables for now, but add a TODO comment that this actualY should be in some context",
"parentUuid": "6894bd91_c3ed915d",
"range": {
"startLine": 44,
"startChar": 0,
"endLine": 44,
"endChar": 1
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -82,6 +106,24 @@
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "68417ba3_a33b8cf0",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 50,
"author": {
"id": 1000004
},
"writtenOn": "2022-09-22T06:24:19Z",
"side": 1,
"message": "\u003e You\u0027re right, I could allocate them on demand, whenever a fragmented resource is encountered on a slot. I\u0027ll do that in the next patch set\n\nI\u0027m not saying it must be done that way, was just wondering if there was some specific reason.",
"parentUuid": "32214bbc_8fb3be83",
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -128,6 +170,30 @@
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "fd4e73ca_93018ea3",
"filename": "src/tetra_upper_mac.h",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 1000004
},
"writtenOn": "2022-09-22T06:24:19Z",
"side": 1,
"message": "this probably shows how our practices have evolved during the last decade. using bool in C might not have been advisable with comlers used 10+ years ago, but today it clearly is the right thing. please modify, thanks!",
"parentUuid": "fa659b74_5992edd1",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 3
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}