Update patch set 1

Patch Set 1: Code-Review-1

(6 comments)

Patch-set: 1
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 1000225 \u003c1000225@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"fixeria replied on the change"}
This commit is contained in:
Gerrit User 1000010 2022-09-18 13:07:24 +00:00 committed by Gerrit Code Review
parent f4d68dd95a
commit 516b8e37bc
2 changed files with 134 additions and 0 deletions

View File

@ -0,0 +1,107 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "4e9c20e6_86624c56",
"filename": "src/tetra_llc_pdu.h",
"patchSetId": 1
},
"lineNbr": 80,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-18T13:07:24Z",
"side": 1,
"message": "unrelated ws changed",
"range": {
"startLine": 80,
"startChar": 18,
"endLine": 80,
"endChar": 20
},
"revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "32eca4db_e3c142cb",
"filename": "src/tetra_mac_pdu.c",
"patchSetId": 1
},
"lineNbr": 64,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-18T13:07:24Z",
"side": 1,
"message": "In this particular place, it\u0027s a good change. But it should be done in a separate patch.",
"revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "877cd340_dd50c049",
"filename": "src/tetra_mac_pdu.c",
"patchSetId": 1
},
"lineNbr": 97,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-18T13:07:24Z",
"side": 1,
"message": "Please keep the original formatting in this patch. Unrelated changes make it harder to see what\u0027s actually done during code review (and probably later).",
"revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ec5bc71b_677ea78b",
"filename": "src/tetra_mac_pdu.c",
"patchSetId": 1
},
"lineNbr": 387,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-18T13:07:24Z",
"side": 1,
"message": "why are you changing this?\nmaybe it\u0027s your editor doing this automatically?",
"range": {
"startLine": 387,
"startChar": 19,
"endLine": 387,
"endChar": 21
},
"revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d9f119f8_845d348f",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-18T13:07:24Z",
"side": 1,
"message": "I don\u0027t think calling msgb_reset() is needed right after calling msgb_alloc(). It\u0027s already reset when allocated. Correct me if I am wrong.",
"range": {
"startLine": 51,
"startChar": 2,
"endLine": 51,
"endChar": 12
},
"revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "bcfe051a_f99de347",
"filename": "src/tetra_mac_pdu.h",
"patchSetId": 1
},
"lineNbr": 160,
"author": {
"id": 1000010
},
"writtenOn": "2022-09-18T13:07:24Z",
"side": 0,
"message": "unrelated ws change",
"range": {
"startLine": 160,
"startChar": 22,
"endLine": 160,
"endChar": 23
},
"revId": "8000c6059710a86a4f5a3f2857e1978398170ebc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}