tetra
/
osmo-tetra
mirror of https://gerrit.osmocom.org/osmo-tetra
4
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 1000225 \u003c1000225@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"wbokslag replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"wbokslag replied on the change"}
This commit is contained in:
Gerrit User 1000225 2022-09-22 09:48:58 +00:00 committed by Gerrit Code Review
parent 420dce95c0
commit 329d1aa717
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
4a8bd75e1e5f05a62291f7271d7e4c223d122e06
View File

@ -71,6 +71,30 @@
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "61706a60_d619f989",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 44,
"author": {
"id": 1000225
},
"writtenOn": "2022-09-22T09:48:58Z",
"side": 1,
"message": "Done",
"parentUuid": "7e02e433_691dc283",
"range": {
"startLine": 44,
"startChar": 0,
"endLine": 44,
"endChar": 1
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -124,6 +148,24 @@
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "c42479b4_d6d791c3",
"filename": "src/tetra_upper_mac.c",
"patchSetId": 3
},
"lineNbr": 50,
"author": {
"id": 1000225
},
"writtenOn": "2022-09-22T09:48:58Z",
"side": 1,
"message": "I think dynamic allocation is a good idea, since besides saving a few kilobytes of ram, it also removes the requirement of invoking an initialisation function in tetra-rx.c. Current patch set allocates a message buffer when required and frees it when either the mac/end is encountered or when it is aged out.",
"parentUuid": "68417ba3_a33b8cf0",
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -194,6 +236,30 @@
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "28754212_63505ba7",
"filename": "src/tetra_upper_mac.h",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 1000225
},
"writtenOn": "2022-09-22T09:48:58Z",
"side": 1,
"message": "Done",
"parentUuid": "fd4e73ca_93018ea3",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 3
},
"revId": "4a8bd75e1e5f05a62291f7271d7e4c223d122e06",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}