diff --git a/40843da7bd30c17fb1c99bc08bbc66b29820eccb b/40843da7bd30c17fb1c99bc08bbc66b29820eccb index d64f4f4..131d15e 100644 --- a/40843da7bd30c17fb1c99bc08bbc66b29820eccb +++ b/40843da7bd30c17fb1c99bc08bbc66b29820eccb @@ -23,6 +23,30 @@ "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": false, + "key": { + "uuid": "55e91c83_fd285847", + "filename": "src/tetra_llc_pdu.h", + "patchSetId": 1 + }, + "lineNbr": 80, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 1, + "message": "tl_sdu_len needs to be changed from a uint8_t to uint32_t because, due to defragmentation, pdus may become longer than 255 bits. As such, I feel like it is related to this change, however, I now mention the change in the commit message.", + "parentUuid": "4e9c20e6_86624c56", + "range": { + "startLine": 80, + "startChar": 18, + "endLine": 80, + "endChar": 20 + }, + "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -40,6 +64,24 @@ "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": false, + "key": { + "uuid": "2910a82b_bcfbb131", + "filename": "src/tetra_mac_pdu.c", + "patchSetId": 1 + }, + "lineNbr": 64, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 1, + "message": "Removed these changes from the patch", + "parentUuid": "32eca4db_e3c142cb", + "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -57,6 +99,24 @@ "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": false, + "key": { + "uuid": "c0ffeaa7_7c6328fa", + "filename": "src/tetra_mac_pdu.c", + "patchSetId": 1 + }, + "lineNbr": 97, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 1, + "message": "Removed these changes from the patch", + "parentUuid": "877cd340_dd50c049", + "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -80,6 +140,30 @@ "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": false, + "key": { + "uuid": "e10a0629_3c39e6e0", + "filename": "src/tetra_mac_pdu.c", + "patchSetId": 1 + }, + "lineNbr": 387, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 1, + "message": "Removed these changes from the patch", + "parentUuid": "ec5bc71b_677ea78b", + "range": { + "startLine": 387, + "startChar": 19, + "endLine": 387, + "endChar": 21 + }, + "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -102,6 +186,30 @@ }, "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "7aa4150d_d951feef", + "filename": "src/tetra_upper_mac.c", + "patchSetId": 1 + }, + "lineNbr": 51, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 1, + "message": "You\u0027re right, removed the msgb_reset() call.", + "parentUuid": "d9f119f8_845d348f", + "range": { + "startLine": 51, + "startChar": 2, + "endLine": 51, + "endChar": 12 + }, + "revId": "40843da7bd30c17fb1c99bc08bbc66b29820eccb", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file diff --git a/8000c6059710a86a4f5a3f2857e1978398170ebc b/8000c6059710a86a4f5a3f2857e1978398170ebc index 046a6c1..9b0b84d 100644 --- a/8000c6059710a86a4f5a3f2857e1978398170ebc +++ b/8000c6059710a86a4f5a3f2857e1978398170ebc @@ -22,6 +22,30 @@ }, "revId": "8000c6059710a86a4f5a3f2857e1978398170ebc", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "bd224154_54691990", + "filename": "src/tetra_mac_pdu.h", + "patchSetId": 1 + }, + "lineNbr": 160, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 0, + "message": "Hmm missed this one in my second patch set. I was trying to keep the linter from complaining. In the future, I\u0027ll push a commit fixing linting issues in files I touch before committing my actual modifications, is that ok?", + "parentUuid": "bcfe051a_f99de347", + "range": { + "startLine": 160, + "startChar": 22, + "endLine": 160, + "endChar": 23 + }, + "revId": "8000c6059710a86a4f5a3f2857e1978398170ebc", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file diff --git a/db00cef2b48d859e319b642c20a4556d81fb037b b/db00cef2b48d859e319b642c20a4556d81fb037b new file mode 100644 index 0000000..2be9b3b --- /dev/null +++ b/db00cef2b48d859e319b642c20a4556d81fb037b @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "363e6be4_f01af325", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 1000225 + }, + "writtenOn": "2022-09-18T13:57:12Z", + "side": 1, + "message": "Thanks for your attention, I resolved the issues. ", + "revId": "db00cef2b48d859e319b642c20a4556d81fb037b", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + } + ] +} \ No newline at end of file