From 8680677256a3c1b03167c2a99cb5d17756b6d33a Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 26 Jan 2022 13:58:34 +0100 Subject: [PATCH] card_emu_uart_interrupt: ASSERT if we get called with wrong uart_chan This is what we do in all other functions, not sure why this one wants to silently ignore any such programming errors. Change-Id: I022eee86a5a3b5077abe59897161578ed960f1b1 --- firmware/libcommon/source/mode_cardemu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 28763ee9..2a8e4772 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -410,10 +410,9 @@ void card_emu_uart_reset_wt(uint8_t uart_chan) /* call-back from card_emu.c to force a USART interrupt */ void card_emu_uart_interrupt(uint8_t uart_chan) { + OSMO_ASSERT(uart_chan < ARRAY_SIZE(cardem_inst)); Usart *usart = get_usart_by_chan(uart_chan); - if (!usart) { - return; - } + if (USART0 == usart) { NVIC_SetPendingIRQ(USART0_IRQn); } else if (USART1 == usart) {