sim-card
/
qemu
Archived
10
0
Fork 0

do proper cpu_self check

Currently, our check for qemu_cpu_self only checks if there is a cpu
currently in execution (represented by cpu_single_env being set). While
this might be okay for tcg, it is certainly not okay for kvm, since multiple
cpus might be executing.

Instead, I propose we use pthread primitives to test if the caller thread is
the same as env->thread.

For tcg, it will have the same semantics as before, since all CPUStates will
point to the same thread, and we'll only have one in execution at a time.

Signed-off-by: Glauber Costa <glommer@mothafucka.localdomain>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Glauber Costa 2009-09-28 15:27:44 -03:00 committed by Anthony Liguori
parent 47cbc7aa5e
commit e5bc201df7
1 changed files with 7 additions and 2 deletions

9
vl.c
View File

@ -3591,9 +3591,14 @@ void qemu_cpu_kick(void *_env)
qemu_thread_signal(env->thread, SIGUSR1);
}
int qemu_cpu_self(void *env)
int qemu_cpu_self(void *_env)
{
return (cpu_single_env != NULL);
CPUState *env = _env;
QemuThread this;
qemu_thread_self(&this);
return qemu_thread_equal(&this, env->thread);
}
static void cpu_signal(int sig)