From bfa50bc2638d877cf2900712b7503be22e8811cb Mon Sep 17 00:00:00 2001 From: aliguori Date: Tue, 18 Nov 2008 20:26:41 +0000 Subject: [PATCH] Remove premature memop TB terminations (Jan Kiszka) Now that we can properly restore the pc on watchpoint hits, there is no more need for prematurely terminating TBs if watchpoints are present. Remove all related bits. Signed-off-by: Jan Kiszka Signed-off-by: Anthony Liguori git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5742 c046a42c-6fe2-441c-8c8c-71466251a162 --- exec.c | 4 ---- target-arm/translate.c | 6 ------ target-m68k/translate.c | 6 ------ 3 files changed, 16 deletions(-) diff --git a/exec.c b/exec.c index 0dd4aa3d8..b49162cfe 100644 --- a/exec.c +++ b/exec.c @@ -1325,10 +1325,6 @@ int cpu_watchpoint_insert(CPUState *env, target_ulong addr, target_ulong len, env->watchpoints = wp; tlb_flush_page(env, addr); - /* FIXME: This flush is needed because of the hack to make memory ops - terminate the TB. It can be removed once the proper IO trap and - re-execute bits are in. */ - tb_flush(env); if (watchpoint) *watchpoint = wp; diff --git a/target-arm/translate.c b/target-arm/translate.c index 237c5f694..54eb0670b 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -8729,12 +8729,6 @@ static inline void gen_intermediate_code_internal(CPUState *env, gen_set_label(dc->condlabel); dc->condjmp = 0; } - /* Terminate the TB on memory ops if watchpoints are present. */ - /* FIXME: This should be replacd by the deterministic execution - * IRQ raising bits. */ - if (dc->is_mem && env->watchpoints) - break; - /* Translation stops when a conditional branch is enoutered. * Otherwise the subsequent code could get translated several times. * Also stop translation when a page boundary is reached. This diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 49e2cb27d..a14f6c560 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -3027,12 +3027,6 @@ gen_intermediate_code_internal(CPUState *env, TranslationBlock *tb, dc->insn_pc = dc->pc; disas_m68k_insn(env, dc); num_insns++; - - /* Terminate the TB on memory ops if watchpoints are present. */ - /* FIXME: This should be replaced by the deterministic execution - * IRQ raising bits. */ - if (dc->is_mem && env->watchpoints) - break; } while (!dc->is_jmp && gen_opc_ptr < gen_opc_end && !env->singlestep_enabled && (pc_offset) < (TARGET_PAGE_SIZE - 32) &&