From b88155286ad665e01180f767ebdb8ec3b4d15935 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326> Date: Fri, 5 Apr 2024 11:42:12 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"} --- b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49 b/b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49 index d36faa73..1be7152c 100644 --- a/b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49 +++ b/b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49 @@ -51,6 +51,24 @@ "message": "Maybe this is already done somewhere, but if not: it would probably be a good idea to explicitly turn it into a string somewhere. Otherwise code dealing with it may assume it is a string and then could result in an error elsewhere in the code?", "revId": "b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "a3bff47c_9445e860", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 1000004 + }, + "writtenOn": "2024-04-05T11:42:12Z", + "side": 1, + "message": "The function is typically used for input validation. ApiParamBase.decode() method first calls verify_encoded(), then _decode(), then verify_decoded(). So verify_decoded is just made a bit more input tolerant. The output type of the overall ApiParamBase.decode() is always an int. \n\nFor encoding: the encode() method returns str(data) and hence always a string, as you request", + "parentUuid": "9f2b0307_ebebc57a", + "revId": "b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file