sim-card
/
pysim
mirror of https://gerrit.osmocom.org/pysim
10
0
Fork 1
Code Issues Releases Wiki Activity

pySim-prog.py: add presence/length checks for user-provided SPN 

Change-Id: I35fab9a85efda2b83f221a460d31c7d41db582b0
This commit is contained in:
Supreeth Herle 2020-01-21 13:32:46 +01:00 committed by Vadim Yanitskiy
parent 6af4c21cdf
commit 840a9e2a76
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pySim-prog.py
View File

@ -274,6 +274,10 @@ def gen_parameters(opts):
# Digitize MCC/MNC (5 or 6 digits)
plmn_digits = _mcc_mnc_digits(mcc, mnc)
if opts.name is not None:
if len(opts.name) > 16:
raise ValueError('Service Provider Name must max 16 characters!');
# ICCID (19 digits, E.118), though some phase1 vendors use 20 :(
if opts.iccid is not None:
iccid = opts.iccid

5
pySim/cards.py
View File

@ -613,8 +613,9 @@ class SysmoUSIMSJS1(Card):
data, sw = self._scc.update_binary('00F7', content)
# set Service Provider Name
content = enc_spn(p['name'], True, True)
data, sw = self._scc.update_binary('6F46', rpad(content, 32))
if p.get('name') is not None:
content = enc_spn(p['name'], True, True)
data, sw = self._scc.update_binary('6F46', rpad(content, 32))
# write EF.IMSI
data, sw = self._scc.update_binary('6f07', enc_imsi(p['imsi']))