sim-card
/
pysim
mirror of https://gerrit.osmocom.org/pysim
10
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review+1

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 1000147 <1000147@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 5fa78c2598659e6a0471dc74c3f6bfd8996e38e3
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000147\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000147\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000147 2024-04-03 11:49:23 +00:00 committed by Gerrit Code Review
parent 9fdd34ce12
commit 62a6d7fb64
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49
View File

@ -16,6 +16,41 @@
"message": "the build failure seems completely unrelated, I created https://osmocom.org/issues/6430",
"revId": "b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "cb393de9_8aa9c37f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2024-04-03T11:49:23Z",
"side": 1,
"message": "Fix is in https://gerrit.osmocom.org/c/docker-playground/+/36516, already deployed it to show it works",
"parentUuid": "0213c6ee_a007d5d6",
"revId": "b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "9f2b0307_ebebc57a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2024-04-03T11:49:23Z",
"side": 1,
"message": "Maybe this is already done somewhere, but if not: it would probably be a good idea to explicitly turn it into a string somewhere. Otherwise code dealing with it may assume it is a string and then could result in an error elsewhere in the code?",
"revId": "b2b29cfed1d0b23d004b3ec122c7c9d1c51f4d49",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}