mirror of https://gerrit.osmocom.org/pysim
pySim-shell: Use argparser for verify_adm to support --help
Let's add a proper argparser instance for the 'verify_adm' command, avoiding situations where the user types 'verif_adm --help' and then --help is interpreted as the PIN value, removing one more attempt from the failed ADM1 counter. Let's use that opportunity to improve the documentation of the command. Change-Id: I3321fae66a11efd00c53b66c7890fce84796e658
This commit is contained in:
parent
0ba3fd996a
commit
469db9393f
|
@ -137,10 +137,11 @@ Example:
|
||||||
|
|
||||||
verify_adm
|
verify_adm
|
||||||
~~~~~~~~~~
|
~~~~~~~~~~
|
||||||
Verify the ADM (Administrator) PIN specified as argument. This is typically needed in order
|
|
||||||
to get write/update permissions to most of the files on SIM cards.
|
|
||||||
|
|
||||||
Currently only ADM1 is supported.
|
.. argparse::
|
||||||
|
:module: pySim-shell
|
||||||
|
:func: PySimCommands.verify_adm_parser
|
||||||
|
|
||||||
|
|
||||||
Example (successful):
|
Example (successful):
|
||||||
::
|
::
|
||||||
|
|
|
@ -776,11 +776,19 @@ class PySimCommands(CommandSet):
|
||||||
else:
|
else:
|
||||||
self._cmd.poutput("no description available")
|
self._cmd.poutput("no description available")
|
||||||
|
|
||||||
def do_verify_adm(self, arg):
|
verify_adm_parser = argparse.ArgumentParser()
|
||||||
"""VERIFY the ADM1 PIN"""
|
verify_adm_parser.add_argument('ADM1', nargs='?', type=str,
|
||||||
if arg:
|
help='ADM1 pin value. If none given, CSV file will be queried')
|
||||||
|
|
||||||
|
@cmd2.with_argparser(verify_adm_parser)
|
||||||
|
def do_verify_adm(self, opts):
|
||||||
|
"""Verify the ADM (Administrator) PIN specified as argument. This is typically needed in order
|
||||||
|
to get write/update permissions to most of the files on SIM cards.
|
||||||
|
|
||||||
|
Currently only ADM1 is supported."""
|
||||||
|
if opts.ADM1:
|
||||||
# use specified ADM-PIN
|
# use specified ADM-PIN
|
||||||
pin_adm = sanitize_pin_adm(arg)
|
pin_adm = sanitize_pin_adm(opts.ADM1)
|
||||||
else:
|
else:
|
||||||
# try to find an ADM-PIN if none is specified
|
# try to find an ADM-PIN if none is specified
|
||||||
result = card_key_provider_get_field(
|
result = card_key_provider_get_field(
|
||||||
|
|
Loading…
Reference in New Issue