sim-card
/
osmo-remsim
mirror of https://gerrit.osmocom.org/osmo-remsim
10
0
Fork 0
Code Issues Releases Wiki Activity

Fix various 'uninitialized variable' bugs reported by coverity 

The asn1c-generated struct definitions have an automatic _asn_ctx
member, and we never initialize that so far.  Let's do an explicit
memset().

Closes: CID#307545, CID#307543, CID#307541, CID#307536, CID#307536
Closes: CID#307534
Change-Id: I217ebbc92935aefaf55d19a14c93a24e5b8fce64
This commit is contained in:
Harald Welte 2023-02-03 20:19:44 +01:00
parent c69d5c8da7
commit 99ea365ce7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/rspro_util.c
View File

@ -515,6 +515,7 @@ void rspro2bank_slot(struct bank_slot *out, const BankSlot_t *in)
void bank_slot2rspro(BankSlot_t *out, const struct bank_slot *in)
{
memset(out, 0, sizeof(*out));
out->bankId = in->bank_id;
out->slotNr = in->slot_nr;
}
@ -527,6 +528,7 @@ void rspro2client_slot(struct client_slot *out, const ClientSlot_t *in)
void client_slot2rspro(ClientSlot_t *out, const struct client_slot *in)
{
memset(out, 0, sizeof(*out));
out->clientId = in->client_id;
out->slotNr = in->slot_nr;
}