From 550b2958d33c1731a37b0898b1fec018b2071cb9 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 4 Dec 2019 21:22:54 +0100 Subject: [PATCH] bankd: Fix log print during removeMapping We need to dereference 'rreq' nor 'creq' in the remove handling. Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a --- src/bankd/bankd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 7851a2b..7b50a73 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -190,11 +190,11 @@ static int bankd_srvc_handle_rx(struct rspro_server_conn *srvc, const RsproPDU_t rreq = &pdu->msg.choice.removeMappingReq; if (rreq->bank.bankId != g_bankd->srvc.bankd.bank_id) { LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies invalid Bank ID %lu " - "(we are %u)\n", creq->bank.bankId, g_bankd->srvc.bankd.bank_id); + "(we are %u)\n", rreq->bank.bankId, g_bankd->srvc.bankd.bank_id); resp = rspro_gen_RemoveMappingRes(ResultCode_illegalBankId); } else if (rreq->bank.slotNr >= g_bankd->srvc.bankd.num_slots) { LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies invalid Slot Nr %lu " - "(we have %u)\n", creq->bank.slotNr, g_bankd->srvc.bankd.num_slots); + "(we have %u)\n", rreq->bank.slotNr, g_bankd->srvc.bankd.num_slots); resp = rspro_gen_RemoveMappingRes(ResultCode_illegalSlotId); } else { rspro2bank_slot(&bs, &rreq->bank);