From 50a0972a87ac0c8914fce13c917903df9f3296a9 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 8 Dec 2021 15:33:12 +0100 Subject: [PATCH] bankd_pcsc: Don't log every successful SCardTransmit Contrary to other operations, SCardTransmit has a much higher frequency and the logs should not be clobbered with "OK" lines all over the place. Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 --- src/bankd/bankd_pcsc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 5bc7bb8..91eeadd 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -297,9 +297,10 @@ static int pcsc_transceive(struct bankd_worker *worker, const uint8_t *out, size long rc; rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, in_len); - PCSC_ERROR(worker, rc, "SCardTransmit"); + /* don't use PCSC_ERROR here as we don't want to log every successful SCardTransmit */ + if (rc != SCARD_S_SUCCESS) + LOGW_PCSC_ERROR(worker, rc, "SCardTransmit"); -end: return rc; }