From 2d5d4c3beea33abc6fe7487742672ed0a2279916 Mon Sep 17 00:00:00 2001
From: Harald Welte <laforge@osmocom.org>
Date: Fri, 3 Feb 2023 20:23:34 +0100
Subject: [PATCH] rest_api: strtoul canot return negative

>>>     CID 307538:  Control flow issues  (NO_EFFECT)
>>>     This less-than-zero comparison of an unsigned value is never true. "map_id < 0UL".

Closes: CID#307538
Change-Id: Ic5019e216dd7b26be0bd988df218a2cb5775e411
---
 src/server/rest_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/rest_api.c b/src/server/rest_api.c
index d3279c4..6e025ad 100644
--- a/src/server/rest_api.c
+++ b/src/server/rest_api.c
@@ -410,7 +410,7 @@ static int api_cb_slotmaps_del(const struct _u_request *req, struct _u_response
 		goto err;
 	}
 	map_id = strtoul(slotmap_id_str, NULL, 10);
-	if (map_id < 0) {
+	if (map_id == ULONG_MAX && errno != 0) {
 		status = 400;
 		goto err;
 	}