From 90c6d87b468edaa5613652a6c3773638a8efe1ae Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Thu, 17 Dec 2020 11:56:11 +0100 Subject: [PATCH] icE1usb fw: Disable reporting of 'loss of timing' for now This works half way decent enough to make the LED status change visibly in case the physical link is disconnected. However, we will generate a storm of USB interrupt endpoint messages if we leave this on Change-Id: I9d0ddb2d404880c4a85e30de1b4bf4204d468ab7 --- firmware/ice40-riscv/icE1usb/e1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c index 38229f6..a2cd654 100644 --- a/firmware/ice40-riscv/icE1usb/e1.c +++ b/firmware/ice40-riscv/icE1usb/e1.c @@ -389,7 +389,9 @@ e1_poll(void) uint16_t cur_tick = e1_tick_read_rx(0); if (g_e1.rx.last_tick == cur_tick) { e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_OFF); - g_e1.errors.flags |= E1_ERR_F_LOS; + /* FIXME: this is very flaky, we are probably getting some noise + * at the Rx tick counter if the cable is disconnected? */ + //g_e1.errors.flags |= E1_ERR_F_LOS; } else { e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK); g_e1.errors.flags &= ~E1_ERR_F_LOS;