retronetworking
/
isdn4k-utils
13
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

There was no bounds checking on unknownzones, which is only useds 

if DEBUG is defined. This caused a SIGSEGV with many unknown numbers
(which were all the same, BTW...)  Now only do unknownzones if DEBUG
is defined.
This commit is contained in:
Paul Slootman 2004-02-25 12:09:08 +00:00
parent cc5caae786
commit 3a6e607452
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
isdnlog/isdnrep/isdnrep.c
View File

@ -24,6 +24,13 @@
*
*
* $Log$
* Revision 1.98 2003/11/14 20:29:29 tobiasb
* Removed SIGSEGV in isdnrep that occurred while fetching zone names for outgoing calls
* from the current ratefile if the matching zone did not contain a name after the zone
* number. This error was introduced with isdnrep-4.65 or rev. 1.96 of isdnrep.c.
* Uwe Furchheim discovered the error and provided sufficient details on the mailinglist
* rates4linux-users, see http://sourceforge.net/mailarchive/forum.php?forum_id=4262
*
* Revision 1.97 2003/10/29 17:41:35 tobiasb
* isdnlog-4.67:
* - Enhancements for isdnrep:
@ -434,7 +441,10 @@ static int usage_provider[MAXPROVIDER];
static int provider_failed[MAXPROVIDER];
static double duration_provider[MAXPROVIDER];
static double pay_provider[MAXPROVIDER];
#if DEBUG
#include <assert.h>
static char unknownzones[4096];
#endif
#undef MAXPROVIDER
#define MAXPROVIDER getNProvider()
@ -579,7 +589,9 @@ int read_logfile(char *myname)
msn_sum = calloc(mymsns + 1, sizeof(double));
usage_sum = calloc(mymsns + 1, sizeof(int));
dur_sum = calloc(mymsns + 1, sizeof(double));
#if DEBUG
*unknownzones = 0;
#endif
_myname = myname;
_begintime = begintime;
@ -1973,12 +1985,16 @@ static int print_entries(one_call *cur_call, double unit, int *nx, char *myname)
zones_usage[zone] += 1;
#if DEBUG
if (zone == UNKNOWNZONE) {
assert(strlen(unknownzones) + 4 < sizeof(unknownzones));
if (*unknownzones)
strcat(unknownzones, ", ");
assert(strlen(unknownzones) + strlen(cur_call->num[1]) < sizeof(unknownzones));
strcat(unknownzones, cur_call->num[1]);
} /* if */
#endif
add_one_call(computed ? &day_com_sum : &day_sum, cur_call, unit);