Commit Graph

16092 Commits

Author SHA1 Message Date
Anthony Minessale d171e156d7 fix issues with heartbeat in bypass media mode 2014-04-24 23:21:15 +05:00
William King bcc2aa9899 Fixing memory leak that would occur when reloading mod_xml_curl 2014-04-24 09:13:00 -07:00
Anthony Minessale 4def48b881 revert 2014-04-24 20:58:23 +05:00
Anthony Minessale 2e0cd74e07 FS-6477 --resolve 2014-04-22 23:51:44 +05:00
Anthony Minessale 61e22e8b50 FS-6476 --resolve 2014-04-22 23:25:41 +05:00
Chris Rienzo 25c9b6196b mod_rayo: preserve old caller ID behavior if display name is not given 2014-04-22 13:30:15 -04:00
Chris Rienzo 1eab82ba2d mod_rayo: relax recent caller ID restrictions a bit 2014-04-22 08:50:50 -04:00
Travis Cross 175c9eebca Remove extraneous abort(3) when sending chat
This appears to have been accidentally added in commit
79ebcb104b which sought to provide a
mechanism for disabling Sofia's chat interface.  The abort(3) here
achieved that a bit too well.
2014-04-19 19:26:27 +00:00
Anthony Minessale 79ebcb104b add enable-chat sofia profile param which defaults to true when not present, set to false to turn off the chat interface in sofia 2014-04-19 12:29:10 -05:00
Travis Cross 59fd9b90d0 Correct display of last write timestamp
On start DTMF packets we were showing the last write timestamp as a
signed value when it's an unsigned value, which could result in it
appearing incongruous with later packets where the value was displayed
correctly.
2014-04-19 01:48:49 +00:00
Brian West 265de3d314 FS-6082 --resolve 2014-04-18 15:17:23 -05:00
Brian West 190c241c81 FS-6452 mod_spy doesn't react on events without variable_domain_name 2014-04-17 20:12:27 -05:00
Anthony Minessale 18df083c69 don't send heartbeat until the first timeout has elapsed rather than instantly 2014-04-18 00:06:24 +05:00
Seven Du 37ee4299fb fix compiler warning 2014-04-17 14:58:18 +08:00
Anthony Minessale bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
Anthony Minessale 2bc2811050 FS-5997 regression from commit 70accd9f27 this caused some attended transfers to calls with multiple targets to get the abondoned channels to be stuck on write lock 2014-04-17 02:41:40 +05:00
William King 748b7dea3c Get rid of a small memory leak when the configs are reloaded in mod_enum 2014-04-16 09:27:34 -07:00
Anthony Minessale a4a792488b add generic keepalive system and implement it in sofia to send MESSAGE or INFO packets in-dialog at specified interval.
Adds app: enable_keepalive 0|<seconds>
This app can be run in the dialplan or with execute_on_* type variables for B-legs.

Adds sofia param: keepalive-method  : defaults to MESSAGE can also be "INFO"
This param sets which SIP method to use.
2014-04-16 06:10:25 +05:00
Chris Rienzo ae69c5a7b0 FS-6407 --resolve mod_rayo: support SIP URI caller ID w/ display name 2014-04-15 14:27:49 -04:00
Raymond Chandler 052638186b add parsing of user params on invite 2014-04-15 12:48:07 -04:00
Anthony Minessale b99ef3af01 add SWITCH_MESSAGE_HEARTBEAT_EVENT indication to execute on a session when session heartbeat fires 2014-04-15 21:22:36 +05:00
Nathan Neulinger 96523a9bef mod_skinny: fix leak 2014-04-14 15:04:06 -05:00
Nathan Neulinger 93a84cf130 FS-6460 --resolve fix leaked RTP ports that cause mod_skinny to fail after N calls 2014-04-14 13:23:05 -05:00
Chris Rienzo e8078d8aef mod_rayo: clean up module hashes on shutdown 2014-04-14 12:01:31 -04:00
Chris Rienzo b0c2c6d67c FS-6447 --resolve return subscriber-absent platform-code 20 if <dial> is attempted to user that is not registered 2014-04-14 09:47:41 -04:00
Peter Olsson 295964f0ec FS-6457 --resolve
Upgrade to OpenSSL 1.0.1g in Windows build (Visual Studio 2010 and 2012)
2014-04-13 10:01:17 +02:00
Travis Cross 2dba7dd367 Avoid leaking memory on mod_cdr_sqlite unload 2014-04-12 06:59:02 +00:00
Travis Cross 39f960a212 Avoid leaking memory on mod_voicemail unload 2014-04-12 06:48:36 +00:00
Travis Cross 886a730ae8 Avoid leaking memory on mod_hash unload 2014-04-12 06:43:11 +00:00
Travis Cross 237da22e22 Avoid leaking memory on unload of mod_dptools
Automated leak detectors find leaked memory on shutdown.  Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-12 06:31:31 +00:00
Travis Cross 12af80d6b2 Condense styling a bit 2014-04-12 05:06:51 +00:00
Travis Cross 538cdd378c Hide warning about sometimes initialized variable
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-12 05:02:09 +00:00
Travis Cross 3f8cf4a59d Fix memory leak in subscription handling
We were leaking one event (~539 bytes) for every subscribe packet
received with both an "event: as-feature-event" and an authorization
header.
2014-04-12 05:00:41 +00:00
James Le Cuirot 4bdb7129ba Ungetlib libmemcached
Tested with several libmemcached versions between 0.31 and
1.0.18. Unfortunately the API is extremely volatile and awkward to
use. Packaging scripts still need addressing.

FS-353
2014-04-11 22:55:36 +00:00
James Le Cuirot 23fe7f5c9f Add libyaml pkg-config LIBS to LIBADD not LDFLAGS
Per the automake manual these should go in LIBADD.

http://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html

FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-04-11 22:53:14 +00:00
Anthony Minessale 38c6e89db0 remove SSML from mod_rss 2014-04-11 03:33:57 +05:00
Anthony Minessale 7428746ce2 FS-6453 --resolve 2014-04-11 03:24:14 +05:00
Anthony Minessale 7e9c350532 avoid recomputing hash 2014-04-11 03:08:27 +05:00
Anthony Minessale f1d7721710 FS-6448 --resolve revert string func patch cos some things free it 2014-04-11 02:36:13 +05:00
Chris Rienzo a86623972d mod_rayo: fixed input crash introduced in 2014-04-07 commit 2014-04-10 10:20:47 -04:00
Travis Cross b72194b72b Move loop exit conditionals
The net effect here is the code looks more "regular" and reads more
linearly.
2014-04-09 18:41:03 +00:00
Travis Cross 4a8dace5ab Avoid considering more phrase actions after break
Previously we would continue considering phrase actions even after
receiving a break action; we would only break on the next input
clause.  It appears the intent here was to break before the next
action.
2014-04-09 18:41:02 +00:00
Travis Cross 75b8f3e0a8 Improve comment 2014-04-09 18:41:02 +00:00
Travis Cross ffc3f9bb0b Consolidate two conditionals
If we get SWITCH_STATUS_BREAK then we didn't get
SWITCH_STATUS_SUCCESS.
2014-04-09 18:41:02 +00:00
Travis Cross 549aba0d2f Remove variable assignment without effect
We're breaking out of the loop here anyway, so setting done to true is
useless.
2014-04-09 18:41:02 +00:00
Travis Cross 2ace7bc79b Fix memory leak in phrase macro playback
We were leaking memory when break_on_match was set or when we received
back SWITCH_STATUS_BREAK from a callee as we were failing to free
field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross f83d6770ff Remove tautological conditional
If pattern is null we're setting it to a non-null value, so this
branch will always be taken.

Use `git diff -w` or `git log -p -w` to see what's going on in this
commit.
2014-04-09 18:41:02 +00:00
Travis Cross 1a71cf886e Fix memory leak on memory error
In the event of a memory error, we were trying to free a null pointer
while leaking the allocation for field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross a0b8d92219 Move variables down into loop where they're used
These variables aren't used outside of this for loop, so they should
be declared within it.
2014-04-09 18:41:01 +00:00
Anthony Minessale 4178688b4a add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc 2014-04-09 23:26:47 +05:00
Anthony Minessale d789c6470a free global pool on shutdown 2014-04-09 23:26:47 +05:00
Anthony Minessale 0449baca59 clear event queue on shutdown 2014-04-09 23:26:46 +05:00
Travis Cross 2d811e0ba0 Suppress spurious warning in phrase macro playback
Prior to this commit, if anything at all went wrong in
switch_ivr_phrase_macro_event() we would generate a warning like this:

  [WARNING] switch_ivr_play_say.c:348 Macro [macro_name]: 'pattern_name' did not match any patterns

This is clearly misleading.  The natural thing to do on seeing that
message is to verify that the language files are there, and that the
pattern really does exist in that macro.  But none of that was usually
the problem.  The message would be generated if the language wasn't
found, or if the channel had gone away, for example.

With this commit, we verify that we actually tried looking for the
pattern before displaying the warning about the pattern not matching.
2014-04-09 04:48:09 +00:00
Travis Cross 1e273e514d Avoid playback on dead channels in voicemail
For years we've been generating spurious messages like:

  [WARNING] switch_ivr_play_say.c:348 Macro [voicemail_ack]: 'saved' did not match any patterns

This would happen when the caller hangs up during the playback of
certain prompts in the voicemail system where we weren't checking the
return value of vm_macro_get().  Looking closely at the log, it's
clear we were calling down into switch_ivr_phrase_macro() long after
the channel was gone.

The message above is also misleading -- switch_ivr_phrase_macro()
would have been able to find that pattern just fine, but it never
actually looked because the channel was gone.  We'll clean up that
message in a follow on commit.
2014-04-09 04:46:47 +00:00
Anthony Minessale 369bb55d15 remove unnecessary pool create 2014-04-09 03:18:21 +05:00
Travis Cross 1636550176 Add immediate sanity check on untrusted length
We were actually checking this indirectly in the loop that follows,
but it's more clear to check this immediately and directly.
2014-04-08 21:08:02 +00:00
William King 711e49c46a Don't leak these 4 hash tables when mod_fifo is reloaded 2014-04-08 11:18:23 -07:00
William King aae1954c07 FS-6442 --resolve 2014-04-08 10:36:36 -07:00
Brian West de7d5a9e07 Resolve key length issue with AES GCM 128/256 2014-04-08 11:04:41 -05:00
Anthony Minessale 72c52052dc FS-6436 2014-04-08 20:30:23 +05:00
Chris Rienzo 264a12a4af mod_rayo: fix memory corruption in dial, input, output 2014-04-07 12:37:39 -04:00
Anthony Minessale c98fb0bd0e send muted members as recvonly on RFC4575 data 2014-04-07 20:51:29 +05:00
William King 658d938754 Unused return value 2014-04-06 23:49:05 -07:00
Anthony Minessale 65fd534346 fix seg in complete del with no arg 2014-04-07 01:04:51 +05:00
Anthony Minessale a608550800 FS-5832 regression.... After this change the sticky completes were deleting. This should correct it 2014-04-06 03:51:36 +05:00
Anthony Minessale 77056e3c81 fix seg in alias del 2014-04-05 21:09:28 +05:00
Travis Cross fb7fa3d66a Update gitignore 2014-04-05 07:57:05 +00:00
Travis Cross c26343d0c9 Merge in upstream changes to my-basic
We can't use their new mb_gets() because they call exit(3) in the
event of a read error, which isn't what we want.
2014-04-05 06:48:02 +00:00
Travis Cross 8da4259539 Cleanup whitespace 2014-04-05 06:43:49 +00:00
Travis Cross 32c03b39d9 Replace gets(3) with fgets(3) in my-basic
gets(3) is going away; it's been removed by C11, and gcc now warns on
it, breaking the build.
2014-04-05 04:45:30 +00:00
Brian West 34b31f8f02 swig managed 2014-04-04 07:27:48 -05:00
Michael Jerris 5320075df7 FS-6429: --resolve check return values of fread and gets 2014-04-03 21:43:12 -04:00
Michael Jerris 98237f5962 fix mod_basic clang build warning, we don't need to declare var we don't use on this side of the ifdef 2014-04-03 19:35:43 -04:00
Michael Jerris 4e86b03126 FS-6424: --resolve properly export symbols from stfu 2014-04-03 13:58:13 -04:00
Anthony Minessale 287fd66800 FS-6403 --resolve
This commit also reverts 2 previous attempts to fix this very rare race issue spanning back to 2009

62ce853897 Patch from MOC
3a85348cdf FS-2302 mutex added around switch_xml_toxml()

The real problem was switch_xml_toxml_buf() was actually temporarily modifying the xml structure being searialized to make it appaer to be a root structure then serializing it and restoring the pointers.  This caused a non-threadsafe operation when some other thread was scanning the same xml structure.

This patch removes the modification and instead passes a new arg to switch_xml_toxml_r indicating to treat the structure as if it were a root structure.

This bug has been present since the induction of xml into FS.
2014-04-03 20:30:45 +05:00
Brian West 19e3175518 FS-6422: --resolve obvious copy and paste error 2014-04-03 07:20:41 -05:00
Anthony Minessale 1ce92b3ae7 FS-6421 --resolve 2014-04-02 16:43:36 -05:00
Jeff Lenk 554abf3e0c vs2010 reswig 2014-04-01 18:13:07 -05:00
Anthony Minessale 7151d6acea FS-6402 part 2 2014-04-02 03:21:37 +05:00
Travis Cross a78596221a Add uuid_ring_ready API command
We already had uuid_answer and uuid_pre_answer, so we might as well
add uuid_ring_ready.
2014-04-01 20:58:49 +00:00
Travis Cross 6234a94f41 Cleanup style for consistency 2014-04-01 20:54:44 +00:00
Travis Cross a8dd56f2b3 Convert my_basic files to Unix newline format 2014-04-01 20:41:19 +00:00
Anthony Minessale 5c0cff70b3 FS-6402 --resolve 2014-04-02 01:20:19 +05:00
Michael Jerris 0cc3a17072 FS-6408: fix passing of CPPFLAGS to spandsp build 2014-04-01 13:28:22 -04:00
Ken Rice 6681176ce9 prevent a segfault in mod_basic if someone calls basic from CLI w/ no args 2014-04-01 08:57:15 -05:00
Anthony Minessale e458fa2d5a allow execute with no args 2014-03-31 18:37:35 -05:00
Anthony Minessale 3a2736291e add mod_basic 2014-03-31 18:08:59 -05:00
Anthony Minessale d08116e762 FS-6310 hold up, revert 2014-03-31 17:32:07 -05:00
Anthony Minessale 7532a7e0d5 FS-6310 --resolve try this version 2014-03-31 17:03:01 -05:00
Anthony Minessale aa147fa5fd FS-6412 --resolve 2014-03-31 16:22:33 -05:00
Travis Cross b9369f6d4e Remove stray executable bits 2014-03-31 20:38:09 +00:00
Anthony Minessale c02a5e67b8 FS-6413 --resolve with this patch you will need to make sure the boxes have the clocks synced and both started inside the same occurence of the most recent new year. 2014-03-31 15:23:50 -05:00
Anthony Minessale 107c5eccc3 video refresh floor holder on conference join 2014-03-31 22:39:46 +05:00
Tamas Cseke 9b56dff275 Say zero in time measurement only if it is neccessary 2014-03-31 09:33:17 +02:00
William King e0d9d7f0b2 FS-6410 Adding some log lines to mod_sonar so that it is more clear what is happening when the app is sending and detecting pings. 2014-03-29 19:08:24 -07:00
Brian West 89094cfca0 start updating doxygen 2014-03-28 10:04:31 -05:00
Jeff Lenk 7ed144d115 * Deprecate mod_spidermonkey windows part 1 2014-03-26 18:33:37 -05:00
Michael Jerris d40615267e FS-353: better error reporting for missing lib, don't error on clean 2014-03-26 17:11:18 -04:00
Travis Cross f9d065cda3 Use system libyaml for mod_yaml
FS-353
2014-03-26 19:27:22 +00:00
Travis Cross 5e3ba399c7 Use CPPFLAGS in mod_yaml 2014-03-26 19:27:21 +00:00
Michael Jerris 885fdbf28c hack harder 2014-03-26 14:49:59 -04:00
Travis Cross b0bcc011ea Deprecate mod_spidermonkey
We consider mod_spidermonkey to be completely replaced by mod_v8 (and
more generally by mod_lua) at this point.  We've barely supported
mod_spidermonkey for years.  Everyone should stop using it.

We're keeping this around for awhile in case people are relying on C
extensions to mod_spidermonkey and need time to migrate.  This module
may or may not be part of a v1.4 release depending on whether we find
anyone cares.  It definitely will not be part of the next release
after v1.4.
2014-03-26 18:01:49 +00:00
Michael Jerris 310f2ec3d6 initialize var 2014-03-26 11:25:23 -04:00
Raymond Chandler 5cccc6270b seg-- 2014-03-25 23:31:16 -04:00
Raymond Chandler 0ddd151a22 FS-5845 more leaks found by mikej 2014-03-25 22:44:37 -04:00
Brian West 04de0f77d3 FS-6396 fix mod_silk builid on FreeBSD 2014-03-25 20:25:11 -05:00
Chris Rienzo 98bba8b57a mod_mongo: switched from C++ to latest C driver 2014-03-24 17:34:56 -04:00
Chris Rienzo 0b9e5c82a5 FS-6402 mod_rayo/mod_ssml: add mutex to hashes now that iteration is no longer thread-safe 2014-03-24 17:03:33 -04:00
Michael Jerris 5ac9748827 FS-5845: don't leak dbh in error conditions 2014-03-24 16:10:12 -04:00
Travis Cross cde20f6fe6 Require sqlite as a system dependency
This purges sqlite from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-24 12:54:49 +00:00
James Le Cuirot 8574988c3a Completely unbundle libedit
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-24 12:39:59 +00:00
Jeff Lenk 1cde5f01e0 FS-6386 --resolve 2014-03-23 16:15:49 -05:00
Peter Olsson c8fa0f0c4b mod_v8: Use parallel build by default. Use configure flag "--disable-parallel-build-v8" to disable it. It's disabled by default for Debian build scripts, since parallel build has some issues with cowbuilder. 2014-03-23 09:25:41 +01:00
Peter Olsson 742e28e1c5 FS-6395 2014-03-22 12:56:46 +01:00
Peter Olsson 8be3ca59e2 FS-6395 2014-03-22 11:55:04 +01:00
Brian West f890854e0d FS-6381 add hostname to conference cdr 2014-03-21 17:23:50 -05:00
Jeff Lenk dd242f3ba6 FS-6346 2014-03-20 18:32:19 -05:00
Travis Cross 1470622292 Require libcurl as a system dependency
This purges libcurl from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-20 21:15:29 +00:00
Travis Cross c993962d0b Update some modules to use CPPFLAGS
These modules use curl and we'll be adding in some bits to the
CPPFLAGS.
2014-03-20 21:09:46 +00:00
Travis Cross a489cd311e Cleanup whitespace 2014-03-20 20:35:58 +00:00
Travis Cross 4dec1607ce Revert "Cleanup whitespace"
Too much was staged accidentally on that last commit.

This reverts commit f112627242.
2014-03-20 20:34:18 +00:00
Travis Cross f112627242 Cleanup whitespace 2014-03-20 20:33:34 +00:00
Peter Olsson 03739a8293 FS-6365 --resolve 2014-03-20 19:48:37 +01:00
James Le Cuirot b283db6319 Completely unbundle speex
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-20 15:28:25 +00:00
James Le Cuirot e85f06ee2f Completely unbundle pcre
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-20 15:28:23 +00:00
Brian West 2da4e3d3b8 FS-6293: fix mod_managed srcdir build 2014-03-20 08:34:16 -05:00
Brian West 09811b522f FS-6369: fix uninstall on mod_managed 2014-03-20 08:16:14 -05:00
Michael Jerris 8cd69cc0f4 fix perldir to at least point to install the same place as the code looks for it. Note, on fhs type builds, where prefix is /usr, these files are going to go into /usr/perl, which probably isn't right, but thats where the code looks too, we should do something better for builds that are not in the prefix 2014-03-19 17:24:26 -04:00
Travis Cross 962eaaeae8 Make sure -w is set in mod_perl CXXFLAGS
Autogenerated bits of the code warn when building which would
otherwise break the build.
2014-03-19 21:01:30 +00:00
Michael Jerris f3acb03dc0 S-6341:make sure to unlock too 2014-03-19 16:38:53 -04:00
Brian West c4c0f38aab FS-6294 FS-6308 NetBSD support should work test and report back please. 2014-03-19 14:34:07 -05:00
Michael Jerris 496a6db5c4 cxx 2014-03-19 08:33:47 -04:00
Michael Jerris f575dd6f05 this is a cxx mod 2014-03-19 08:32:25 -04:00
Tamas Cseke 064bf5dde0 FS-6371 --resolve json cdr is missing some caller profile times 2014-03-19 11:01:22 +01:00
Brian West c9757f72a5 FS-6292 additional define to avoid on NetBSD, If someone wants to get this workign please submit patches 2014-03-19 03:35:47 -05:00
Travis Cross 1f76e88f15 Fix mod_opal build
...by separating out CPPFLAGS and CXXFLAGS.
2014-03-19 02:24:59 +00:00
Travis Cross 88e00e220c Use $(shell) make function in mod_opal 2014-03-19 02:24:59 +00:00
Michael Jerris 2ce609ac45 FS-6293: fix mod_spidermonkey srcdir build 2014-03-18 22:20:52 -04:00
Travis Cross bd4af28648 Reorder lines in mod_h323 build 2014-03-19 01:32:03 +00:00
Travis Cross d95d4b5014 Move mod_h323 -fno-exceptions flag to CXXFLAGS 2014-03-19 01:32:03 +00:00
Travis Cross ff3872432f Remove ptlib include in mod_h323
This doesn't seem needed, and the empty include was breaking the
build.
2014-03-19 01:32:03 +00:00
Travis Cross 3dce3d10a0 Move define to CPPFLAGS in mod_h323 2014-03-19 01:32:02 +00:00
Michael Jerris 8bc49da4ba use correct source file 2014-03-18 21:14:36 -04:00
Travis Cross eb9041cdb0 Separate out CFLAGS and CPPFLAGS in mod_h323
CPPFLAGS should contain -I and -D flags.

This also has the effect of fixing the build of this module.
2014-03-19 01:13:51 +00:00
Travis Cross 0e22f1e954 Fix mod_java build issues
...including one syntax error and an underspecified cast.
2014-03-19 00:43:24 +00:00
Seven Du 6e3f4d667c add missing break, please review 2014-03-19 07:58:13 +08:00
Michael Jerris d35a6818a3 fix typo in removing of apr dso funcitons 2014-03-18 19:53:43 -04:00
Michael Jerris 45303fdc93 use right var for -I includes 2014-03-18 19:36:26 -04:00
Michael Jerris 4bbea9664d add depends so these are built 2014-03-18 19:32:02 -04:00
Michael Jerris af0ded1b63 some potential fixes for srcdir, need someone with deps to tell me what doesn't actually work here now 2014-03-18 19:28:16 -04:00
Michael Jerris 0092854513 fix source file 2014-03-18 19:22:37 -04:00
Michael Jerris 1b27ece6b8 fix source file 2014-03-18 19:21:41 -04:00
Michael Jerris 524c566e01 attempt at fixing mod_gsmopen build 2014-03-18 19:11:24 -04:00
Brian West 95392955b6 FS-6375 fix -lutil as its not needed 2014-03-18 17:54:56 -05:00
Brian West 0ea5c4fb4d FS-6369: --resolve fix automake build of mod_managed 2014-03-18 17:48:44 -05:00
Brian West aeebd712f8 FS-6375 exclude sun from modem support in spandsp 2014-03-18 17:37:04 -05:00
Brian West b4ba7e1e2a FS-6370: --resolve build memcache lib on mod build 2014-03-18 17:31:26 -05:00
Michael Jerris 46c7324da5 FS-6293: fix mod_skypopen srcdir build 2014-03-18 18:14:50 -04:00
Travis Cross 14d9f598c1 Build openldap with -j1
Things seem to go wrong when building mod_ldap with make -j.
2014-03-18 22:06:07 +00:00
Michael Jerris 0f4aedef53 lets just consistently use api for version 2014-03-18 17:59:31 -04:00
Michael Jerris b33fcc2fc1 FS-6293: fix mod_xml_rpc srcdir build 2014-03-18 17:49:56 -04:00
Travis Cross 2117f70acf Edit out gcc-ism from soundtouch lib
This allows building mod_soundtouch in clang as clang doesn't support
gcc's -fcheck-new.
2014-03-18 21:39:18 +00:00
Michael Jerris 792530b744 FS-6293: fix srcdir build for mod_opus 2014-03-18 17:38:02 -04:00
Michael Jerris e71a250bd9 FS-6293: fix srcdir build for mod_event_zmq 2014-03-18 17:27:31 -04:00
Michael Jerris 99dcbf0e80 fix clang warning about control reaches end of non-void function 2014-03-18 17:26:59 -04:00
Michael Jerris e63140a4d3 FS-6293: fix mod_codec2 srcdir build 2014-03-18 17:19:40 -04:00
Michael Jerris 6f34441b9f fix clang type warnings 2014-03-18 15:39:33 -04:00
Chris Rienzo 843152b953 Merge branch 'master' of ssh://git.freeswitch.org:222/freeswitch 2014-03-18 15:22:57 -04:00
Chris Rienzo 8d67246636 FS-6374 --resolve mod_rayo sendfax was using uninitialized memory pool 2014-03-18 15:21:27 -04:00
Michael Jerris 3a979c67ab FS-6293: fix mod_cdr_mongodb srcdir build 2014-03-18 15:07:39 -04:00
Michael Jerris bf756f2be6 FS-6293: don't blow up on clean on mod_managed (still does not do srcdir right) 2014-03-18 14:58:48 -04:00
Michael Jerris 63ae87c60f FS-6293: fix srcdir build of mod_rayo 2014-03-18 14:46:21 -04:00
Michael Jerris ea0d5be193 FS-6293: mod_dingaling srcdir build 2014-03-18 14:38:32 -04:00
Michael Jerris 9df17278d7 fix uninitialized variables 2014-03-18 14:28:05 -04:00
Michael Jerris bf4339712a FS-6293: fix spandsp srcdir builds when user is setting cflags 2014-03-18 14:20:40 -04:00
Michael Jerris e077aa0db0 FS-6293: mod_esl srcdir build 2014-03-18 14:07:38 -04:00
Michael Jerris 9f7399c272 FS-6293: fix lua to build using automake, so it works right with srcdir, and avoids the linking to .a is not portable warning 2014-03-18 13:28:52 -04:00
Michael Jerris af192a2e8b FS-6293: abandon xmlrpc-c build system entirely. We can revist this when we try to pull this lib out of tree, in the mean time, this fixes a ton of problems. 2014-03-18 09:50:12 -04:00
Brian West 7990bb44f3 Reswig managed 2014-03-17 20:51:51 -05:00
Michael Jerris 65c58a7ceb FS-6341: fix compiler warning from set but unused var 2014-03-17 18:42:02 -04:00
Michael Jerris 714e3133e7 FS-353: add testing hack to use system xmlrpc-c 2014-03-17 14:33:55 -04:00
Travis Cross c006e97acc Refactor out extraneous call to gettime
We were calling switch_epoch_time_now() twice for no good reason.
2014-03-17 17:47:51 +00:00
Michael Jerris 340b697e1b FS-6341: --resolve add 3pcc invite w/o sdp support for 100rel/PRACK 2014-03-17 12:27:42 -04:00
Michael Jerris 3eb786210d FS-6293: fix mod_shout srcdir build 2014-03-17 10:06:29 -04:00
Michael Jerris 70a3bde76f FS-6293: fix mod_shout srcdir build 2014-03-17 09:46:12 -04:00
Michael Jerris 1c5e61447b move libs/stfu into the core, as it is not really a lib 2014-03-17 09:44:14 -04:00
Michael Jerris 402d422c90 FS-6293: fix mod_shout srcdir build 2014-03-17 08:51:21 -04:00
Michael Jerris 8ed1d4f1ea FS-6293: fix mod_rtmp srcdir build 2014-03-17 08:46:38 -04:00
Michael Jerris a9799f3dae FS-6293: fix mod_silk srcdir build 2014-03-17 08:32:17 -04:00
Jeff Lenk 69cc7014e4 FS-6355 remove check on delete 2014-03-15 23:09:45 -05:00
Michael Jerris 3c95a52ff6 we are intentionally using a value outside of the enum here as a special value. The compiler will always make this an int anyways, so this is safe. cast to remove the warning 2014-03-15 22:47:55 -04:00
Michael Jerris 658e7623a2 silence clang warning about always false, this is meant to keep naughty users for the api from causing a crash, the check is fine 2014-03-15 22:42:05 -04:00
Michael Jerris aea7800a42 fix var type warnings in mod_lcr 2014-03-15 22:23:46 -04:00
Michael Jerris 4ee5d1f617 FS-6293: srcdir builds, pass along CFLAGS to spandsp lib build as well, not just override them 2014-03-15 22:14:11 -04:00
Jeff Lenk 586b189166 FS-6355 fix for windows delete file 2014-03-15 18:01:03 -05:00
Michael Jerris 048ce8d1f3 FS-6293: srcdir builds, most of the built in mods work now 2014-03-14 23:13:34 -04:00
Michael Jerris e911986a72 FS-6293: more srcdir build fixes, fix mod_enum srcdir build 2014-03-14 20:02:22 -04:00
Anthony Minessale 8f703c7a78 FS-6353 regression from 7ba257ecd6 2014-03-14 18:34:08 -04:00
Chris Rienzo ff555aa519 mod_rayo: some bugfixes to pause-when-offline 2014-03-14 17:23:56 -04:00
Anthony Minessale 25db7bd7c2 fix perl build and install 2014-03-14 16:31:34 -04:00
Jeff Lenk 0ea3b1f89b vs2010 reswig 2014-03-14 15:18:54 -05:00
Chris Rienzo 9e45174dfe mod_rayo: add new config pause-when-offline - will pause inbound calling if there are no online clients to handle calls. This is useful if you want FS to respond 503 to options ping when there are no online rayo clients. Default behavior is to disable this param. 2014-03-14 15:50:42 -04:00
Chris Rienzo 6f6c57ce03 mod_rayo: fix regression in ACL 2014-03-14 14:33:38 -04:00
Chris Rienzo 9946f9d5c3 mod_rayo: add remote IP and port to xmpp stream logging 2014-03-14 14:25:21 -04:00
Anthony Minessale 89f9490710 FS-6350 --resolve Parse params out of user portion of caller_id and save them to sip_name_params 2014-03-14 13:13:22 -05:00
Anthony Minessale e37616e36d do not retry so fast on failed outbound subs 2014-03-14 12:55:50 -05:00
Eliot Gable 5b1ab59f00 Add error handling to sql queue manager callback functionality and fix spelling. 2014-03-14 15:54:05 +00:00
Brian West f087248cfc FS-6355 - Patch to have .fsxml file be generated atomic to avoid partial reads when using this file to compare to previous versions/etc. 2014-03-13 17:27:36 -05:00
Anthony Minessale 430b8fca6b FS-6211 more changes 2014-03-13 13:00:10 -05:00
Anthony Minessale 729976df27 FS-6211 revert 015ff5d787 and f6e591de4a in favor of doing it in apr 2014-03-13 12:53:43 -05:00
Brian West 7a6e8f4672 FS-6354 --resolve, add realm to sofia::expires event 2014-03-13 11:13:10 -05:00
Anthony Minessale 7ba257ecd6 FS-6353 --resolve 2014-03-13 10:23:13 -05:00
Michael Jerris df8fbb60e8 FS-6352: --resolve don't override install target when using automake, make your own install target that will get depended upon instead 2014-03-13 09:13:56 -04:00
Jeff Lenk de8d92d9ce FS-6346 part 1 2014-03-12 23:49:14 -05:00
Chris Rienzo 055d389bed FS-6345 --resolve mod_unimrcp: don't start input timers if start of speech was detected 2014-03-12 23:14:44 -04:00
Chris Rienzo 0f93cc2b49 FS-6281 mod_rayo: don't add timestamp to presence event that already has one. 2014-03-12 21:53:37 -04:00
Michael Jerris 5e0fc8f666 remove usage of apr dso functions, we have our own dso abstraction 2014-03-12 19:02:49 -04:00
Brian West 4b935e1037 fix automake warnings for var redefined 2014-03-12 15:22:56 -05:00
Brian West 666231f91b BNPH-6149: allow to use system curl again, fix some types on auth_scheme values to all be long, don't use curl private function in our wrapper. This may cause missing symbol curl_easy_setopt with visibility turned on, if it does that, please let me know 2014-03-12 13:47:24 -05:00
Giovanni Maruzzelli 40c56c621a FS-5078 gsmopen: adding ussd capabilities, thanks Boris 2014-03-12 17:51:58 +01:00
Anthony Minessale efef505e26 add switch_sql_queue_manager_pause and switch_sql_queue_manager_resume 2014-03-12 11:42:37 -05:00
Anthony Minessale bcec5e22a2 FS-6342 --resolve regression from 804ef7709d Missed part of properly implementing the case-insensitive mode on the hash causing the dp lookup xml not to match XML 2014-03-12 04:50:42 +05:00
Anthony Minessale 98c2a3b992 don't nuke tcp and tls reg on restart 2014-03-11 16:25:51 -05:00
Anthony Minessale 70f2908976 more nat fix 2014-03-11 16:12:43 -05:00
Anthony Minessale 5c8a3b12fd Convert some behaviors to optional.
These all were set before but now are disabled by default because they are not proper to have enabled without a good reason.

tcp-unreg-on-socket-close

If registration is TCP or TLS and socket connection is interrupted, unregister the client.

tcp-always-nat

Treat all TCP connections as NATTED, this causes all traffic back to the phone to reuse the existing TCP socket but may
cause problems when not used with TCP keepalive.

tls-always-nat

Same as tcp-always-nat but only for TLS connections.
2014-03-11 15:17:02 -05:00
Anthony Minessale 0fa6cc6f01 FS-6340 --resolve 2014-03-11 11:38:31 -05:00
Chris Rienzo f9337a6a70 FS-6281 --resolve mod_rayo timestamp presence events 2014-03-10 20:10:18 -04:00
Chris Rienzo 0c0a4867aa mod_rayo: improve error messages when joining to b-leg that is missing 2014-03-10 17:15:58 -04:00
Chris Rienzo 325fba0fe7 Merge branch 'master' of ssh://git.freeswitch.org:222/freeswitch 2014-03-10 16:21:04 -04:00
Simon Wunderlich 9f804d2d95 mod_skinny: remove unknown field from access_status
Cisco 7925g send access status message with just 8 byte of payload data.
Since we don't interpret the unknown 3rd field anyway, remove it. This
will prevent the first register to fail.

Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Nathan Neulinger <nneul@neulinger.org>
2014-03-10 15:17:50 -05:00
Simon Wunderlich 305543814d mod_skinny: wait up to 5 seconds for OpenRecvChannelAck
WiFi phones like the 7925g may take longer than just one second to
acknowledge the open receive message. Increase the timeout to 5 seconds.

Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Nathan Neulinger <nneul@neulinger.org>
2014-03-10 15:17:44 -05:00
Simon Wunderlich 1727213bb8 mod_skinny: make 7925g work
Cisco 7925G seem to work only with the correct conference_id2 and
rtptimeout set, so add protocol 11 definition fields and set
conference_id2 correctly.

Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Nathan Neulinger <nneul@neulinger.org>
2014-03-10 15:17:31 -05:00
Chris Rienzo 5fbe6bd182 Merge branch 'master' of ssh://git.freeswitch.org:222/freeswitch 2014-03-10 15:54:09 -04:00
Chris Rienzo db22d28e21 FS-6334 --resolve mod_rayo: deadlock when creating input voice component 2014-03-10 15:53:26 -04:00
Anthony Minessale 087b2e4f30 revert part of 390e6713cc 2014-03-10 14:42:52 -05:00
Anthony Minessale bc70900335 PLIV-5 --resolve httpapi cache not working for some urls 2014-03-10 12:20:16 -05:00
Michael Jerris 6a5005d419 try to fix the make -j in the debs build with forcing the dep target 2014-03-10 13:05:40 -04:00
Michael Jerris 48d668cd0a FS-6331: --resolve fix install of mod_celt 2014-03-10 10:15:41 -04:00
Michael Jerris 35020541cc fix mod_shout build 2014-03-10 09:57:09 -04:00
Tamas Cseke 5b2dc5b90a lot of event can cause api timeout FS-3347
make event and log bulk configurable
2014-03-10 11:44:56 +01:00
Michael Jerris beae3aedc3 fix file refrences that subdir-objects doesn't like 2014-03-09 16:06:02 -04:00
Michael Jerris ce78c1434c fix mod_dingaling build 2014-03-09 16:01:11 -04:00
Michael Jerris 87af4d3278 fix mod_enum install 2014-03-09 14:44:41 -04:00
Chris Rienzo 598ff02b2b mod_unimrcp - switch_core_hash_init_nocase was changed 2014-03-09 11:34:47 -04:00
Chris Rienzo cf04dd3e75 FS-6326 --resolve switch_core_hash_init_nocase changed and mod_http_cache wasn't updated 2014-03-09 11:31:00 -04:00
Jeff Lenk f649af84e8 fix windows build for last commit 2014-03-08 14:23:41 -06:00
Anthony Minessale 804ef7709d change from sqlite hash to newly added one 2014-03-09 00:37:17 +05:00
Anthony Minessale 32cce8027e Add hashtable code from openzap/freetdm to FS core 2014-03-09 00:37:17 +05:00
Travis Cross 010740d664 Correct sizeof argument in mod_conference
This corrects a memset introduced in commit
bd4a0d8cbc.

The sizeof would have only returned the size of a pointer.
2014-03-08 01:56:18 +00:00
Michael Jerris e7c521b515 more subdir references 2014-03-07 20:50:28 -05:00
Michael Jerris 17d3b88a65 fix on newer automake 2014-03-07 20:31:20 -05:00
Travis Cross e6ec9b3c61 Add automake subdir-options for modules
The automake project is apparently changing behavior in their next
major version and warning everyone who relies on subdir-options to add
it explicitly.
2014-03-08 00:32:02 +00:00
Michael Jerris bcd9f49fbe move applications to use automake 2014-03-07 18:36:12 -05:00
Brian West 07272e864e FS-6321 --resolve
Copy URI params from Refer-To header into custom header in subsequent INVITE

sip_h_X-FS-Refer-Params is set to show up in the INVITE as X-FS-Refer-Params
2014-03-07 12:56:58 -06:00
Anthony Minessale f87ae15fc6 don't refuse invites on established sessions due to session limits 2014-03-07 23:46:26 +05:00
Anthony Minessale 8d2c6b354e According to https://code.google.com/p/webrtc/issues/detail?id=2768 ; The Chrome WebRTC engine reserves payload 98 and 99, IKR? So, to avoid taking a nasty spill down the stairs and subjecting ourselves to further school absences, we'll just start our payload space at 102 when making WebRTC calls....... 2014-03-07 20:24:16 +05:00
Chris Rienzo f9f36993e8 FS-6282 mod_rayo: fix memory leak in previous commit 2014-03-06 23:32:56 -05:00
Chris Rienzo 5138aede9b FS-6282 mod_rayo: allow outbound call JID to be assigned by client 2014-03-06 23:14:28 -05:00
Anthony Minessale b8e4a66dd2 another crypto regression 2014-03-07 08:34:39 +05:00
Anthony Minessale 0da8c6331d don't kick in nat mode on polycom tcp unless its not in the local network 2014-03-07 08:34:26 +05:00
Anthony Minessale 5aa955b5c9 also means forbidden on recovering calls 2014-03-07 07:11:32 +05:00
Anthony Minessale 87e0dda3d3 no var set on outbound meands forbidden and on inbound it means optional 2014-03-06 20:05:02 -06:00
Anthony Minessale fcef3ad4b1 FS-6319 --resolve 2014-03-06 19:37:11 -06:00
Anthony Minessale 46c5268e09 FS-6319 2014-03-07 06:35:02 +05:00
Anthony Minessale 5375d8b643 add on to last commit 2014-03-07 06:34:32 +05:00
Anthony Minessale bd4a0d8cbc add a way to tell mod_conference when the rate of the channel has changed due to a codec change so it can reset the resampler and codecs internally 2014-03-07 05:17:47 +05:00
Anthony Minessale a491df05f1 declinatio mortuus obfirmo! 2014-03-07 03:35:36 +05:00
Anthony Minessale 390e6713cc part of last patch 2014-03-07 02:59:09 +05:00
Anthony Minessale e9847afe22 feed all packets to jitterbuffer when enabled to absorb bursts and improve smoothing and delay protection 2014-03-07 02:48:56 +05:00
Brian West f7be96396b add missing flags after refactor 2014-03-06 10:49:43 -06:00
Travis Cross 7cde2adcb7 Fix minor edge case in switch_split_user_domain
If the input started with 'sip:sips:' it would have been incorrectly
parsed.
2014-03-06 06:03:27 +00:00
Anthony Minessale 656cb2ac03 add optional rtp_secure_media_suites variable clobbered by rtp_secure_media with mandatory|optional:<suites> 2014-03-06 08:17:22 +05:00
Anthony Minessale 1d733235a5 remove unused stuff from last commit 2014-03-06 07:41:39 +05:00
Anthony Minessale e5b291514c FS-5755
rtp_secure_media=mandatory
rtp_secure_media=optional
rtp_secure_media=mandatory:AES_CM_256_HMAC_SHA1_80,AES_CM_256_HMAC_SHA1_32
rtp_secure_media=optional:AES_CM_256_HMAC_SHA1_80
rtp_secure_media=forbidden

true implies mandatory
false implies forbidden
not set implies optional

rtp_secure_media_inbound or rtp_secure_media_outbound take precedence and are treated the same way based on leg direction
2014-03-06 07:34:47 +05:00
Anthony Minessale d3121d930e switch_false currently returns false on NULL 2014-03-05 17:36:35 -06:00
Anthony Minessale 7cb91467e0 FS-5814 --resolve 2014-03-06 00:02:40 +05:00
Travis Cross 74775d4397 Revert conference "tool" misfeature
This was added as part of a mass copyright header update in commit
6e7d5d089.  That's obviously not the right way to add features, so
we're reverting this.

If this feature is actually desired, it should be added in its own
commit, properly described in the commit message, and documented.

(The commit added a "tool" flag that could be applied to a conference
participant to mess with that person by disrupting his or her audio.)

This partially reverts commit 6e7d5d0897.

This feature earlier tried to sneak in under the guise of a whitespace
cleanup in commit a000749e70 which
Anthony reverted at commit a24f9aa8bc.

Let's not play these games.
2014-03-05 03:29:10 +00:00
Chris Rienzo 286d2aef29 FS-6304 mod_rayo- fix race condition on outbound calls 2014-03-04 22:12:43 -05:00
Giovanni Maruzzelli 4d8866a7cf gsmopen: added driver_usb_dongle directory, for building a working and stable 'option' modem serial driver for 2.6.32 kernels (eg: Proxmox, OpenVZ) 2014-03-05 02:06:03 +01:00
Anthony Minessale 6ae038add3 FS-5755 84c0680153 is wrong. It made optional enforce crypto. 2014-03-04 19:07:54 -06:00
William King fd38a255f8 FS-6167 --resolve 2014-03-04 13:41:34 -08:00
William King 3d461d7cde FS-1327 --resolve 2014-03-04 13:09:51 -08:00
Marc Olivier Chouinard 84c0680153 FS-5755 Fix regression if rtp_secure_media=false, it will force encryption. 2014-03-04 09:42:17 -05:00
Travis Cross 411a76020a Improve channel variable name to srtp_allow_idle_gaps
This was momentarily called force_send_silence_when_idle, but that was
non-obvious as you had to set that value to true to be able to not
send silence when idle.  This name describes the purpose much better.
2014-03-04 01:51:04 +00:00
Travis Cross 680bc46768 Avoid repeating ourselves in generating silence
We were handling the "send silence but not comfort noise" case in both
silence_stream_file_read and switch_generate_sln_silence.  This
changes the former to rely on the latter.
2014-03-04 00:16:43 +00:00
Travis Cross 5a7ea956b9 Add force_send_silence_when_idle channel variable
If set to true, this prevents us from overriding the value of
send_silence_when_idle.  When that is unset or set to zero and SRTP is
engaged, we typically override the value because many devices can't
handle gaps in the SRTP stream.

This variable is mostly for testing whether particular devices can
handle this behavior.  Use at your own risk.
2014-03-04 00:09:02 +00:00
Chris Rienzo e650939b25 FS-6296 --resolve mod_rayo: fixed crash on <prompt> bad request 2014-03-03 19:01:28 -05:00
Travis Cross 20da552564 Preserve value of send_silence_when_idle if possible
In commit 55d01d3def we set
send_silence_when_idle to -1 rather than 400 when SRTP is engaged.
But this left no way to enable white noise silence when desired.

When SRTP is engaged we can't simply not send RTP because it breaks
too many devices.  So we need to prevent send_silence_when_idle from
being unset or being set to zero.  This change allows it to be set to
other values so as to feed white noise rather than all zeros into the
codec.
2014-03-03 23:43:29 +00:00
Travis Cross 11ca1a2b2e Fix handling of send_silence_when_idle==0 in switch_ivr_sleep
When the channel variable send_silence_when_idle was set to zero,
switch_ivr_sleep was calling SWITCH_IVR_VERIFY_SILENCE_DIVISOR on it
anyway, causing it to be set to 400.  The only way to get the behavior
of not sending silence when idle was to unset the variable completely.

This corrects the behavior such that setting the value to zero has the
same effect as leaving it unset.
2014-03-03 23:21:58 +00:00
Anthony Minessale 6ef3f7bde7 add timeout <seconds> to mod_curl api call 2014-03-03 22:58:45 +05:00
Michael Jerris 07399e213f fix missing type definitions 2014-03-03 08:26:54 -05:00
Michael Jerris ae216daf02 fix warning abount comment inside comment 2014-03-03 08:26:54 -05:00
Travis Cross ecd6dfc612 Output newline after json output in mod_json_cdr
In UNIX, text files by definition end with a newline.
2014-03-03 01:13:39 +00:00
Travis Cross 95e4163ab7 Handle too-short write(3)s in mod_json_cdr
write(3) can write fewer bytes than was requested for any number of
reasons.  The correct behavior is to retry unless there is an error.

If there is an error, try to unlink the file; no sense in leaving
corrupted data laying around.
2014-03-03 01:12:15 +00:00
Travis Cross 75a00bd954 Fix memory leak in mod_json_cdr 2014-03-02 22:02:07 +00:00
Travis Cross 164d6a7bf5 Optimize switch_split_user_domain a bit
This avoids searching the string repeatedly with strchr.
2014-03-02 09:43:14 +00:00
Travis Cross 5aab272bb3 Refactor and fix edge cases in switch_split_user_domain
We were incorrectly parsing usernames and domains starting with "sip"
if there was no sip: or sips: scheme in the string.

We were also incorrectly parsing usernames containing a colon even if
a scheme was given.

This also refactors the function for hopefully greater clarity.
2014-03-02 09:20:59 +00:00
Raymond Chandler b0d7551c80 use newSQL 2014-03-02 03:13:01 -05:00
Travis Cross b22aa39e66 Fix switch_split_user_domain handling of sips: URLs
In commit 7efeabbd88 Anthony fixed the
handling of sip:example.com and sips:example.com URLs, however he
introduced a regression causing URLs starting with 's' to be parsed
incorrectly.

In commit 7d2456ea27 Brian fixed the
regression, but introduced a regression causing sips:example.com URLs
to be handled incorrectly.
2014-03-02 08:11:11 +00:00
Jeff Lenk 015ff5d787 windows fix last commit 2014-03-01 15:40:58 -06:00