Commit Graph

7346 Commits

Author SHA1 Message Date
Steve Underwood 8d818c3be7 Fixes for DTC handling in the T.38 gateway 2014-07-28 23:35:06 +08:00
Moises Silva d65716d83a freetdm: Added dtmf_time_on and dtmf_time_off parameters to tweak DTMF duration in milliseconds 2014-07-27 13:29:58 -04:00
Brian West 327146cecf Fix WS Compile on MSVC2012 2014-07-25 11:34:08 -05:00
Moises Silva b80cdd45d5 freetdm: Added release guard time configuration
Currently only enabled in the analog e&m module but any
signaling module can easily take advantage of it with a small
modification to the signaling module to set span->sig_release_guard_time_ms
2014-07-23 00:41:08 -04:00
Moises Silva 09198ee357 freetdm: Raise some buffer limits 2014-07-22 23:44:17 -04:00
Moises Silva 61101e325f freetdm: ftmod_analog_em: Added support for suspending channels that are offhook 2014-07-22 23:30:53 -04:00
Moises Silva a65ba24298 mod_freetdm: Added 'ftdm cas' command to read/write raw CAS bits 2014-07-22 23:30:45 -04:00
Brian West e4bd2c3cd9 bump 2014-07-22 07:26:04 -05:00
Brian West 407fb1a7dd NOT OpenBSD 2014-07-22 07:25:43 -05:00
Steve Underwood 0c32ae8ca0 Coverity cleanups for iLBC 2014-07-22 12:06:50 +08:00
Steve Underwood 720e7a23c4 Tweas to PLC 2014-07-22 11:40:34 +08:00
Steve Underwood 47e5887288 Tweaks to the V.17 modem 2014-07-22 11:25:22 +08:00
Steve Underwood e5cad4d7d4 More Coverity related cleanups 2014-07-22 11:07:22 +08:00
Steve Underwood 3b8bc35bd9 More fixes for Coverity issues 2014-07-22 10:51:42 +08:00
Steve Underwood fb6ecb4c76 Fixed some issues raised by coverity in spandsp ilbc and unimrcp 2014-07-22 09:38:55 +08:00
Peter Olsson 17d6c5b850 FS-6578 #comment fixed #resolve 2014-07-19 18:06:01 +02:00
Peter Olsson 62404c6e2b Windows: Remove auto generation of files that already exist in git. 2014-07-19 13:41:33 +02:00
Peter Olsson 1f6eb25081 .gitignore portadio 2014-07-19 12:47:45 +02:00
Peter Olsson 730cd201c4 Remove js and mod_spidermonkey from Windows build 2014-07-19 12:47:44 +02:00
Peter Olsson 58a33988a3 spandsp: Add missing include for alloc.h. This fixes a build error on Windows. 2014-07-19 12:47:42 +02:00
Michael Jerris 6706378b38 we have already removed the module from tree, no need to bootstrap/configure the lib still, or to have it in tree at all for that matter 2014-07-18 14:15:26 -04:00
Steve Underwood 6a3bf7c4a7 Further improvements to FAX CTC message handling 2014-07-18 16:08:59 +08:00
Jeff Lenk 3cababdf33 FS-6542 part 2 windows 2014-07-17 23:51:59 -05:00
Steve Underwood 458ffc4714 Merge branch 'master' of ssh://stash.freeswitch.org:7999/fs/freeswitch 2014-07-18 10:33:42 +08:00
Steve Underwood 33a4adba62 Better handling of bad HDLC frames in T.38 gateway operation. 2014-07-18 10:29:23 +08:00
Travis Cross a0e19e1c7f Use system portaudio library
This removes our in-tree version of portaudio-19 and migrates
mod_portaudio and mod_portaudio_stream to use the system version of
the library.  Our detection of the system library relies on
pkg-config.
2014-07-17 21:15:53 +00:00
Steve Underwood 52435978d0 Step FAX modem type on sending CTC. 2014-07-17 22:32:17 +08:00
Jeff Lenk 419a2a617d FS-6542 oart 1 this will break vs2012 temporarily unless you manually delete libs\portaudio 2014-07-17 00:34:42 -05:00
Anthony Minessale 6c80281ce9 buffer websocket headers and body before sending to avoid fragmentation 2014-07-17 01:07:57 +05:00
Steve Underwood 6f439d3741 Tweaks, and a fix for FAX polling. 2014-07-16 23:26:20 +08:00
Moises Silva ae9e740d7f freetdm: ftdm_gsm: Remove some old debug code 2014-07-13 03:06:28 -04:00
Moises Silva 4bc1b731cb freetdm: ftdmod_gsm: Allow hwdtmf parameter to accept detect or generate
You can now enable the hardware dtmf detection and/or generation
2014-07-13 02:46:28 -04:00
Moises Silva ff935bb1d9 Revert "freetdm: ftmod_wanpipe: Do not attempt to initialize hwdtmf in GSM ports during shutdown"
This reverts commit b29a41bb1b.

This commit is no longer needed now that proper infrastructure has been
added to allow signaling modules to generate and detect DTMF

The feature macros should only be used for I/O module features
and not for signaling module features
2014-07-13 02:21:06 -04:00
Moises Silva 64489c54ee freetdm: Added support for DTMF generation to be performed in the signaling modules (currently only used by the gsm signaling driver) 2014-07-13 02:16:58 -04:00
Moises Silva e742522597 mod_freetdm: Fix several leaks on module shutdown 2014-07-13 00:35:48 -04:00
Moises Silva b29a41bb1b freetdm: ftmod_wanpipe: Do not attempt to initialize hwdtmf in GSM ports during shutdown 2014-07-13 00:35:48 -04:00
Anthony Minessale b53ba668fa rebuild 2014-07-12 04:39:56 +05:00
Anthony Minessale cc75547672 merge ws.c change to sofia 2014-07-12 04:39:41 +05:00
Moises Silva 0b6f10a6a8 freetdm: ftmod_gsm: Added support for hardware DTMF 2014-07-11 00:52:32 -04:00
Steve Underwood 54b6a0abce Added explanatory comment on a recent change. 2014-07-09 10:18:00 +08:00
Steve Underwood 992debeea4 Merge branch 'master' of ssh://stash.freeswitch.org:7999/fs/freeswitch 2014-07-09 00:14:31 +08:00
Michael Jerris a99f06dfc6 sync changes from srtp upstream 2014-07-08 10:26:08 -04:00
Steve Underwood 40214821cb Added additional checks that HDLC frames arriving at the T.38 gateway engine
begin with the correct 2 bytes.
2014-07-08 20:48:15 +08:00
Chris Rienzo 9b14633cf3 fs_cli: fix compiler error on CentOS 6 caused by recent short uuid logging change 2014-06-30 17:30:59 -04:00
jfigus 024162cfc9 Add support for 16-byte auth tag for AES GCM mode. 2014-06-30 19:18:20 +00:00
jfigus b9da5149e2 Set the algorithm member on cipher_t when allocating AES crypto instance. Apply same fix to NULL cipher. 2014-06-30 19:18:20 +00:00
Travis Cross aa4261d11f Avoid buffer-overflow on short RTCP/SRTCP packets
In `srtp_unprotect_rtcp()` we are not validating that the packet
length is as long as the minimum required.  This would cause
`enc_octet_len` to underflow, which would cause us to try to decrypt
data past the end of the packet in memory -- a buffer over-read and
buffer overflow.

In `srtp_protect_rtcp()`, we were similarly not validating the packet
length.  Here we were also polluting the address of the SRTCP
encrypted flag and index (the `trailer`), causing us to write one word
to a bogus memory address before getting to the encryption where we
would also overflow.

In this commit we add checks to appropriately validate the RTCP/SRTCP
packet lengths.

`srtp_unprotect_rtcp_aead()` (but not protect) did correctly validate
the packet length; this check would now be redundant as the check in
`srtcp_unprotect_rtcp()` will also run first, so it has been removed.
2014-06-30 19:00:35 +00:00
Travis Cross 9ea93c4c50 Avoid buffer over-read on null cipher AEAD
In the defined AEAD modes, SRTP packets must always be encrypted and
authenticated, but SRTCP packets may be only authenticated.  It's
possible, therefore, for us to end up in `srtp_protect_aead()` without
the `sec_serv_conf` bit being set.  We should just ignore this and
encrypt the RTP packet anyway.

What we are doing instead is encrypting the packet anyway, but setting
`enc_start` to NULL first.  This causes `aad_len` to underflow which
will cause us to over-read in `cipher_set_aad()`.

If we could get past that, we would try to read and write memory
starting at 0x0 down in `cipher_encrypt()`.

This commit causes us to not check the `sec_serv_conf` bit and never
set `enc_start` to NULL in `srtp_protect_aead()`.

`srtp_unprotect_aead()` does not contain a similar error.
2014-06-30 19:00:35 +00:00
Travis Cross 3bf2b9af75 Prevent buffer overflow from untrusted RTP/SRTP lengths
When computing the start address of the RTP data to encrypt or SRTP
data to decrypt (`enc_start`), we are using `hdr->cc` (the CSRC
count), which is untrusted data from the packet, and the length field
of an RTP header extension, which is also untrusted and unchecked data
from the packet.

This value then pollutes our calculation of how much data we'll be
encrypting or decrypting (`enc_octet_len`), possibly causing us to
underflow.

We'll then call `cipher_encrypt()` or `cipher_decrypt()` with these
two values, causing us to read from and write to arbitrary addresses
in memory.

(In the AEAD functions, we'd also pollute `aad_len`, which would cause
us to read undefined memory in `cipher_set_aad`.)

This commit adds checks to verify that the `enc_start` we calculate is
sane based on the actual packet length.
2014-06-30 19:00:35 +00:00
Travis Cross d2aaf15992 Fix misspelling in comment 2014-06-30 19:00:34 +00:00
Steve Underwood c3798dbb02 FAX tweaks 2014-06-29 02:11:25 +08:00
Steve Underwood ad1e7e9632 Fixed updating of the modem type after a FAX ECM CTC. 2014-06-28 16:43:05 +08:00
Steve Underwood 557f1d05ac Fixed issue handling modem renegotiation when a T.30 CTC message is received.
Please enter the commit message for your changes. Lines starting
2014-06-23 08:51:41 +08:00
Steve Underwood b15f373cd9 Tweaks 2014-06-20 02:58:33 +08:00
Steve Underwood b780371943 Improved TSB85 tests, which now check call clearing.
FAX now differentiates properly between <page result code> and <image> <page resuly code> when deciding how to retry.
2014-06-20 00:24:10 +08:00
Brian West d2a487dce3 date would have done the same thing 2014-06-18 08:58:49 -05:00
Brian West fb92ebc8f2 FS-5223 and FS-6603, don't trust docs... sheesh 2014-06-18 08:33:57 -05:00
Brian West 311889634b FS-5223 FS-6603 on platforms that have SO_REUSEPORT it also implies SO_REUSEADDR, On platforms that only have SO_REUSEADDR it seems to imply both in the absence of SO_REUSEPORT. 2014-06-17 21:15:02 -05:00
Michael Jerris 0a6a10f584 FS-6604: fix this same issue in esl too 2014-06-17 12:10:47 -05:00
Peter Olsson e7ee4050b2 Add ldns to .gitignore 2014-06-15 13:51:56 +02:00
Steve Underwood fc7a74905b Various little memory leak possibilities in spandsp sorts, and the spandsp
test suite is now mostly OK with valgrind.
2014-06-14 19:49:05 +08:00
Steve Underwood 94ab52cd01 Improved FAX disconnect handling 2014-06-11 10:52:54 +08:00
Steve Underwood 10647be5a0 Fixed incorrect T.30 CTC messages. Fixed reseting of the CRC generator
in the HDLC tx code
2014-06-11 01:49:29 +08:00
Anthony Minessale 0685027bd8 FS-6574 --resolve 2014-06-09 14:29:08 -04:00
Jeff Lenk a607c20a94 windows fix for a0e9ddf589 2014-06-08 16:06:32 -05:00
Anthony Minessale 36e72b86ca force spandsp rebuild 2014-06-05 22:07:08 +05:00
Travis Cross 31186d815b Improve a parameter name for fs_cli
What we momentarily called log-uuid-chars is now better called
log-uuid-length.  Setting log-uuid-length will specify a truncation
length for UUIDs displayed by setting log-uuid.
2014-06-04 16:07:10 +00:00
Steve Underwood 3549488e8e Fixed a problem in FAX where a received handshake, delayed so much it is
received as we queue a retry, causes the retry frame to remain queued in the
HDLC entity.
2014-06-04 23:54:03 +08:00
Travis Cross c015013e5f Add log-uuid-short option to fs_cli
If log-uuid-short is set, or -S is passed to fs_cli, we only display
the first 8 hex digits of the UUID.  The log-uuid-chars option may
instead be set to specify some other truncation length for the UUID.
2014-06-04 12:01:01 +00:00
Travis Cross a0e9ddf589 Convert esl_true and esl_false to functions
Prior to this commit, an expression such as:

  esl_true("true") ? 42 : 0

...would return 1 rather than 42.
2014-06-04 12:00:31 +00:00
William King 7ce2009fad Fix compiler warning about possibly uninitialized variable in libs/esl 2014-06-02 08:33:05 -07:00
Michael Jerris e992c4c4d8 CID:1216560 Unchecked return value from ioctl 2014-06-02 14:11:07 +00:00
Anthony Minessale dc671d9d82 fix name of fs_ivrd 2014-05-22 16:41:21 -04:00
Michael Jerris b5a223cd1b CID:1215201 Explicit null dereferenced 2014-05-22 15:39:59 +00:00
Travis Cross d0ce18885c Cleanup bad whitespace
Introduced in commit e6ac87f5f1.
2014-05-21 17:25:32 +00:00
Jeff Lenk e6ac87f5f1 fixes for VS2010 code analysis - hope these are OK else-ware 2014-05-20 22:54:32 -05:00
Jeff Lenk c7f2a19149 FS-6505 download custom ldns lib for windows for now 2014-05-20 17:07:52 -05:00
Anthony Minessale f0aa0fc1d8 seek chain cert from wss.pem just cat together the cert, the key and the chain cert into wss.pem 2014-05-20 23:18:38 +05:00
Michael Jerris 77bddb9f9c FS-6538: silence gcc 4.9 throwing incorrect warning 2014-05-20 15:46:46 +00:00
Anthony Minessale af6c4b00b7 force sofia rebuild 2014-05-20 20:29:17 +05:00
Michael Jerris f683ac2165 FS-6533: --resolve fix gcc 4.9 warning due to useless right-hand operand of comma expression 2014-05-19 10:36:02 -05:00
Michael Jerris 6b9024246f CID:1214189 Division or modulo by float zero 2014-05-16 14:54:54 +00:00
Moises Silva 2b93912ef2 freetdm: Fix raw GSM AT command execution not returning the proper token count 2014-05-11 03:22:27 -04:00
Moises Silva a82e7a7dd1 freetdm: Added gsm debug configuration parameter 2014-05-11 02:55:07 -04:00
Moises Silva b8a32ed0f3 freetdm: Fixes for GSM module 2014-05-10 02:57:17 -04:00
Michael Jerris a933882e7e its logically impossible for this to be null, we are looping through an array on the stack 2014-05-07 12:54:40 -04:00
Michael Jerris 84886942d2 don't leak body in recv error case 2014-05-07 12:50:53 -04:00
Michael Jerris 7011602550 no need to check if p is null, it can never be null 2014-05-07 12:37:36 -04:00
Steve Underwood 44252a5d69 Various small cleanups in spandsp 2014-05-07 13:11:53 +08:00
Anthony Minessale 88ce7dae1c minor tweak to make ws code work in blocking mode properly when used outside sofia 2014-05-07 06:13:27 +05:00
Steve Underwood 137fb49dc1 Initialise custom TIFF directory offsets, as some versions of libtiff seem
to only set the low 32 bits of the 64 bit offset if the file only contains
a 32 bit offset.
2014-05-07 03:07:07 +08:00
Steve Underwood 9464549eb6 Corrected data type for TIFF directory offsets 2014-05-07 02:28:27 +08:00
Michael Jerris d6fe10979d remove opezap from tree, it has been replaced by freetdm 2014-05-06 11:05:54 -04:00
Steve Underwood 68a3250a69 Missing data modems files. They are a work in progress at this time, so don't
expect any functionality.
2014-05-06 21:21:33 +08:00
Steve Underwood 29ea8e9979 Fixed some ARM embedded assembly language typos 2014-05-05 08:33:55 +08:00
Steve Underwood 33da3e5bb8 Some tweaks to spandsp project files 2014-05-04 18:14:36 +08:00
Steve Underwood 38abcf7e2c The APIs for spandsp FAX have changes, removing one of the parameters passed in
the callbacks.
2014-05-04 17:22:28 +08:00
Brian West 367f4f399b FS-6500: use correct type in ftdm callback 2014-05-02 11:19:52 -05:00
Brian West ca88a0451d FS-6500: handle conversion from switch to ftdm cause type which almost match each other 2014-05-02 11:19:52 -05:00
Brian West cbcf54b65d FS-6500: fix return value type for outgoing_channel function 2014-05-02 11:19:52 -05:00
Steve Underwood 28a9a40e37 Various little cleanups, many of them from a clang static analysis 2014-05-02 23:32:33 +08:00
Natanael Copa 317f4b1442 Fix building with musl libc
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)

limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Michael Jerris 13b411529f FS-6500: freebsd does not support the inline backtrace solution 2014-05-02 11:14:39 -04:00
Travis Cross ba84e1d8f9 Remove dead assignment in libscgi 2014-05-02 03:58:48 +00:00
Travis Cross 2b1ae831d1 Remove some dead assignments in ESL 2014-05-02 03:57:07 +00:00
Moises Silva 64c678f17a freetdm: ftdm_gsm: Fix a few compilation warnings 2014-05-01 20:28:23 -04:00
Moises Silva 99c022b1dd FS-6500: freetdm: Add more enum compliance by defining proper enum values for FTDM_END and FTDM_ANY special state values 2014-05-01 20:24:03 -04:00
Travis Cross cd650f6055 Use system ldns library
This library is used only by mod_enum and is available on most
platforms.  The version in our tree has many code quality problems
that are generating noise when doing static analysis.  Suffice it to
say we want rid of it as our responsibility.

FS-353
2014-05-01 22:01:59 +00:00
Michael Jerris d2c2f174e7 FS-6500: try to do the bounds checking properly using element of the enum 2014-05-01 14:32:23 -04:00
Michael Jerris 906467b360 fix log message on sending tport ping over ws to log error in failure cases 2014-05-01 14:20:27 -04:00
Michael Jerris cfd8d28bc8 silence clang unused function warnings and get rid of some unused functions 2014-05-01 09:03:19 -04:00
Michael Jerris fc25bbc23c remove unused function 2014-05-01 08:32:23 -04:00
Michael Jerris b55ba90def fix 2 potential use after free errors 2014-05-01 08:30:52 -04:00
Michael Jerris a1a397420e fix leaked body in error case 2014-04-30 16:10:08 -04:00
Steve Underwood b205313f4f More fixes from Coverity scans 2014-05-01 02:56:53 +08:00
Steve Underwood 32c0bfde6b A couple more Coverity issues fixed 2014-05-01 01:19:28 +08:00
Steve Underwood 0ebc79457e Another couple of Coverity related cleanups 2014-04-30 22:51:59 +08:00
Michael Jerris 8ad8ae8e86 remove generated file from tree 2014-04-30 10:34:08 -04:00
Steve Underwood b8bd000bdd More elimination of warnings with clang 2014-04-30 22:27:29 +08:00
Steve Underwood bfacd58fa7 Eliminate some clang warnings 2014-04-30 22:18:46 +08:00
Michael Jerris 6e23eab0cc do set compiler flag that compiler doesn't support 2014-04-30 08:33:09 -04:00
Steve Underwood 21a2e19470 Eliminated another Coverity issue 2014-04-30 14:41:06 +08:00
Steve Underwood ba6457bbe9 Some more coverity issues cleaned up 2014-04-30 13:10:59 +08:00
Steve Underwood dac846cc7e Cleared some simple Coverity issues 2014-04-30 12:42:46 +08:00
Anthony Minessale 2cdae46b19 FS-6476 regression where sock would sometimes drop while reading logical frames 2014-04-29 18:25:05 -04:00
Anthony Minessale 61e22e8b50 FS-6476 --resolve 2014-04-22 23:25:41 +05:00
Michael Jerris ba6b9c5a11 ESL-91: --resolve bigger buffer for args 2014-04-21 13:33:47 -04:00
Brian West 6e8729a159 OPENZAP-222 --resolve 2014-04-18 15:18:41 -05:00
Brian West bf093e9dc1 Dispatch will call you on register, and call you back if you hangup on next register 2014-04-17 20:35:57 -05:00
Brian West 8ce6198bf9 fix bug in dispatch 2014-04-17 20:19:39 -05:00
Anthony Minessale cbd20d8a05 update 2014-04-17 04:33:02 +05:00
Anthony Minessale bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
Peter Olsson 295964f0ec FS-6457 --resolve
Upgrade to OpenSSL 1.0.1g in Windows build (Visual Studio 2010 and 2012)
2014-04-13 10:01:17 +02:00
Peter Olsson c915139a00 Make sure to copy pcre.h to library path, when building Win32/Debug in VS2012. 2014-04-11 16:35:19 +02:00
Travis Cross f754057c2a Avoid crash on event without content-type
If we received an event without a content-type header we were
dereferencing a null pointer leading to a seg fault.

Reported-by: Ico <ico@voip-io.org>

ESL-90 --resolve
2014-04-09 01:20:07 +00:00
Travis Cross c6acddf928 Fix typo in comment 2014-04-08 23:17:12 +00:00
Anthony Minessale 53c77f8434 force srtp rebuild 2014-04-09 03:14:52 +05:00
Dmitry Sobinov 80e203442a - fixed read of memory out of 'seq' variable bounds
- fixed AEAD IV calculation for big-endian machines
2014-04-08 16:13:52 +00:00
jfigus a31491d5b6 This commit resolves issue #46. The GCM mode was using the wrong master SALT length. The master SALT should be 96 bits instead of 112 bits. Note, GCM mode uses the legacy CTR mode for the KDF. The legagacy CTR mode cipher implementations assume a 112 bit SALT. Changes to the cipher abstraction layer API are required to provide the ability to specify the SALT length. For now this commit modifies the SRTP layer to ensure the SALT is zero-appended before initializing the KDF. This commit also provides public definitions for the GCM cipher suite master key sizes to avoid confusion for application developers. 2014-04-08 15:25:39 +00:00
Brian West 7bc92a11af ESL-89: fix install path and single_command require 2014-04-07 15:26:13 -05:00
Michael Jerris d6fa81b4b7 ESL-89: --resolve add rubymod-install and add ability to use a ruby not in your path by setting RUBY env var 2014-04-07 15:27:30 -04:00
Travis Cross fb7fa3d66a Update gitignore 2014-04-05 07:57:05 +00:00
Anthony Minessale 01254eaa5c force sofia rebuild 2014-04-04 13:42:49 -05:00
Anthony Minessale 180282cd9a FS-6287 2014-04-04 13:42:13 -05:00
Anthony Minessale 7ea4acaece FS-6426 --resolve 2014-04-03 23:25:48 +05:00
Anthony Minessale 7151d6acea FS-6402 part 2 2014-04-02 03:21:37 +05:00
Anthony Minessale 5c0cff70b3 FS-6402 --resolve 2014-04-02 01:20:19 +05:00
Michael Jerris f50f04be51 FS-6356: --resolve fix assert when you set the time > 15 days in the future during operation while things are in queue to be processeed 2014-03-28 14:33:47 -04:00
Travis Cross 180d081be4 Use buffered printers in fs_cli
Now that all output should end in a newline, we don't need to play
tricks with getting certain escape codes out ahead of buffered output.

This updates what we tried to do in commit
991b83d23c.

This partially reverts commit
8056125077.
2014-03-28 00:01:33 +00:00
Travis Cross 11f4628cae Reenable the new EL_REFRESH mechanism 2014-03-27 23:09:06 +00:00
Travis Cross 59f80c9e4f Handle bodies not ending in newlines w/EL_REFRESH
The issue is that sofia siptrace output doesn't end each line with a
newline.  Instead it sends a separate newline afterward, which comes
in as a separate event body.  With the new EL_REFRESH code in effect
the line is being cleared after the siptrace output has been written
but before that next newline comes in.

With our own refresh code this doesn't happen because of slight
differences in where the stdio buffers get flushed compared to where
the output of clear_line() ends up.

This is a bit of a clumsy workaround.  But we'll fix it first, then
refactor.
2014-03-27 23:06:07 +00:00
Travis Cross 3bc51dfff9 Turn on the fancy fs_cli with a modern libedit
We turn ON the features with a newer libedit.

This fixes commit 4f54f912c3.
2014-03-27 17:35:35 +00:00
Travis Cross 4f54f912c3 Add back terminal detection for old libedits
Using the system libedit means that libedit will again make absolute
movements on certain kinds of terminals.  Older versions of libedit
without EL_PROMPT_ESC miscalculate the length of the prompt.
Combined, this results in the cursor ending up in the wrong place.

We knew this was a possibility when we moved to system libedit, and
we're OK with it.  We certainly lived without this fancy prompt
feature for a long time.

This change puts back in place detection of the terminal type when
EL_PROMPT_ESC isn't available.  On these older versions of libedit,
we'll only enable the fancy features when we know that libedit will
only make relative movements and not tickle the bug.

This partially reverts commit:
b9b77bd615
2014-03-27 17:19:55 +00:00
Travis Cross dc093d179e Drop use of libedit EL_REFRESH in fs_cli for now
Newer versions of libedit provide an EL_REFRESH mechanism for
redrawing the prompt.  We had previously written our own code to
handle this.  In theory handing this over to libedit should be better.

Unfortunately when using EL_REFRESH the output of sofia siptrace isn't
showing up.  We're working on that, but for now we're just force own
our redrawing code to be used instead.
2014-03-27 12:20:43 +00:00
Travis Cross f9d065cda3 Use system libyaml for mod_yaml
FS-353
2014-03-26 19:27:22 +00:00
Ico fa17059787 Fix memory leak when outbound socket is closed by server
ESL-88 --resolve

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-26 01:36:48 +00:00
Jeff Lenk 4dd0a5848f FS-6293 windows duh 2014-03-24 18:45:05 -05:00
Jeff Lenk 07438df263 FS-6293 fix windows build from version.h being added to xmlrpc 2014-03-24 18:09:07 -05:00
Brian West c7bd862e9a FS:353: correct #if check for libedit function capability 2014-03-24 16:18:03 -05:00
Seven Du f5b18c0fdd FS-5642 --resolve add back the ETIMEDOUT check, needed on Mac 2013-12-13 11:46:14 +08:00
Jeff Lenk 069941f1da fix spandsp for windows build 2013-12-09 16:37:56 -06:00
Steve Underwood ac2bf8a405 Fixed a file permission in the ESL library 2013-12-08 01:39:00 +08:00
Steve Underwood eb3e843692 Eliminate a warning from valgrind, that might potentially be reporting actual
trouble.
2013-12-07 01:57:59 +08:00
Steve Underwood d5a7495a72 This should fix the FAX crashes when negotiation falls back to slower modems 2013-12-05 21:49:59 +08:00
Steve Underwood 9edbbd9c61 Tweaks to FAX modem handling. These do NOT fix the occassional crashes people
see, but they are working towards a clean and complete fix.
2013-12-05 21:10:57 +08:00
Steve Underwood 7d6b0e48b7 Added an XML script to the FAX tests which will provoke the crashing
issue seen recently in spandsp's FAX engine. The next step is to fix
the actual crash.
2013-12-05 13:34:25 +08:00
Jeff Lenk bb53175526 FS-6010 --resolve 2013-11-29 22:16:49 -06:00
Anthony Minessale bbe1fe1a31 FS-6005 --resolve 2013-11-27 10:20:35 -06:00
Moises Silva c62db1a600 freetdm: ftmod_wanpipe: Remove chatty debug msg, not really useful anyways 2013-11-27 09:51:33 -05:00
Anthony Minessale ca8f121977 fix regression from recent refactor that causes infinite loop on unexpected disconnect 2013-11-22 04:53:34 +05:00
Anthony Minessale 634d936a02 kill socket in esl_disconnect to prevent blocking 2013-11-20 23:50:15 +05:00
Jeff Lenk fc5557b949 FS-5986 --resolve fix download reference to windows libcelt 2013-11-20 07:36:20 -06:00
Jeff Lenk 4ee3b70496 fix windows esl compile 2013-11-13 17:59:52 -06:00
Anthony Minessale 9d2400b7ab doh 2013-11-14 01:48:48 +05:00
Anthony Minessale c429de4139 fix build err 2013-11-14 01:38:00 +05:00
Anthony Minessale c469e7ada2 cleanup ESL a little 2013-11-14 00:43:25 +05:00
Anthony Minessale 931d3fb86a remove condition for mem leak 2013-11-12 12:33:32 -06:00
wavecb 681ea6c40b fix build on mac os 10.9 2013-11-12 13:54:20 +08:00
Moises Silva 8469e83835 freetdm: ftmod_analog_em: Remove constant CAS debug log 2013-11-08 19:12:44 -05:00
wavecb fca7a4732c add miss strlcat strlcpy check for libedit 2013-11-08 20:34:38 +08:00
Moises Silva 7542c5877c freetdm: E&M: Set the line offhook when suspended 2013-11-08 02:22:36 -05:00
Moises Silva 3b0e8d9e2d freetdm: ftmod_zt: Refactor event processing to store OOB events that arrive during read/write operations 2013-11-08 02:22:05 -05:00
Moises Silva 774784fbee mod_freetdm: Handle read errors gracefully when the device is dead already 2013-11-08 02:21:42 -05:00
Moises Silva 545d1e5079 freetdm: Fix hangup supervision on inbound calls for Analog E&M 2013-11-08 02:19:41 -05:00
Steve Underwood 54ae6ff6c1 Adjusted the test for -Wunused-but-set-variable in spandsp, so it gets the
answer right with clang.
2013-11-01 10:32:32 +08:00
Steve Underwood f532640c49 Fixed an embedded assembly language constraint issue 2013-11-01 02:44:11 +08:00
Anthony Minessale 460b8014b9 add channel to logline 2013-10-31 11:21:34 -05:00
Anthony Minessale c8be999c34 FS-5911 --resolve 2013-10-25 23:51:43 +05:00
Moises Silva 271eda310e freetdm: Added CAS hangup bit checking to the E&M signaling module 2013-10-24 19:05:35 -04:00
Moises Silva 2b3c98b069 ftmod_analog_em: Block/unblock signaling when a span is stopped/started 2013-10-24 19:05:12 -04:00
Moises Silva 9a45b983b3 Merge remote-tracking branch 'origin/master' into em_management 2013-10-24 16:29:45 -04:00
Jeff Lenk 88b2e96516 windows fix compiler errors 2013-10-22 23:23:48 -05:00
Anthony Minessale 20a55d3cc6 update 2013-10-22 16:27:15 -05:00
Anthony Minessale e2bdd78d55 FS-5896 --resolve 2013-10-22 20:33:13 +05:00
Anthony Minessale 3c2a5db225 add missing protos 2013-10-21 20:11:30 +05:00
Michael Jerris bfcd1e07ca compile failure due to no newline at end of file 2013-10-21 10:54:23 -04:00
Steve Underwood 2cdfb045d2 Update some of the MSVC files for spandsp 2013-10-20 20:55:23 +08:00
Steve Underwood eee96c60c9 Tweaks 2013-10-19 18:51:50 +08:00
Anthony Minessale 0d19abfbdb FS-5887 --resolve 2013-10-19 00:00:28 +05:00
Travis Cross 3fce1aae03 Fix build of apr-util expat with libtool2
Applied patch from:
http://people.apache.org/~rjung/patches/expat-libtool2.patch

The failure that results from this seems to occur
non-deterministically.

FS-3185 --resolve
2013-10-17 20:41:58 +00:00