Commit graph

4028 commits

Author SHA1 Message Date
Michael Jerris
56e4afb209 FS-6595: Enable pause_play and file_seek for conference member fnode #resolve 2014-09-04 15:56:15 -04:00
Travis Cross
7d11e19983 Check for null hash or private while holding lock
What if the hash were destroyed by one thread holding the lock while
another thread was waiting for the lock?  The waiting thread would
have already checked that the hash was non-null and would proceed on
that assumption after acquiring the lock.

With this commit we check only after acquiring the lock.

ref: FS-6783
ref: FS-6775
2014-09-03 19:45:45 +00:00
Travis Cross
82a28e76e4 Re-fix memory leak
After consideration, this still looks correct.

Thanks-to: Anthony Minessale <anthm@freeswitch.org>

ref: FS-6783
ref: FS-6775
2014-09-03 19:44:43 +00:00
Travis Cross
8c0a1d17e2 Reintroduce memory leak in mod_hash to avoid crash
ref: commit 3e24b3e2c2
ref: FS-6783
ref: FS-6775
2014-09-03 18:16:11 +00:00
Giovanni Maruzzelli
5c15e85ce4 mod_spandsp: added SWITCH_CURRENT_APPLICATION_RESPONSE_VARIABLE on application errors 2014-09-03 15:52:50 +02:00
Travis Cross
acb439ca03 Avoid leaking memory while iterating hash tables
`switch_core_hash_first` allocates an iterator on each call that is
never freed except when the hash table is empty.

By using `switch_core_hash_first_iter` we allocate only one iterator,
and that iterator is freed after the last item is processed.
2014-08-30 03:49:51 +00:00
Travis Cross
df559e0aac Add back goodness refactored out 2014-08-30 01:32:57 +00:00
Travis Cross
9481d9843c Fix comment spelling 2014-08-30 01:19:09 +00:00
Travis Cross
6f2eac6876 Fix comment spelling 2014-08-30 00:52:16 +00:00
Travis Cross
63f16425bd Refactor mod_hash limit_release_hash a bit 2014-08-29 21:44:04 +00:00
Brian West
3e24b3e2c2 FS-6775 #resolve 2014-08-29 09:55:00 -05:00
Travis Cross
dc88617c99 Lower log level of limit increases and releases
In some configurations where many limits are used, the limit increases
and releases were generating a lot of noise and making it harder to
see when limits were exceeded, which was at the same log level.
2014-08-28 01:40:36 +00:00
Anthony Minessale
0f1494ae06 Improve conference recording 2014-08-26 09:52:55 -05:00
Travis Cross
b2f59dd200 Add warning when using HTTPS with mod_curl
mod_curl currently does not verify the authenticity of the peer's
certificate, and does not verify whether the common name on the
certificate matches the server.  This makes mod_curl initiated TLS
connections completely insecure.  We should fix this, but until we do,
we'll warn people that it's not doing what they may think it is.

ref: http://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html
ref: http://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYHOST.html
2014-08-21 22:24:04 +00:00
Travis Cross
f2ca3c5211 Decode params to curl_sendfile
`curl_sendfile` generates a multipart message with Content-Type:
multipart/form-data with no separate Content-Type headers in the parts
for each non-file argument.  These parts therefore default to
text/plain.  However, prior to this commit, we were putting the URL
encoded POST data into these parts, which is not correct.  We should
be putting raw text into the parts.

With this commit, we urldecode each argument key and value before
composing the multipart message.

See:

  http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.2
2014-08-20 10:37:24 +00:00
Brian West
8ebfca9e3d Merge pull request #24 in FS/freeswitch from ~STANGOR/freeswitch:master to master
* commit '4d0b875d4e7b2ee1fc8f30591b5c98c61080fae5':
  fix mod_fifo presence https://jira.freeswitch.org/browse/FS-6732
2014-08-14 14:02:27 -05:00
Mike Jerris
5eb01b519e Merge pull request #25 in FS/freeswitch from ~STEVEAYRE/freeswitch:master to master
* commit '05ef18948d3870c4afcd82ce32e164e4a152a8e1':
  add uptime api to mod_commands
2014-08-13 13:37:17 -05:00
Stan Gor
4d0b875d4e Merging in latest from upstream (FS/freeswitch:refs/heads/master)
* commit 'b60df39b96b05b6c3cf220d5049ea5fc20dfa6e1':
  mod_http_cache: fix configuration so that carriage returns or other whitespace is OK around S3 keys
  mod_http_cache: fixed S3 URL parser to allow mybucketsubdomain.com.s3.amazonaws.com
2014-08-12 22:08:44 -05:00
Chris Rienzo
b60df39b96 mod_http_cache: fix configuration so that carriage returns or other whitespace is OK around S3 keys 2014-08-12 16:28:42 -04:00
Chris Rienzo
3b45ef90ae mod_http_cache: fixed S3 URL parser to allow mybucketsubdomain.com.s3.amazonaws.com 2014-08-12 16:07:56 -04:00
Steven Ayre
05ef18948d add uptime api to mod_commands 2014-08-12 14:06:15 +01:00
stangor
c966dc865a fix mod_fifo presence
https://jira.freeswitch.org/browse/FS-6732
2014-08-11 14:08:10 -07:00
Brian West
aeced06c6c Merge pull request #23 in FS/freeswitch from ~DDRAGIC/freeswitch:fix_mod_blacklist to master
* commit 'fe2a6e8acae2e8104c9480361b1561ee3f120bf1':
  FS-6620 mod_blacklist fix not deleting entries from list
2014-08-11 14:54:42 -05:00
Travis Cross
8414c498cf Fix line endings per .gitattributes 2014-08-08 15:24:42 +00:00
Anthony Minessale
52ed525b97 fix channel count in embedded file formats 2014-08-06 00:25:04 +05:00
Dušan Dragić
fe2a6e8aca FS-6620 mod_blacklist fix not deleting entries from list 2014-08-03 11:51:46 +02:00
Anthony Minessale
fb274514df add switch_separate_file_params function so when using relative paths with bracketed params the full path can be constructed with the params in tact 2014-08-01 22:57:40 +05:00
Travis Cross
5a7144c44a Add DELETE request support to mod_curl 2014-07-31 04:07:36 +00:00
Anthony Minessale
004c5ab2b0 fix some issues with duplicate chat events and some cleanup 2014-07-24 22:58:12 +05:00
Brian West
d9eafdf0cb FS-6681: fix dup of audio/wav and add audio/x-wav 2014-07-24 08:30:44 -05:00
Anthony Minessale
7596689865 add chat to demo 2014-07-24 10:13:39 +05:00
Anthony Minessale
f0d1be5f41 reduce radius for auto positioning 2014-07-23 01:05:55 +05:00
Anthony Minessale
025e65a0cd fix resampler issue caused by refactoring impacting audio quality of resampled calls in the conference 2014-07-23 01:04:35 +05:00
Anthony Minessale
93983e63cc revert fd9d77feee 2014-07-23 01:01:44 +05:00
Moises Silva
d6574e8c0f dos2unix a bunch of files
For some reason these files would get marked as modified
just after a fresh clone on Linux
2014-07-22 15:04:28 -04:00
Travis Cross
a537d80372 Add new module: mod_prefix
mod_prefix is an in-memory data store optimized for fast lookups
according to the longest prefix match (LPM) rule.

Tables of key-value string pairs in JSON format can be loaded at
startup via configuration and at runtime via the API.

The implementation uses a bitwise trie (aka binary prefix tree), so
arbitrary string keys are supported.
2014-07-22 15:28:31 +00:00
Anthony Minessale
997e921721 add transfer command 2014-07-19 00:32:09 +05:00
Anthony Minessale
fd9d77feee add clear channel for mono participants while in a conference with 3d callers 2014-07-12 03:31:26 +05:00
Anthony Minessale
a03963fb92 fold livetables into verto obj and expose moderator mode 2014-07-12 03:27:08 +05:00
Brian West
07f4c6204e FS-6646 --resolve 2014-07-11 11:03:22 -05:00
Michael Jerris
f2887fb89e CID:1224272 Dereference after null check. member can not actually be NULL in any of the scenarios calling this function 2014-07-09 14:32:38 -04:00
Mike Jerris
68a8bb7fff Merge pull request #9 in FS/freeswitch from ~PFOURNIER/freeswitch:feature/fax_enable_tep to master
* commit '0fb179acf2246b896f1a66cfb96da68e9d2675f7':
  Add new option to request TEP to be used for an outbound fax call
2014-07-09 11:54:16 -05:00
Brian West
f18a773ca2 Merge pull request #8 in FS/freeswitch from ~PFOURNIER/freeswitch:bugfix/fax_disable_ecm to master
* commit '5d31c9b9fe2ae6dead163c60974a41fec4fac3fc':
  It was impossible to disable ECM with T.38 in gateway mode
2014-07-09 10:48:56 -05:00
Brian West
a79a9ea9ed FS-6373 2014-07-09 08:25:54 -05:00
Patrice Fournier
0fb179acf2 Add new option to request TEP to be used for an outbound fax call 2014-07-08 01:06:32 -04:00
Patrice Fournier
5d31c9b9fe It was impossible to disable ECM with T.38 in gateway mode 2014-07-08 01:05:28 -04:00
Travis Cross
c17d58b856 Refactor the curl PUT read callback 2014-07-04 07:47:04 +00:00
Travis Cross
2fea35282f Advance the data_stream data pointer 2014-07-04 07:43:59 +00:00
Travis Cross
a84b76be2a Add PUT support to mod_curl curl api and app
With both the `curl` api command and application, you can now ask for
data to be PUT where previously it could only be sent via POST.
2014-07-04 07:40:13 +00:00
Anthony Minessale
9e0d1d6841 only count unmuted channels in positioning 2014-07-02 22:57:29 +05:00
Anthony Minessale
f0d16d0d18 expand positioning api usage 2014-07-02 04:49:16 +05:00
Anthony Minessale
7f9348dbc3 fix volume adjustments in stereo conference 2014-06-30 23:39:42 +05:00
Anthony Minessale
41a7d1cf31 some refactoring to make new stereo stuff more stable 2014-06-30 23:00:45 +05:00
Anthony Minessale
591ea9e9ca tweaks 2014-06-30 04:39:46 +05:00
Anthony Minessale
0bb7f1659f check for member channel 2014-06-30 01:59:21 +05:00
Anthony Minessale
0ac78cacc3 add openal code to mod_conference 2014-06-30 01:23:08 +05:00
Anthony Minessale
ba784f2548 skip update on member channels with no json 2014-06-25 13:40:50 -05:00
Eliot Gable
b21f34bffc Clarify error message. 2014-06-21 19:16:50 +00:00
Anthony Minessale
011e069652 fix recording in stereo conferences 2014-06-20 23:53:22 +05:00
Jeff Lenk
56ef59e9ad vs2010 reswig and fix mod_rss for recent stereo changes 2014-06-12 22:48:21 -05:00
Anthony Minessale
579a051867 add channels param the the silence generator function 2014-06-13 04:49:44 +05:00
Anthony Minessale
97cc089826 fix compile errs 2014-06-12 13:12:39 -04:00
Anthony Minessale
928a989de1 first pass of stereo support 2014-06-12 22:06:33 +05:00
Travis Cross
03202e3017 Add fsctl command to summon reincarnation
If you start freeswitch with -reincarnate or -reincarnate-reexec, FS
will restart automatically in the event of an unexpected exit.

Currently, you can cause FS to immediately call exit(0) with `fsctl
shutdown now`, or you can have it call abort() with `fsctl crash`.
Which are both nice, but if you have reincarnation engaged, you really
might want FS to call exit([non-zero]) so the great supervisor
immediately breathes life back into your system.

This is now available via `fsctl shutdown reincarnate now`.
2014-06-10 22:39:27 +00:00
Travis Cross
b53a6c2b2e Remove unused assignment
If we don't find it, we create a new one, and if we do find it, we
don't use it.
2014-05-29 16:01:09 +00:00
Travis Cross
609982cf2f Remove redundant check for null
We're asserting now, and we would have already blown up from
dereferencing earlier.
2014-05-29 14:25:49 +00:00
Travis Cross
6663692ff7 Assert on implied failure to malloc
switch_event_expand_headers should only return null on a malloc
failure, so we might as well just assert here.
2014-05-29 14:24:48 +00:00
Travis Cross
e66d24622a Fix potential dereference of null pointer
The node could conceivably disappear before we grab the globals mutex
and we'd get back a null pointer.
2014-05-29 14:11:33 +00:00
Travis Cross
17137d089d Add missing parenthesis pair
This would have briefly prevented setting outbound_per_cycle from the
mod_fifo config file.
2014-05-29 13:21:22 +00:00
Travis Cross
84fe7b0794 Remove tautological condition check
We already decided to goto end if node is null, so it cannot be null
here.
2014-05-29 13:15:44 +00:00
Travis Cross
bf59d57dab Add missing parenthesis pair
This would have briefly caused the importance value in the fifo config
file to be ignored.
2014-05-29 13:10:23 +00:00
Travis Cross
a976badec7 Document the length limit of fifo_outbound_uuid
Ask me sometime how I was "reminded" of this.
2014-05-28 17:04:46 +00:00
Travis Cross
00b25baa42 mod_fifo: Explain session message unbridge constant 2014-05-28 01:32:11 +00:00
Travis Cross
144fea57b2 mod_fifo: Add missing has_outbound to docstring 2014-05-28 01:32:11 +00:00
Travis Cross
42e9615900 mod_fifo: Add missing tab completions 2014-05-28 01:32:10 +00:00
Travis Cross
06805452d8 mod_fifo: Cleanup documentation formatting 2014-05-28 01:32:10 +00:00
Travis Cross
431d7d97c7 mod_fifo: Document effect of fifo strategy and importance 2014-05-28 01:32:10 +00:00
Travis Cross
96012ffb3a mod_fifo: Document the enterprise strategy 2014-05-28 01:32:10 +00:00
Travis Cross
e2596b3f30 mod_fifo: Document the ringall strategy 2014-05-28 01:32:09 +00:00
Travis Cross
1b5a1c1e1d mod_fifo: Document find_consumers() 2014-05-28 01:32:09 +00:00
Travis Cross
0c25c3deb9 mod_fifo: Document node_thread_run() 2014-05-28 01:32:09 +00:00
Travis Cross
80ccaf3450 mod_fifo: Remove duplicate check in ringall strategy
We already checked the number of usable rows, and nothing has changed.
2014-05-28 01:32:08 +00:00
Travis Cross
343aee2dd8 mod_fifo: Comment manual call tracking session handler 2014-05-28 01:32:08 +00:00
Travis Cross
48acd9fe66 mod_fifo: Note source of unexplained constant 2014-05-28 01:32:08 +00:00
Travis Cross
a24b0b739f mod_fifo: Avoid getting time twice
We were simply discarding unused the first time we retrieved here.
2014-05-28 01:32:07 +00:00
Travis Cross
64144d73a3 mod_fifo: Refactor to avoid a memory allocation 2014-05-28 01:32:07 +00:00
Travis Cross
011882c8dd mod_fifo: Cleanup line spacing 2014-05-28 01:32:07 +00:00
Travis Cross
a5f982fd1c mod_fifo: Replace duplicate code with node_caller_count() 2014-05-28 01:32:06 +00:00
Travis Cross
597a5c1208 mod_fifo: Remove empty declaration 2014-05-28 01:32:06 +00:00
Travis Cross
edecd151a5 mod_fifo: Document the read_frame_callbacks 2014-05-28 01:32:06 +00:00
Travis Cross
42ebfbfc59 mod_fifo: Document the fifo_queue_t structure 2014-05-28 01:32:06 +00:00
Travis Cross
5f4ed9c123 mod_fifo: Document fifo_chime_data::list 2014-05-28 01:32:05 +00:00
Travis Cross
2c7c15261d mod_fifo: Document caller DTMF handler 2014-05-28 01:32:05 +00:00
Travis Cross
3e6199eace mod_fifo: Remove reimplementation of strchr() 2014-05-28 01:32:05 +00:00
Travis Cross
27b3ddcc9f mod_fifo: Document the consumer DTMF callback 2014-05-28 01:32:04 +00:00
Travis Cross
7920630c8f mod_fifo: Refactor DTMF exit key matching 2014-05-28 01:32:04 +00:00
Travis Cross
c34ad2c0ec mod_fifo: Avoid getting a var when we won't use it 2014-05-28 01:32:04 +00:00
Travis Cross
077579b131 mod_fifo: Document fifo_queue_popfly() 2014-05-28 01:32:03 +00:00
Travis Cross
b914c2374d mod_fifo: Document fifo_queue_pop_nameval() 2014-05-28 01:32:03 +00:00
Travis Cross
1eaf4b50ca mod_fifo: Document remove parameter of fifo_queue_pop() 2014-05-28 01:32:03 +00:00
Travis Cross
e241477860 mod_fifo: Tighten up some whitespace 2014-05-28 01:32:03 +00:00
Travis Cross
e677da5870 mod_fifo: Refactor in create_node() 2014-05-28 01:32:02 +00:00
Travis Cross
628b6c19ab mod_fifo: Remove dead code
We were making a copy of the fifo name and stripping any domain name,
but then not using the value.
2014-05-28 01:32:02 +00:00
Travis Cross
6105e9783c mod_fifo: Refactor load_config()
Reduce number of local variables where possible; consolidate lines.
2014-05-28 01:32:02 +00:00
Travis Cross
353c3b19fa mod_fifo: Document fifo_node::outbound_name 2014-05-28 01:32:01 +00:00
Travis Cross
17070e9dac mod_fifo: Improve strategy thread function names 2014-05-28 01:32:01 +00:00
Travis Cross
1f7589d6fa mod_fifo: Refactor 2014-05-28 01:32:01 +00:00
Travis Cross
0526e00457 mod_fifo: Replace global var with local static
This marker value is only used in one place.
2014-05-28 01:32:01 +00:00
Travis Cross
2068b284cc mod_fifo: Fix memory leak of xml structure
If getting the DB handle failed during the load or reload of the
configuration, we would leak the XML structure we just allocated for
the configuration.
2014-05-28 01:32:00 +00:00
Travis Cross
c6e90e0111 mod_fifo: Refactor out config file reading 2014-05-28 01:32:00 +00:00
Travis Cross
a3a62d2481 mod_fifo: Convert macro to fn and improve name 2014-05-28 01:32:00 +00:00
Travis Cross
06d94d2c17 mod_fifo: Move straggling vars to global struct 2014-05-28 01:31:59 +00:00
Travis Cross
31ae5b4655 mod_fifo: Cleanup whitespace 2014-05-28 01:31:59 +00:00
Travis Cross
f80e869fe0 mod_fifo: Cleanup whitespace in load_config() 2014-05-28 01:31:59 +00:00
Travis Cross
a15058406e mod_fifo: Cleanup config parsing 2014-05-28 01:31:58 +00:00
Travis Cross
20f35e4591 mod_fifo: Improve function names 2014-05-28 01:31:58 +00:00
Travis Cross
84d6b2e351 mod_fifo: Consolidate code 2014-05-28 01:31:58 +00:00
Travis Cross
8ccd13bd9a mod_fifo: Document load_config() 2014-05-28 01:31:58 +00:00
Travis Cross
83f69a41e8 Add in-code documentation for mod_fifo
The goal here is to describe theory.  We want to illuminate what the
code is trying to do and what the core concepts are.
2014-05-28 01:31:57 +00:00
Michael Jerris
c768e4b6e6 CID:1215198 don't set variables that are not used, and clean up the bail out usage condition to be more sane 2014-05-22 14:52:56 +00:00
William King
11f373d4f2 CID: 1215198 Fix an assignment so that the variable only handles malloc'd data. 2014-05-21 16:28:03 -07:00
Marc Olivier Chouinard
29e2263442 CID:1210789 Make return value of a function available from the another calling function. Also add a small status check. 2014-05-16 17:18:17 -04:00
Marc Olivier Chouinard
8fa7398760 CID:1025868 Simplified a function arguments never called. 2014-05-16 17:03:59 -04:00
Michael Jerris
386000d877 CID:1024418 Unintentional integer overflow 2014-05-16 20:07:58 +00:00
Michael Jerris
4238339176 CID:1023970 Unused pointer value 2014-05-16 19:53:23 +00:00
Michael Jerris
6a8002db79 CID:1024582 Logically dead code 2014-05-16 19:27:25 +00:00
Michael Jerris
21a5d166c6 CID:1024581 Logically dead code 2014-05-16 19:22:37 +00:00
Michael Jerris
c1f7887039 CID:1024580 Logically dead code, x will always be > 1 2014-05-16 19:19:31 +00:00
Michael Jerris
73c1e09269 CID:1024579 Logically dead code 2014-05-16 19:09:18 +00:00
Michael Jerris
9b1ebff8de CID:1024270 Dereference before null check 2014-05-16 18:54:50 +00:00
Michael Jerris
54fc2f5e39 CID:1023975 Unused pointer value 2014-05-16 18:49:23 +00:00
Michael Jerris
a67389ad5c CID:1025879 Logically dead code 2014-05-16 18:20:25 +00:00
Michael Jerris
ecde431730 CID:1025850 Dereference before null check 2014-05-16 18:15:34 +00:00
Michael Jerris
b10c865c25 CID:1025849 Dereference before null check 2014-05-16 18:12:28 +00:00
Marc Olivier Chouinard
a997331577 CID:1214125 https://scan6.coverity.com:8443/docs/en/cov_checker_ref.html#static_checker_BUFFER_SIZE 2014-05-16 13:30:27 -04:00
Michael Jerris
1b0bdaf85e CID:1214212 Resource leak in voicemail_list 2014-05-15 14:11:39 +00:00
Michael Jerris
4e888a282c CID:1214196 Dereference null return value, if we hit this condition, something very bad has happened, we should never have the private not set if we get to the hangup hook, log error instead of crashing 2014-05-15 14:09:38 +00:00
Michael Jerris
d2884ac5a6 CID:1214211 Resource leak 2014-05-15 13:58:08 +00:00
Michael Jerris
0469db0305 CID:1214200 Dereference null return value 2014-05-15 13:47:24 +00:00
Michael Jerris
92c6f3abc5 CID:1214192 Dereference after null check, don't crash when no file name passed on file open 2014-05-15 13:37:26 +00:00
Michael Jerris
179e07c649 CID:1214219 Resource leak 2014-05-15 13:30:39 +00:00
Michael Jerris
07b6bba68b CID:1214209 Resource leak, don't leak event populated by switch_channel_get_variables 2014-05-15 13:22:51 +00:00
Michael Jerris
452d7a3793 CID:1214163 Unchecked return value, check return value of switch_ivr_play_file and bail out if it fails 2014-05-15 13:18:58 +00:00
Michael Jerris
7c72e94a67 CID:1214158 Buffer not null terminated 2014-05-15 12:42:49 +00:00
Michael Jerris
68825ff4f1 CID:1214220 Resource leak 2014-05-15 12:41:09 +00:00
Michael Jerris
619b31e1e8 CID:1214140 Buffer not null terminated, make sure hostname is always null terminated 2014-05-15 12:38:41 +00:00
Michael Jerris
16805187ec CID:1214256 Unused pointer value 2014-05-15 12:36:36 +00:00
Michael Jerris
128601316f CID:1214255 Unused pointer value 2014-05-15 12:34:50 +00:00
Michael Jerris
19f3ab5182 CID:1214218 fix memory leak in conference_event_channel_handler 2014-05-15 12:33:15 +00:00
Michael Jerris
622cd21009 CID:1214231 don't leak when using invalid syntax 2014-05-15 12:27:39 +00:00
Michael Jerris
9a1c4f6827 don't pass large strucutre by value 2014-05-12 09:31:12 -04:00
Michael Jerris
3e18f08796 clean up coverity warnings and improve error checking 2014-05-12 09:08:52 -04:00
William King
ad327dffc8 CID: 1211946 fixing uninitialized pointer read in mod_translate 2014-05-07 00:22:56 -07:00
Steve Underwood
38abcf7e2c The APIs for spandsp FAX have changes, removing one of the parameters passed in
the callbacks.
2014-05-04 17:22:28 +08:00
Michael Jerris
9db6d5ba9c different distros have diff pkg names 2014-05-02 18:35:37 -04:00
Natanael Copa
317f4b1442 Fix building with musl libc
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)

limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Travis Cross
fc40e4ab79 Avoid leaking data_buf in mod_conference
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated.  On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
Michael Jerris
582fa1a664 fix typo 2014-05-01 18:22:57 -04:00
Travis Cross
cd650f6055 Use system ldns library
This library is used only by mod_enum and is available on most
platforms.  The version in our tree has many code quality problems
that are generating noise when doing static analysis.  Suffice it to
say we want rid of it as our responsibility.

FS-353
2014-05-01 22:01:59 +00:00
Travis Cross
c1f884cd33 Remove old ldns patch from FS-3110 2014-05-01 22:01:59 +00:00
Raymond Chandler
33460064ac CID: 1210739 2014-05-01 17:34:54 -04:00
Raymond Chandler
a4e0929ef0 CID: 1210596 2014-05-01 17:28:54 -04:00
Raymond Chandler
17f79bc2c3 CID: 1210770 2014-05-01 16:36:58 -04:00
Anthony Minessale
7f18b80e60 FS-6503 --resolve remove unused code 2014-05-02 01:28:12 +05:00
Brian West
c462ed6ae1 FS-6499 --resolve 2014-05-01 15:21:57 -05:00
Michael Jerris
64f1098b8c remove dead assignment 2014-05-01 14:17:06 -04:00
Michael Jerris
b0fd845786 remove dead assignment 2014-05-01 14:04:56 -04:00
Raymond Chandler
e4d807108c CID: 1210646 2014-04-30 18:47:02 -04:00
Raymond Chandler
3abcee7142 unused 2014-04-30 18:36:44 -04:00
Michael Jerris
23b3e172d5 don't leak file handle if fd = 0 2014-04-30 15:56:36 -04:00
Michael Jerris
6f16e0d3da don't leak if first realloc fails but second one succeeds 2014-04-30 15:53:26 -04:00
Michael Jerris
068ad205b7 split this into 2 functions so its clear if this function allocates or not 2014-04-30 15:48:23 -04:00
Michael Jerris
0b8d2c5d65 add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr 2014-04-30 13:31:06 -04:00
Michael Jerris
a9a852477a fix read beyond buffer length error 2014-04-30 13:25:29 -04:00
Chris Rienzo
c36e63026c mod_http_cache: CID 1025858: Thread deadlock (ORDER_REVERSAL) 2014-04-30 10:08:00 -04:00
Michael Jerris
e98045841e gracefully handle allocation failure 2014-04-30 08:55:39 -04:00
Michael Jerris
2e8572acb5 we always have the session in the dialplan function 2014-04-30 08:51:52 -04:00
Michael Jerris
b3bfa563ae we always have the caller profile at this point, if for some reason we don't just instead of crashing 2014-04-30 08:50:29 -04:00
Michael Jerris
7508481597 we always have the seesion in the app function 2014-04-30 08:46:11 -04:00
Michael Jerris
9bf98d0dd3 remove useless checks of array == 0 2014-04-30 08:43:57 -04:00
Michael Jerris
529099f15c silence incorrect warnings about null pointer derference and remove unused code 2014-04-29 14:34:49 -04:00
Brian West
5c07c3eb03 don't use memory after free when using naptr with mod_enum with multiple routes 2014-04-28 13:03:09 -05:00
Michael Jerris
a83fde3543 block of code in here twice was writing over expanded, causing it to potentially leak 2014-04-28 13:41:48 -04:00
Brian West
1aa2fc7548 FS-3332 --resolve 2014-04-25 15:53:21 -05:00
Anthony Minessale
2e0cd74e07 FS-6477 --resolve 2014-04-22 23:51:44 +05:00
Brian West
265de3d314 FS-6082 --resolve 2014-04-18 15:17:23 -05:00
Brian West
190c241c81 FS-6452 mod_spy doesn't react on events without variable_domain_name 2014-04-17 20:12:27 -05:00
William King
748b7dea3c Get rid of a small memory leak when the configs are reloaded in mod_enum 2014-04-16 09:27:34 -07:00
Anthony Minessale
a4a792488b add generic keepalive system and implement it in sofia to send MESSAGE or INFO packets in-dialog at specified interval.
Adds app: enable_keepalive 0|<seconds>
This app can be run in the dialplan or with execute_on_* type variables for B-legs.

Adds sofia param: keepalive-method  : defaults to MESSAGE can also be "INFO"
This param sets which SIP method to use.
2014-04-16 06:10:25 +05:00
Travis Cross
39f960a212 Avoid leaking memory on mod_voicemail unload 2014-04-12 06:48:36 +00:00
Travis Cross
886a730ae8 Avoid leaking memory on mod_hash unload 2014-04-12 06:43:11 +00:00
Travis Cross
237da22e22 Avoid leaking memory on unload of mod_dptools
Automated leak detectors find leaked memory on shutdown.  Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-12 06:31:31 +00:00
Travis Cross
538cdd378c Hide warning about sometimes initialized variable
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-12 05:02:09 +00:00
James Le Cuirot
4bdb7129ba Ungetlib libmemcached
Tested with several libmemcached versions between 0.31 and
1.0.18. Unfortunately the API is extremely volatile and awkward to
use. Packaging scripts still need addressing.

FS-353
2014-04-11 22:55:36 +00:00
Anthony Minessale
38c6e89db0 remove SSML from mod_rss 2014-04-11 03:33:57 +05:00
Anthony Minessale
4178688b4a add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc 2014-04-09 23:26:47 +05:00
Travis Cross
1e273e514d Avoid playback on dead channels in voicemail
For years we've been generating spurious messages like:

  [WARNING] switch_ivr_play_say.c:348 Macro [voicemail_ack]: 'saved' did not match any patterns

This would happen when the caller hangs up during the playback of
certain prompts in the voicemail system where we weren't checking the
return value of vm_macro_get().  Looking closely at the log, it's
clear we were calling down into switch_ivr_phrase_macro() long after
the channel was gone.

The message above is also misleading -- switch_ivr_phrase_macro()
would have been able to find that pattern just fine, but it never
actually looked because the channel was gone.  We'll clean up that
message in a follow on commit.
2014-04-09 04:46:47 +00:00
William King
711e49c46a Don't leak these 4 hash tables when mod_fifo is reloaded 2014-04-08 11:18:23 -07:00
William King
aae1954c07 FS-6442 --resolve 2014-04-08 10:36:36 -07:00
Anthony Minessale
c98fb0bd0e send muted members as recvonly on RFC4575 data 2014-04-07 20:51:29 +05:00
Anthony Minessale
1ce92b3ae7 FS-6421 --resolve 2014-04-02 16:43:36 -05:00
Anthony Minessale
7151d6acea FS-6402 part 2 2014-04-02 03:21:37 +05:00
Travis Cross
a78596221a Add uuid_ring_ready API command
We already had uuid_answer and uuid_pre_answer, so we might as well
add uuid_ring_ready.
2014-04-01 20:58:49 +00:00
Anthony Minessale
5c0cff70b3 FS-6402 --resolve 2014-04-02 01:20:19 +05:00
Michael Jerris
0cc3a17072 FS-6408: fix passing of CPPFLAGS to spandsp build 2014-04-01 13:28:22 -04:00
Travis Cross
b9369f6d4e Remove stray executable bits 2014-03-31 20:38:09 +00:00
Anthony Minessale
107c5eccc3 video refresh floor holder on conference join 2014-03-31 22:39:46 +05:00
William King
e0d9d7f0b2 FS-6410 Adding some log lines to mod_sonar so that it is more clear what is happening when the app is sending and detecting pings. 2014-03-29 19:08:24 -07:00
Michael Jerris
310f2ec3d6 initialize var 2014-03-26 11:25:23 -04:00
Raymond Chandler
5cccc6270b seg-- 2014-03-25 23:31:16 -04:00
Raymond Chandler
0ddd151a22 FS-5845 more leaks found by mikej 2014-03-25 22:44:37 -04:00
Chris Rienzo
98bba8b57a mod_mongo: switched from C++ to latest C driver 2014-03-24 17:34:56 -04:00
Michael Jerris
5ac9748827 FS-5845: don't leak dbh in error conditions 2014-03-24 16:10:12 -04:00
Brian West
f890854e0d FS-6381 add hostname to conference cdr 2014-03-21 17:23:50 -05:00
Jeff Lenk
dd242f3ba6 FS-6346 2014-03-20 18:32:19 -05:00
Travis Cross
1470622292 Require libcurl as a system dependency
This purges libcurl from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-20 21:15:29 +00:00
Travis Cross
c993962d0b Update some modules to use CPPFLAGS
These modules use curl and we'll be adding in some bits to the
CPPFLAGS.
2014-03-20 21:09:46 +00:00
Brian West
c9757f72a5 FS-6292 additional define to avoid on NetBSD, If someone wants to get this workign please submit patches 2014-03-19 03:35:47 -05:00
Brian West
95392955b6 FS-6375 fix -lutil as its not needed 2014-03-18 17:54:56 -05:00
Brian West
aeebd712f8 FS-6375 exclude sun from modem support in spandsp 2014-03-18 17:37:04 -05:00
Brian West
b4ba7e1e2a FS-6370: --resolve build memcache lib on mod build 2014-03-18 17:31:26 -05:00
Travis Cross
2117f70acf Edit out gcc-ism from soundtouch lib
This allows building mod_soundtouch in clang as clang doesn't support
gcc's -fcheck-new.
2014-03-18 21:39:18 +00:00
Michael Jerris
9df17278d7 fix uninitialized variables 2014-03-18 14:28:05 -04:00
Michael Jerris
bf4339712a FS-6293: fix spandsp srcdir builds when user is setting cflags 2014-03-18 14:20:40 -04:00
Michael Jerris
e077aa0db0 FS-6293: mod_esl srcdir build 2014-03-18 14:07:38 -04:00
Michael Jerris
1c5e61447b move libs/stfu into the core, as it is not really a lib 2014-03-17 09:44:14 -04:00
Michael Jerris
aea7800a42 fix var type warnings in mod_lcr 2014-03-15 22:23:46 -04:00
Michael Jerris
4ee5d1f617 FS-6293: srcdir builds, pass along CFLAGS to spandsp lib build as well, not just override them 2014-03-15 22:14:11 -04:00
Michael Jerris
048ce8d1f3 FS-6293: srcdir builds, most of the built in mods work now 2014-03-14 23:13:34 -04:00
Michael Jerris
e911986a72 FS-6293: more srcdir build fixes, fix mod_enum srcdir build 2014-03-14 20:02:22 -04:00
Brian West
666231f91b BNPH-6149: allow to use system curl again, fix some types on auth_scheme values to all be long, don't use curl private function in our wrapper. This may cause missing symbol curl_easy_setopt with visibility turned on, if it does that, please let me know 2014-03-12 13:47:24 -05:00
Anthony Minessale
bc70900335 PLIV-5 --resolve httpapi cache not working for some urls 2014-03-10 12:20:16 -05:00
Michael Jerris
87af4d3278 fix mod_enum install 2014-03-09 14:44:41 -04:00
Chris Rienzo
cf04dd3e75 FS-6326 --resolve switch_core_hash_init_nocase changed and mod_http_cache wasn't updated 2014-03-09 11:31:00 -04:00
Jeff Lenk
f649af84e8 fix windows build for last commit 2014-03-08 14:23:41 -06:00
Anthony Minessale
804ef7709d change from sqlite hash to newly added one 2014-03-09 00:37:17 +05:00
Travis Cross
010740d664 Correct sizeof argument in mod_conference
This corrects a memset introduced in commit
bd4a0d8cbc.

The sizeof would have only returned the size of a pointer.
2014-03-08 01:56:18 +00:00
Travis Cross
e6ec9b3c61 Add automake subdir-options for modules
The automake project is apparently changing behavior in their next
major version and warning everyone who relies on subdir-options to add
it explicitly.
2014-03-08 00:32:02 +00:00
Michael Jerris
bcd9f49fbe move applications to use automake 2014-03-07 18:36:12 -05:00
Anthony Minessale
5375d8b643 add on to last commit 2014-03-07 06:34:32 +05:00
Anthony Minessale
bd4a0d8cbc add a way to tell mod_conference when the rate of the channel has changed due to a codec change so it can reset the resampler and codecs internally 2014-03-07 05:17:47 +05:00
Travis Cross
74775d4397 Revert conference "tool" misfeature
This was added as part of a mass copyright header update in commit
6e7d5d089.  That's obviously not the right way to add features, so
we're reverting this.

If this feature is actually desired, it should be added in its own
commit, properly described in the commit message, and documented.

(The commit added a "tool" flag that could be applied to a conference
participant to mess with that person by disrupting his or her audio.)

This partially reverts commit 6e7d5d0897.

This feature earlier tried to sneak in under the guise of a whitespace
cleanup in commit a000749e70 which
Anthony reverted at commit a24f9aa8bc.

Let's not play these games.
2014-03-05 03:29:10 +00:00
Anthony Minessale
6ef3f7bde7 add timeout <seconds> to mod_curl api call 2014-03-03 22:58:45 +05:00
Michael Jerris
07399e213f fix missing type definitions 2014-03-03 08:26:54 -05:00
Michael Jerris
ae216daf02 fix warning abount comment inside comment 2014-03-03 08:26:54 -05:00
Raymond Chandler
b0d7551c80 use newSQL 2014-03-02 03:13:01 -05:00
Brian West
93c05d9c5f FS-4502 --resolve 2014-02-28 16:23:37 -06:00
Anthony Minessale
8862fbc3a1 FS-5461 --resolve you tricked me I said make 1 patch with all of it 2014-03-01 00:27:23 +05:00
Anthony Minessale
5ed78f8987 FS-4441 FS-5461 --resolve 2014-03-01 00:23:40 +05:00
Marc Olivier Chouinard
f18fe5770d FS-6151 --resolve Make the module unloadable 2014-02-24 21:21:51 -05:00