Commit Graph

24616 Commits

Author SHA1 Message Date
Anthony Minessale 1239e32de2 FS-5402 2013-05-21 13:22:17 -05:00
Anthony Minessale 363b58dc54 FS-5453 --resolve 2013-05-21 12:01:57 -05:00
Anthony Minessale 7ec78e90e1 FS-5457 2013-05-21 10:21:45 -05:00
Anthony Minessale 104febbc1a FS-5376 --resolve 2013-05-21 10:04:35 -05:00
Anthony Minessale 8ac3178e45 FS-5242 2013-05-21 10:03:22 -05:00
Anthony Minessale 0cee5ac9df FS-5211 --resolve 2013-05-21 09:29:50 -05:00
Stefan Knoblich 8019af49a4 ftmod_libpri: Fix possible NULL-ptr dereference crash in on_restart(_ack)()
Catch single channel RESTART/RESTART ACK events for non-B-channels,
that would lead to a NULL pointer dereference, because those do not have
per-channel private data (chan->call_data = chan_priv == NULL).

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-21 17:50:54 +02:00
Chris Rienzo 83d7b60d74 mod_http_cache: forgot to add write to http_cache:// format 2013-05-21 09:27:39 -04:00
Travis Cross b755c8347b Add mod_say_pl to debian build 2013-05-21 02:33:56 +00:00
Travis Cross d2f3a3114e Spelling fix 2013-05-21 02:00:43 +00:00
Anthony Minessale 3e6cdd6b57 FS-5360 2013-05-20 12:22:58 -05:00
Anthony Minessale 6c5de69b18 getting read_impl too soon here 2013-05-20 11:22:37 -05:00
Anthony Minessale 9cdd2be095 FS-5444 --resolve 2013-05-20 08:20:38 -05:00
Chris Rienzo a0170bbdb2 mod_http_cache: added write file format 2013-05-20 11:18:40 -04:00
Chris Rienzo 8c8b2176d2 mod_http_cache: added native Amazon S3 support 2013-05-20 09:31:28 -04:00
Steve Underwood fe000f18fd Fixed a weakness in error UDPTL lost packet recovery. Hopefully this addresses
FS5202.
2013-05-20 11:30:11 +08:00
William King 50e2098be1 Add mod_xml_radius to the modules list, though disabled by default. 2013-05-18 20:49:51 -07:00
William King b4209ca93b Theoretical memory leak where if attr_init failed, then check would have still been malloc'd but not used. 2013-05-18 20:42:03 -07:00
William King e2ea6e58c8 Minor code cleanup. calling va_start without calling va_end doesn't leak does it? Either way, it's fixed now. 2013-05-18 20:15:55 -07:00
William King 9ace496fe3 full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors. 2013-05-18 19:13:18 -07:00
William King ef1bf8e34a Was causing a very small leak on naptr lookups. Upon review just happened to be a typo missing a bang. 2013-05-18 17:50:50 -07:00
William King 508fb78e94 My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer. 2013-05-18 17:46:13 -07:00
William King 291244c099 Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case. 2013-05-18 17:34:16 -07:00
William King 45803e38e7 Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak. 2013-05-18 17:06:54 -07:00
William King d27a95a50e Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up. 2013-05-18 17:00:41 -07:00
William King f718a0572f Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not. 2013-05-18 16:35:03 -07:00
William King f519ad195a If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done. 2013-05-18 16:05:40 -07:00
William King 09553f424a FS-5443: --resolve leaked because the JS api's copy and return new malloc'd pointers. 2013-05-18 15:47:01 -07:00
William King 7f3f4855a6 When message events were added, the debug field name was overlooked. This would have only been hit when debug level was above 'DEBUG1' and at that point it would have incorrectly chosen debug display names. 2013-05-18 15:10:44 -07:00
William King 4fcefab0d0 Minor typo. User is being passed into this fuction as a long pointer, not a long. 2013-05-18 14:29:59 -07:00
William King 047dc67098 read() does not NULL terminate statbuf, but strstr expects statbuf to be null terminated. 2013-05-18 14:26:40 -07:00
William King 3f06bbd04a This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated. 2013-05-18 13:38:24 -07:00
Jeff Lenk de0fea316e FS-5434 --resolve 2013-05-17 21:38:32 -05:00
Anthony Minessale 2bafe135c0 remove flag 2013-05-17 16:13:19 -05:00
Anthony Minessale e03b6d0878 fix silence_stream size bug 2013-05-17 16:11:04 -05:00
Anthony Minessale ea881b191f media/srtp refactoring pass 2013-05-17 15:39:30 -05:00
William King 8d7aa3ff65 FS-5441: --resolve 2013-05-17 12:39:17 -07:00
William King 58e205ccdb how...? 2013-05-17 11:36:31 -07:00
William King cfeb6aaf54 Since there isn't neutral ground, on the rtmp state callback we actually have to force the write lock of the session, but we only need a try lock on removing the session from the rsession->session_hash. This removes a deadlock caused when we had to enforce with locks that the rsession couldn't be destroyed if the FS session was in the middle of a hangup. 2013-05-17 11:36:30 -07:00
William King f24d1cde3d Seems the session wasn't coming to the hangup in a locked state. 2013-05-17 11:36:30 -07:00
William King 36f198e883 Seems having a read lock still prevents a write lock to be taken, even if the thread that is trying to get the write lock currently has the read lock. 2013-05-17 11:36:29 -07:00
William King 9b0212ab59 Include the write lock since we're changing the tech_pvt 2013-05-17 11:36:29 -07:00
Steve Underwood 37d109b107 Some tweaks to the image translate code 2013-05-16 02:28:20 +08:00
Anthony Minessale 97faaab42c FS-5430 --resolve 2013-05-15 09:27:18 -05:00
Jeff Lenk a4f3629773 trivial fix compiler warning 2013-05-15 11:51:55 -05:00
Anthony Minessale d50366f377 FS-5418 --resolve 2013-05-15 08:08:41 -05:00
Anthony Minessale d5ad021720 FS-5208 --resolve 2013-05-15 07:36:56 -05:00
Anthony Minessale 644720454f fix some minor regression in media code 2013-05-14 12:55:02 -05:00
Anthony Minessale 101b116daf FS-5011 try to fill gaps 2013-05-14 11:22:53 -05:00
Steve Underwood 11f8491170 Fixed a silly in the FAX image resolution settings 2013-05-15 01:49:58 +08:00