fc40e4ab79
Avoid leaking data_buf in mod_conference
...
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated. On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
64c678f17a
freetdm: ftdm_gsm: Fix a few compilation warnings
2014-05-01 20:28:23 -04:00
99c022b1dd
FS-6500: freetdm: Add more enum compliance by defining proper enum values for FTDM_END and FTDM_ANY special state values
2014-05-01 20:24:03 -04:00
db1a2de186
don't null check what we know won't be null
2014-05-01 19:00:24 -04:00
2e3558c43e
don't need to double check for null
2014-05-01 18:50:26 -04:00
a3e1b7df49
Protect cross-compiling from polluted PKG_CONFIG_PATH
2014-05-01 22:23:59 +00:00
582fa1a664
fix typo
2014-05-01 18:22:57 -04:00
cd650f6055
Use system ldns library
...
This library is used only by mod_enum and is available on most
platforms. The version in our tree has many code quality problems
that are generating noise when doing static analysis. Suffice it to
say we want rid of it as our responsibility.
FS-353
2014-05-01 22:01:59 +00:00
c1f884cd33
Remove old ldns patch from FS-3110
2014-05-01 22:01:59 +00:00
33460064ac
CID: 1210739
2014-05-01 17:34:54 -04:00
a4e0929ef0
CID: 1210596
2014-05-01 17:28:54 -04:00
17f79bc2c3
CID: 1210770
2014-05-01 16:36:58 -04:00
7f18b80e60
FS-6503 --resolve remove unused code
2014-05-02 01:28:12 +05:00
c462ed6ae1
FS-6499 --resolve
2014-05-01 15:21:57 -05:00
d06b137abd
FS-6498 --resolve
2014-05-01 15:20:28 -05:00
d2c2f174e7
FS-6500: try to do the bounds checking properly using element of the enum
2014-05-01 14:32:23 -04:00
906467b360
fix log message on sending tport ping over ws to log error in failure cases
2014-05-01 14:20:27 -04:00
64f1098b8c
remove dead assignment
2014-05-01 14:17:06 -04:00
b0fd845786
remove dead assignment
2014-05-01 14:04:56 -04:00
d4ba268f29
remove dead assignment
2014-05-01 13:52:12 -04:00
cfd8d28bc8
silence clang unused function warnings and get rid of some unused functions
2014-05-01 09:03:19 -04:00
fc25bbc23c
remove unused function
2014-05-01 08:32:23 -04:00
b55ba90def
fix 2 potential use after free errors
2014-05-01 08:30:52 -04:00
4ec5e5af47
Refactor if blocks
...
Since the first branch doesn't need to do anything, we invert it and
pull a sub-branch out a level into the main conditional.
2014-04-30 23:23:06 +00:00
ae3cf0a1a9
Remove dead assignment
...
...now this code needs refactoring.
2014-04-30 23:22:13 +00:00
2ae823fb9f
Drop dead assignments
...
We goto done at the end of these blocks.
2014-04-30 23:03:06 +00:00
e4d807108c
CID: 1210646
2014-04-30 18:47:02 -04:00
fd4364cd43
Drop dead assignment
2014-04-30 22:43:33 +00:00
946db55b34
Drop dead assignments
2014-04-30 22:42:08 +00:00
3abcee7142
unused
2014-04-30 18:36:44 -04:00
f38ccbfb51
Remove dead assignment, but why...
...
This assignment isn't doing anything, so it safe to remove it, but
there remains the question of whether there could have been some
actually necessary intention behind this line.
2014-04-30 22:33:24 +00:00
0f6e364e61
Drop dead assignment
2014-04-30 22:33:24 +00:00
b9b5b0d827
Avoid dead assignment of return value of execv
...
execv(3) only returns on error, and will always return -1 in that
case.
2014-04-30 22:33:24 +00:00
5f3e98beb4
Fix a use after free in a 'theoretical' case in switch_cache_db_persistant_execute_trans_full where the pre_trans_execute statement fails, but SQLSetAutoCommitAttr succeeds
2014-04-30 14:37:17 -07:00
6add88b43f
check return value for es_say_general_count
2014-04-30 16:43:35 -04:00
ef18915ca5
make sure old_pid_buffer is null terminated
2014-04-30 16:36:14 -04:00
a1a397420e
fix leaked body in error case
2014-04-30 16:10:08 -04:00
23b3e172d5
don't leak file handle if fd = 0
2014-04-30 15:56:36 -04:00
6f16e0d3da
don't leak if first realloc fails but second one succeeds
2014-04-30 15:53:26 -04:00
068ad205b7
split this into 2 functions so its clear if this function allocates or not
2014-04-30 15:48:23 -04:00
b205313f4f
More fixes from Coverity scans
2014-05-01 02:56:53 +08:00
942215637a
make sure receive buffer is always null terminated
2014-04-30 13:49:58 -04:00
ac9741b579
don't leak xml string in dl_logger
2014-04-30 13:44:59 -04:00
0b8d2c5d65
add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr
2014-04-30 13:31:06 -04:00
a9a852477a
fix read beyond buffer length error
2014-04-30 13:25:29 -04:00
32c0bfde6b
A couple more Coverity issues fixed
2014-05-01 01:19:28 +08:00
c37d0dd6f0
Bisect with make -j
2014-04-30 17:10:30 +00:00
43c9f6d5f9
Don't unset CCACHE_DIR when bisecting
2014-04-30 17:04:30 +00:00
e57484af9b
FS-6497: --resolve fix for loop initial declaration not allowed
2014-04-30 12:16:02 -04:00
0ebc79457e
Another couple of Coverity related cleanups
2014-04-30 22:51:59 +08:00
Travis Cross