Commit Graph

7181 Commits

Author SHA1 Message Date
Steve Underwood 32c0bfde6b A couple more Coverity issues fixed 2014-05-01 01:19:28 +08:00
Steve Underwood 0ebc79457e Another couple of Coverity related cleanups 2014-04-30 22:51:59 +08:00
Michael Jerris 8ad8ae8e86 remove generated file from tree 2014-04-30 10:34:08 -04:00
Steve Underwood b8bd000bdd More elimination of warnings with clang 2014-04-30 22:27:29 +08:00
Steve Underwood bfacd58fa7 Eliminate some clang warnings 2014-04-30 22:18:46 +08:00
Michael Jerris 6e23eab0cc do set compiler flag that compiler doesn't support 2014-04-30 08:33:09 -04:00
Steve Underwood 21a2e19470 Eliminated another Coverity issue 2014-04-30 14:41:06 +08:00
Steve Underwood ba6457bbe9 Some more coverity issues cleaned up 2014-04-30 13:10:59 +08:00
Steve Underwood dac846cc7e Cleared some simple Coverity issues 2014-04-30 12:42:46 +08:00
Anthony Minessale 2cdae46b19 FS-6476 regression where sock would sometimes drop while reading logical frames 2014-04-29 18:25:05 -04:00
Anthony Minessale 61e22e8b50 FS-6476 --resolve 2014-04-22 23:25:41 +05:00
Michael Jerris ba6b9c5a11 ESL-91: --resolve bigger buffer for args 2014-04-21 13:33:47 -04:00
Brian West 6e8729a159 OPENZAP-222 --resolve 2014-04-18 15:18:41 -05:00
Brian West bf093e9dc1 Dispatch will call you on register, and call you back if you hangup on next register 2014-04-17 20:35:57 -05:00
Brian West 8ce6198bf9 fix bug in dispatch 2014-04-17 20:19:39 -05:00
Anthony Minessale cbd20d8a05 update 2014-04-17 04:33:02 +05:00
Anthony Minessale bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
Peter Olsson 295964f0ec FS-6457 --resolve
Upgrade to OpenSSL 1.0.1g in Windows build (Visual Studio 2010 and 2012)
2014-04-13 10:01:17 +02:00
Peter Olsson c915139a00 Make sure to copy pcre.h to library path, when building Win32/Debug in VS2012. 2014-04-11 16:35:19 +02:00
Travis Cross f754057c2a Avoid crash on event without content-type
If we received an event without a content-type header we were
dereferencing a null pointer leading to a seg fault.

Reported-by: Ico <ico@voip-io.org>

ESL-90 --resolve
2014-04-09 01:20:07 +00:00
Travis Cross c6acddf928 Fix typo in comment 2014-04-08 23:17:12 +00:00
Anthony Minessale 53c77f8434 force srtp rebuild 2014-04-09 03:14:52 +05:00
Dmitry Sobinov 80e203442a - fixed read of memory out of 'seq' variable bounds
- fixed AEAD IV calculation for big-endian machines
2014-04-08 16:13:52 +00:00
jfigus a31491d5b6 This commit resolves issue #46. The GCM mode was using the wrong master SALT length. The master SALT should be 96 bits instead of 112 bits. Note, GCM mode uses the legacy CTR mode for the KDF. The legagacy CTR mode cipher implementations assume a 112 bit SALT. Changes to the cipher abstraction layer API are required to provide the ability to specify the SALT length. For now this commit modifies the SRTP layer to ensure the SALT is zero-appended before initializing the KDF. This commit also provides public definitions for the GCM cipher suite master key sizes to avoid confusion for application developers. 2014-04-08 15:25:39 +00:00
Brian West 7bc92a11af ESL-89: fix install path and single_command require 2014-04-07 15:26:13 -05:00
Michael Jerris d6fa81b4b7 ESL-89: --resolve add rubymod-install and add ability to use a ruby not in your path by setting RUBY env var 2014-04-07 15:27:30 -04:00
Travis Cross fb7fa3d66a Update gitignore 2014-04-05 07:57:05 +00:00
Anthony Minessale 01254eaa5c force sofia rebuild 2014-04-04 13:42:49 -05:00
Anthony Minessale 180282cd9a FS-6287 2014-04-04 13:42:13 -05:00
Anthony Minessale 7ea4acaece FS-6426 --resolve 2014-04-03 23:25:48 +05:00
Anthony Minessale 7151d6acea FS-6402 part 2 2014-04-02 03:21:37 +05:00
Anthony Minessale 5c0cff70b3 FS-6402 --resolve 2014-04-02 01:20:19 +05:00
Michael Jerris f50f04be51 FS-6356: --resolve fix assert when you set the time > 15 days in the future during operation while things are in queue to be processeed 2014-03-28 14:33:47 -04:00
Travis Cross 180d081be4 Use buffered printers in fs_cli
Now that all output should end in a newline, we don't need to play
tricks with getting certain escape codes out ahead of buffered output.

This updates what we tried to do in commit
991b83d23c.

This partially reverts commit
8056125077.
2014-03-28 00:01:33 +00:00
Travis Cross 11f4628cae Reenable the new EL_REFRESH mechanism 2014-03-27 23:09:06 +00:00
Travis Cross 59f80c9e4f Handle bodies not ending in newlines w/EL_REFRESH
The issue is that sofia siptrace output doesn't end each line with a
newline.  Instead it sends a separate newline afterward, which comes
in as a separate event body.  With the new EL_REFRESH code in effect
the line is being cleared after the siptrace output has been written
but before that next newline comes in.

With our own refresh code this doesn't happen because of slight
differences in where the stdio buffers get flushed compared to where
the output of clear_line() ends up.

This is a bit of a clumsy workaround.  But we'll fix it first, then
refactor.
2014-03-27 23:06:07 +00:00
Travis Cross 3bc51dfff9 Turn on the fancy fs_cli with a modern libedit
We turn ON the features with a newer libedit.

This fixes commit 4f54f912c3.
2014-03-27 17:35:35 +00:00
Travis Cross 4f54f912c3 Add back terminal detection for old libedits
Using the system libedit means that libedit will again make absolute
movements on certain kinds of terminals.  Older versions of libedit
without EL_PROMPT_ESC miscalculate the length of the prompt.
Combined, this results in the cursor ending up in the wrong place.

We knew this was a possibility when we moved to system libedit, and
we're OK with it.  We certainly lived without this fancy prompt
feature for a long time.

This change puts back in place detection of the terminal type when
EL_PROMPT_ESC isn't available.  On these older versions of libedit,
we'll only enable the fancy features when we know that libedit will
only make relative movements and not tickle the bug.

This partially reverts commit:
b9b77bd615
2014-03-27 17:19:55 +00:00
Travis Cross dc093d179e Drop use of libedit EL_REFRESH in fs_cli for now
Newer versions of libedit provide an EL_REFRESH mechanism for
redrawing the prompt.  We had previously written our own code to
handle this.  In theory handing this over to libedit should be better.

Unfortunately when using EL_REFRESH the output of sofia siptrace isn't
showing up.  We're working on that, but for now we're just force own
our redrawing code to be used instead.
2014-03-27 12:20:43 +00:00
Travis Cross f9d065cda3 Use system libyaml for mod_yaml
FS-353
2014-03-26 19:27:22 +00:00
Ico fa17059787 Fix memory leak when outbound socket is closed by server
ESL-88 --resolve

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-26 01:36:48 +00:00
Jeff Lenk 4dd0a5848f FS-6293 windows duh 2014-03-24 18:45:05 -05:00
Jeff Lenk 07438df263 FS-6293 fix windows build from version.h being added to xmlrpc 2014-03-24 18:09:07 -05:00
Brian West c7bd862e9a FS:353: correct #if check for libedit function capability 2014-03-24 16:18:03 -05:00
Travis Cross cde20f6fe6 Require sqlite as a system dependency
This purges sqlite from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-24 12:54:49 +00:00
James Le Cuirot 8574988c3a Completely unbundle libedit
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-24 12:39:59 +00:00
Jeff Lenk f4abf3dab4 FS-6397 --resolve 2014-03-23 14:28:42 -06:00
Peter Olsson 7e1b32c0c2 .gitignore 2014-03-23 10:02:35 +01:00
Jeff Lenk 741cb889d9 FS-6349 --resolve 2014-03-22 22:59:32 -05:00
Peter Olsson e96e402981 .gitignore 2014-03-22 09:14:55 +01:00
Brian West 719d37dbf8 first 1/2 of automake for esl phpmod 2014-03-21 16:01:35 -05:00
Brian West 4e734db296 we need to do these in subdirectories because a number of the modules build a different ESL.so 2014-03-21 15:45:40 -05:00
Brian West 91d308dfac fully automake esl perlmod 2014-03-21 15:34:52 -05:00
Brian West 8b76b88f6d add #! 2014-03-21 15:33:38 -05:00
Brian West c8c3fbe749 don't install test programs 2014-03-21 15:33:18 -05:00
Brian West 77eca8d044 fix typo 2014-03-21 15:08:32 -05:00
Brian West 5014b80d53 1/2 of automake for esl perl, at least we have configure detecting things now 2014-03-21 14:59:01 -05:00
Brian West 94051688c2 reswig 2014-03-21 14:57:13 -05:00
Ken Rice 7f383ccc19 clean up esl module makefile by MikeJ 2014-03-21 12:59:55 -05:00
Brian West 74ab9515a4 FS-6294 DragonFly requires this also. 2014-03-21 11:14:15 -05:00
Travis Cross 1470622292 Require libcurl as a system dependency
This purges libcurl from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-20 21:15:29 +00:00
Peter Olsson 5d22a414ca .gitignore 2014-03-20 19:45:51 +01:00
James Le Cuirot b283db6319 Completely unbundle speex
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-20 15:28:25 +00:00
James Le Cuirot e85f06ee2f Completely unbundle pcre
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-20 15:28:23 +00:00
Michael Jerris 3ec53f0b67 ESL-86: esl automake of at least the core parts 2014-03-20 10:38:47 -04:00
Brian West 16577339be FS-6387 don't fail if your openssl package has been compiled without EC support...LOOKING AT YOU GENTOO 2014-03-20 08:07:53 -05:00
Brian West eade217fe7 Tweak sndfile for args 2014-03-19 17:37:02 +00:00
Brian West c4c0f38aab FS-6294 FS-6308 NetBSD support should work test and report back please. 2014-03-19 14:34:07 -05:00
Brian West b8f1a1779f Support Intel ICC 2014-03-19 14:34:07 -05:00
Michael Jerris ad28998235 FS-6293: unimrcp srcdir build working 2014-03-19 15:04:41 -04:00
Michael Jerris bda9a55d75 FS-6293: unimrcp start of srcdir build 2014-03-19 14:50:39 -04:00
Michael Jerris 57528ff3bf silence unused var warnings 2014-03-19 14:17:09 -04:00
Brian West eadfef1173 FS-6375 fix till we switch to system tiff 2014-03-19 12:32:23 +00:00
Brian West 9a94235f82 FS-6379: --resolve fix ldns bootstrap/build on solaris 2014-03-19 11:13:51 +00:00
Brian West d7abe52384 FS-6309 don't try to use incomplete tgmath.h on NetBSD 2014-03-19 03:35:47 -05:00
Brian West c210510c15 FS-6375 bump sofia so it rebuilds 2014-03-18 17:44:05 -05:00
Brian West f6d9027282 FS-6375 ifdef for sun in this case 2014-03-18 17:43:46 -05:00
Michael Jerris e63140a4d3 FS-6293: fix mod_codec2 srcdir build 2014-03-18 17:19:40 -04:00
Michael Jerris d4b3faadc8 remove file listed twice 2014-03-18 14:07:04 -04:00
Michael Jerris c4d0c3e092 .gitignore 2014-03-18 13:17:11 -04:00
Michael Jerris af192a2e8b FS-6293: abandon xmlrpc-c build system entirely. We can revist this when we try to pull this lib out of tree, in the mean time, this fixes a ton of problems. 2014-03-18 09:50:12 -04:00
Peter Olsson d908c5d8af Ignore downloaded speex library files. 2014-03-18 07:40:39 +01:00
Peter Olsson 9987546c58 mod_v8: More improvements for VS Express. 2014-03-18 07:38:44 +01:00
Jeff Lenk 89125e840c FS-6348 2014-03-18 00:24:31 -05:00
Jeff Lenk cf572696c1 FS-6348 --resolve 2014-03-17 23:28:57 -05:00
Jeff Lenk 1f39086534 FS-6348 part1 2014-03-17 22:27:29 -05:00
Brian West e9a2d17f1f FS-6368 --resolve include signal.h in ivrd.c 2014-03-17 20:24:28 -05:00
Anthony Minessale 240f5d984f force sofia rebuild 2014-03-17 16:18:24 -05:00
Anthony Minessale bd1492e43e FS-6287 --resolve 2014-03-17 16:16:42 -05:00
Anthony Minessale 1d28639cac revert revert 2014-03-17 16:15:59 -05:00
Brian West be1efcc1fa Revert 6e818216e2, from FS-6287 as it breaks challenge to invites we don't come back and respond 2014-03-17 15:03:08 -05:00
Michael Jerris 340b697e1b FS-6341: --resolve add 3pcc invite w/o sdp support for 100rel/PRACK 2014-03-17 12:27:42 -04:00
Michael Jerris d45bf87411 FS-6293: we need this for srcdir for xmlrpc-c 2014-03-17 10:57:18 -04:00
Michael Jerris 1c5e61447b move libs/stfu into the core, as it is not really a lib 2014-03-17 09:44:14 -04:00
Michael Jerris a9799f3dae FS-6293: fix mod_silk srcdir build 2014-03-17 08:32:17 -04:00
Travis Cross 19fc943f59 Mitigate the CRIME TLS flaw
If an attacker can cause a device to make an authenticated request to
a service via TLS while including a payload of the attacker's choice
in that request, and if TLS compression is enabled, the attacker can
uncover the plaintext authentication information by making a series of
guesses and observing changes in the length of the ciphertext.

This is CVE-2012-4929.

FS-6360 --resolve

Thanks-to: Brian West <brian@freeswitch.org>
2014-03-16 16:24:58 +00:00
Peter Olsson 2b651b9abe mod_v8: Try to make V8 build work on Visual Studio Express (devenv.exe is not available in Express) 2014-03-16 10:02:35 +01:00
Peter Olsson 54d13850b7 FS-6347 Make PCRE chartables dependent of PCRE download, to make sure build works the first time 2014-03-16 10:01:18 +01:00
Peter Olsson 8728d918a7 Ignore directories for downloaded libraries curl and pcre 2014-03-16 10:00:04 +01:00
Jeff Lenk e47c318aab windows curl remove header refs 2014-03-16 00:17:51 -05:00
Jeff Lenk df9256d09c FS-6347 update windows build to use downloaded pcre 2014-03-15 23:35:30 -05:00
Michael Jerris 048ce8d1f3 FS-6293: srcdir builds, most of the built in mods work now 2014-03-14 23:13:34 -04:00
Michael Jerris 4216e3e056 remove DYNAMIC_LIB_EXTEN because we use libtool to figure this all out now 2014-03-14 18:04:07 -04:00
Anthony Minessale 6a1d552430 force sofia update 2014-03-14 12:27:25 -05:00
Anthony Minessale 6e818216e2 FS-6287 --resolve When a broken registrar sends a 401 unauth then replies with a subsequent 401 unauth without the stale=true attribute, sofia tries to invalidate the auth handle and get stuck in a state where it cannot recover until the reg handle is destroyed. In this case, the provider in question has a bug on thier end when the nonce count rolls from nc=000000ff to nc=00000100 they start sending several consecitive 401 rather than a 401 with stale=true or a 403. This change will allow it to reset properly and try again with nc=00000001 on the next try. 2014-03-14 12:25:48 -05:00
Anthony Minessale 430b8fca6b FS-6211 more changes 2014-03-13 13:00:10 -05:00
Anthony Minessale 47a7ef557a FS-6211 thread priority in the apr for windows 2014-03-13 22:53:45 +05:00
Jeff Lenk 88fda8cbf2 FS-6346 --resolve 2014-03-13 09:13:30 -05:00
Jeff Lenk de8d92d9ce FS-6346 part 1 2014-03-12 23:49:14 -05:00
Anthony Minessale 9fd30a2cd9 FS-6339 --resolve 2014-03-11 18:16:23 -05:00
Ken Rice 6a7805ba27 add a few more generated files to .gitignore 2014-03-10 09:07:41 -05:00
Michael Jerris 27a3682dc0 put this back for now to test 2014-03-09 14:46:06 -04:00
Michael Jerris 15b76f8ee8 fix typo 2014-03-09 14:15:16 -04:00
Anthony Minessale 804ef7709d change from sqlite hash to newly added one 2014-03-09 00:37:17 +05:00
Brian West 42b74ba62e remove generated file from git 2014-03-08 08:51:58 -06:00
Michael Jerris 2f289d2522 fix autoconf syntax 2014-03-07 20:05:50 -05:00
Jeff Lenk 47f1219e29 fix windows build for last set of commits 2014-03-07 19:02:18 -06:00
Michael Jerris 4d7350f3d5 fix autoconf syntax 2014-03-07 19:55:57 -05:00
Michael Jerris 9a1948e959 autoconf syntax error 2014-03-07 19:35:51 -05:00
Michael Jerris 90fbc6231d fix autoconf syntax 2014-03-07 19:26:17 -05:00
Michael Jerris 163617c711 fix autoconf syntax issue 2014-03-07 19:19:53 -05:00
Michael Jerris 2513388d8a clean up some bootstrap warnings 2014-03-07 18:36:26 -05:00
Michael Jerris bcd9f49fbe move applications to use automake 2014-03-07 18:36:12 -05:00
Anthony Minessale abb83e0b0e fix backwards subtraction 2014-03-07 06:34:57 +05:00
Anthony Minessale e9847afe22 feed all packets to jitterbuffer when enabled to absorb bursts and improve smoothing and delay protection 2014-03-07 02:48:56 +05:00
Travis Cross 2fdaa1c0e8 Fix use of out of scope declaration 2014-03-06 08:45:23 +00:00
Travis Cross 1990d10057 Reword the websocket TLS cipher list
This generates an identical list of cipher suites, but this commit
restates the cipher spec to be more similar to the way we state it
elsewhere.
2014-03-05 21:37:30 +00:00
Travis Cross 6a3dcc9e0f Drop null-auth suites from our default TLS cipher list
Previously we disallowed anonymous Diffie-Hellman, but there are other
kinds of null-authentication TLS suites.  In particular, disallowing
AECDH is important now that we support elliptic-curve Diffie-Hellman.
2014-03-05 21:37:30 +00:00
Anthony Minessale 4cf14bce50 FS-5814 2014-03-06 00:31:10 +05:00
Anthony Minessale fe2a4bfa53 FS-5814 2014-03-05 13:12:02 -06:00
Anthony Minessale 5dbdbda0e7 force sofia rebuild 2014-03-06 00:03:20 +05:00
Anthony Minessale 7cb91467e0 FS-5814 --resolve 2014-03-06 00:02:40 +05:00
Anthony Minessale 066de4b378 Port commit from gitorious copy of sofia-sip our code now differs but this issue would still be a concern for OS X
commit ee51fa4e2993ab71339e29691aec8b924c810c53
Author: Frode Isaksen <frode.isaksen@bewan.com>
Date:   Thu Aug 18 16:40:58 2011 +0300

    su: fix su_time() on 64-bit OS X

        The field tv_sec in struct timeval is 64bits instead of 32bits as in
	    su_time_t, so you cannot cast su_time_t to struct timeval.
2014-03-05 10:25:39 -06:00
Brian West 6ed4ad7e20 Pass down into esl the LDFLAGS, fixes finding libncurses on NetBSD too. 2014-03-05 06:21:53 -06:00
Brian West 039f28d136 We do not use the cpp lib so why compile it. 2014-03-05 06:19:43 -06:00
Brian West 49fe796dab These options aren't valid for apr-util configure
configure: WARNING: unrecognized options: --disable-shared, --with-pic
2014-03-05 06:18:40 -06:00
William King 138224d816 FS-6303 --resolve 2014-03-04 12:30:14 -08:00
Travis Cross d5760e0d6a Show TLS cipher suite selected in sofia debug
This shows the cipher name, TLS version, the number of cipher bits and
algorithm bits, and a description of the cipher in Sofia's debug
logging output on level 9.
2014-02-28 20:46:34 +00:00
Travis Cross 38fe0a99d3 Prevent sha1_init et al from being undefined
sha1_init, sha1_update, and sha1_final were ending up as undefined
symbols in libfreeswitch.so because of the inline declaration, which
caused us to blow up while linking the freeswitch executable.  Declare
these as static inline instead.
2014-02-28 18:33:32 +00:00
Travis Cross c011f9daff Remove binary executables in libs/srtp
These files were introduced in commit 72e2d183c1.
2014-02-28 18:33:32 +00:00
Anthony Minessale 55901ae0f1 FS-6168 --resolve 2014-02-28 23:30:42 +05:00
Travis Cross 45c4450046 Prevent sqlite from over-reading a structure
Our sqlite fork was reading past the end of the zP3 KeyInfo structure
here.  This was causing gcc and clang's address sanitization to alert.

FS-6279 --resolve

Thanks-to: Christopher Rienzo <chris@rienzo.net>
2014-02-27 23:19:43 +00:00
Brian West cc8bab7729 FS-6276 move our include first so that ours is used and not the system if its present 2014-02-26 16:21:48 -06:00
Michael Jerris d6c20d4dce FS-6015: --resolve sqlite cross compile fixes 2014-02-25 14:26:55 -05:00
Seven Du 4fd93b0e67 Revert "fix compiler warning vs2010" - Jeff is faster than I
This reverts commit fa9217117a.
2014-02-25 14:24:34 +08:00
Seven Du fa9217117a fix compiler warning vs2010 2014-02-25 14:17:28 +08:00
Jeff Lenk 4a1f8785e4 mask warnings libsrtp windows 32bit 2014-02-24 22:42:16 -06:00
Jeff Lenk 99ab915f24 windows update libsrtp to use openssl 2014-02-24 20:13:12 -06:00
Marc Olivier Chouinard 3d53825d1d FS-6016 --resolve 2014-02-24 21:00:33 -05:00
Moises Silva 461f94870f Merge remote-tracking branch 'origin/master' into moy/tport-log-fix 2014-02-24 19:39:17 -05:00