From b324e2633a122f19033fb41a7bd44f34a18840fc Mon Sep 17 00:00:00 2001 From: Michael Jerris Date: Mon, 17 Mar 2014 14:33:08 -0400 Subject: [PATCH] use AM_SILENT_RULES where available and remove our hacks for quiet builds as they don't work very well and cause other build problems --- Makefile.am | 5 +---- build/modmake.rulesam | 7 ------- configure.ac | 2 +- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/Makefile.am b/Makefile.am index 698553787e..6540cbc793 100644 --- a/Makefile.am +++ b/Makefile.am @@ -316,7 +316,7 @@ if ENABLE_CPP libfreeswitch_la_SOURCES += src/switch_cpp.cpp endif -$(libfreeswitch_la_SOURCES): $(CORE_LIBS) $(switch_builddir)/quiet_libtool $(switch_builddir)/modules.conf +$(libfreeswitch_la_SOURCES): $(CORE_LIBS) $(switch_builddir)/modules.conf src/include/switch_swigable_cpp.h: $(switch_srcdir)/src/include/switch_cpp.h cat $(switch_srcdir)/src/include/switch_cpp.h | perl $(switch_srcdir)/build/strip.pl > $(switch_srcdir)/src/include/switch_swigable_cpp.h @@ -439,9 +439,6 @@ $(OUR_MODULES): $(switch_builddir)/modules.conf libfreeswitch.la || case "$$amf" in *=*) exit 1;; *k*) fail=yes;; *) exit 1;; esac; \ test -z "$$fail" -$(switch_builddir)/quiet_libtool: $(switch_builddir)/libtool - @cat libtool | sed -e 's|$$show "$$command"|if test -z "$$suppress_output" ; then $$show "Compiling $$srcfile ..." ; fi|' > $(switch_builddir)/quiet_libtool - build/print_git_revision: build/print_git_revision.c $(CC) -o $@ $< diff --git a/build/modmake.rulesam b/build/modmake.rulesam index 386fd41e06..bffa0db4ac 100644 --- a/build/modmake.rulesam +++ b/build/modmake.rulesam @@ -5,13 +5,6 @@ AM_LDFLAGS = $(SWITCH_AM_LDFLAGS) DEFAULT_VARS = CFLAGS="$(CFLAGS)" CPPFLAGS="$(CXXFLAGS)" LDFLAGS="$(LDFLAGS)" CC="$(CC)" CXX="$(CXX)" DEFAULT_ARGS = --build=$(build) --host=$(host) --target=$(target) --prefix="$(prefix)" --exec_prefix="$(exec_prefix)" --libdir="$(libdir)" --disable-shared --with-pic -#we should set all these vars from configure, no reason to have these in each Makefile.am -LIBTOOL = echo "`link=\`echo $@|grep .la;echo $@|grep .so;echo $@|grep .dll\`;if test -n "$$link"; then echo Creating $@;fi`";`if test -z "$(VERBOSE)" ; \ -then echo $(SHELL) $(switch_builddir)/quiet_libtool ;else echo $(SHELL) $(switch_builddir)/libtool; fi` -AM_MAKEFLAGS=`test -n "$(VERBOSE)" || echo -s` -# Dirty trick to override the link output -LIBS+=> $(MODNAME).log || error="yes";if test -n "$(VERBOSE)" -o "$$error" = "yes";then cat $(MODNAME).log;fi;if test "$$error" = "yes";then exit 1;fi - moddir=@modulesdir@ all-modules: all diff --git a/configure.ac b/configure.ac index 80841b1185..666ef08398 100644 --- a/configure.ac +++ b/configure.ac @@ -14,6 +14,7 @@ AC_CONFIG_FILES([src/include/switch_version.h.in:src/include/switch_version.h.te AC_CONFIG_AUX_DIR(build/config) AM_INIT_AUTOMAKE +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) AC_CONFIG_SRCDIR([src/switch.c]) AC_CONFIG_HEADER([src/include/switch_private.h]) AC_CONFIG_HEADER([libs/xmlrpc-c/xmlrpc_amconfig.h]) @@ -1391,7 +1392,6 @@ AM_CONDITIONAL(HAVE_G729, [ test -d ${switch_srcdir}/libs/libg729 ]) #some vars to sub into the Makefile.am's #LIBS+=> core.log || error="yes";if test -n "$(VERBOSE)" -o "$$error" = "yes";then cat core.log;fi;if test "$$error" = "yes";then exit 1;fi -LIBTOOL='`if test -z "$(VERBOSE)" ; then echo $(SHELL) $(switch_builddir)/quiet_libtool ;else echo $(switch_builddir)/libtool; fi;`' TOUCH_TARGET='if test -f "$@";then touch "$@";fi;' CONF_MODULES='$$(grep -v "\#" $(switch_builddir)/modules.conf | sed -e "s|^.*/||" | sort | uniq )' CONF_DISABLED_MODULES='$$(grep "\#" $(switch_builddir)/modules.conf | grep -v "\#\#" | sed -e "s|^.*/||" | sort | uniq )'