retronetworking
/
freeswitch
13
0
Fork 0
Code Pull Requests Releases Activity

Merge pull request #1811 in FS/freeswitch from bugfix/FS-12040-mod_sofia-fix-potential-leak-if-realloc-fails to master 

* commit '7ee53a6ec1753204d5f17e1f7d2b9429b8ab1342':
  FS-12040: [mod_sofia] Fix potential leak if realloc fails.
This commit is contained in:
Christopher Rienzo 2019-09-06 09:37:37 -05:00
parent 468e2e06d1 7ee53a6ec1
commit 8880c4f469
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mod/endpoints/mod_sofia/sofia.c
View File

@ -821,8 +821,13 @@ void sofia_handle_sip_i_notify(switch_core_session_t *session, int status,
while ((call_info = call_info->ci_next) != NULL) {
char *tmp = sip_header_as_string(nua_handle_home(nh), (void *) call_info);
size_t tmp_len = strlen(tmp);
hold = realloc(hold, cur_len + tmp_len + 2);
switch_assert(hold);
char *tmp_hold = realloc(hold, cur_len + tmp_len + 2);
if (!tmp_hold) {
/* Avoid leak if realloc failed */
free(hold);
}
switch_assert(tmp_hold);
hold = tmp_hold;
strncpy(hold + cur_len, ",", 2);
strncpy(hold + cur_len + 1, tmp, tmp_len +1);
su_free(nua_handle_home(nh), tmp);