75 lines
2.4 KiB
Plaintext
75 lines
2.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ccf819e0_e3dc3bce",
|
|
"filename": "src/host/trxcon/src/trxcon_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 453,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-01-31T10:45:35Z",
|
|
"side": 1,
|
|
"message": "you are missing calling \"continue;\" here if error is returned.",
|
|
"revId": "4052c00efba2dd05a3bd5332fcc2b079747c09d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7f8ca305_51789386",
|
|
"filename": "src/host/trxcon/src/trxcon_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 453,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-01-31T11:06:25Z",
|
|
"side": 1,
|
|
"message": "I think a better idea would be to validate AMR params before trying to apply them here. Otherwise we set lchan-\u003etch_mode above, fail to apply the AMR params and thus do not set req-\u003eapplied, which is weird.",
|
|
"parentUuid": "ccf819e0_e3dc3bce",
|
|
"revId": "4052c00efba2dd05a3bd5332fcc2b079747c09d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "dbc93846_5e8450ca",
|
|
"filename": "src/host/trxcon/src/trxcon_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 453,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-01-31T11:08:12Z",
|
|
"side": 1,
|
|
"message": "Checking codecs_bitmask !\u003d 0 should be enough.\nSome additional checks e.g. number of bits set \u003c\u003d 4 can be added too.",
|
|
"parentUuid": "7f8ca305_51789386",
|
|
"revId": "4052c00efba2dd05a3bd5332fcc2b079747c09d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9aa60d0f_004ca7b3",
|
|
"filename": "src/host/trxcon/src/trxcon_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 453,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-01-31T11:08:27Z",
|
|
"side": 1,
|
|
"message": "whatever, what I mean is that you are changing the behavior here silently, marking stuff as applied which wasn\u0027t before.",
|
|
"parentUuid": "7f8ca305_51789386",
|
|
"revId": "4052c00efba2dd05a3bd5332fcc2b079747c09d1",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |