57 lines
1.9 KiB
Plaintext
57 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "387baa10_30fe0d34",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-02-05T18:09:41Z",
|
|
"side": 1,
|
|
"message": "You may have a race condition between dropping rx valid data and signalling data transfer started here? In a voice call you don\u0027t care much, but probably in here you drop valid data?\nI\u0027m not sure about all this, just sharing in case it makes sense.",
|
|
"revId": "40b0a9094e75edb521476fdd5510a214727768a7",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b24815ba_528af712",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2024-02-05T20:11:41Z",
|
|
"side": 1,
|
|
"message": "I do not understand what you mean here, sorry.",
|
|
"parentUuid": "387baa10_30fe0d34",
|
|
"revId": "40b0a9094e75edb521476fdd5510a214727768a7",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "744874c0_04519b45",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-02-05T20:14:03Z",
|
|
"side": 1,
|
|
"message": "WI mean if the data you receive while the call is not fully connected can actually contain meaningful data/bytes which you should not be dropping.\n\nThe CC CONNECTED signal comes out of band from the channel afaiu, so there\u0027s no real synch point on where the data actually starts?",
|
|
"parentUuid": "b24815ba_528af712",
|
|
"revId": "40b0a9094e75edb521476fdd5510a214727768a7",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |