osmocom-bb/892d7a52bcfc73b1bf3b46593c439a910ad7b014

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "84c5a562_2fab7605",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2024-02-02T12:05:49Z",
      "side": 1,
      "message": "We are still missing selectively sending the conf, aka in .req saying needs_conf\u003dtrue.",
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "66a16737_2e382c0f",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1000231
      },
      "writtenOn": "2024-02-05T12:58:36Z",
      "side": 1,
      "message": "What happens to lchan-\u003eprim, if bid is not 3?",
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "ed281b48_d6ae02d1",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1000231
      },
      "writtenOn": "2024-02-05T13:01:38Z",
      "side": 1,
      "message": "Oops, wrong location for this comment.",
      "parentUuid": "66a16737_2e382c0f",
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c5a6b507_55d351ff",
        "filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
        "patchSetId": 1
      },
      "lineNbr": 164,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-02-05T13:05:33Z",
      "side": 1,
      "message": "I will add an `ASSERT` to make sure `lchan-\u003eprim` is NULL here.",
      "range": {
        "startLine": 164,
        "startChar": 1,
        "endLine": 164,
        "endChar": 18
      },
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "fd640353_2bd1f435",
        "filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
        "patchSetId": 1
      },
      "lineNbr": 164,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-02-05T14:43:00Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "c5a6b507_55d351ff",
      "range": {
        "startLine": 164,
        "startChar": 1,
        "endLine": 164,
        "endChar": 18
      },
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6d956dbd_1ecf9ec8",
        "filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
        "patchSetId": 1
      },
      "lineNbr": 191,
      "author": {
        "id": 1000231
      },
      "writtenOn": "2024-02-05T13:01:38Z",
      "side": 1,
      "message": "What happens to lchan-\u003eprim, if bid is not 3?",
      "range": {
        "startLine": 191,
        "startChar": 1,
        "endLine": 191,
        "endChar": 2
      },
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4d8458da_dc9c81e3",
        "filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
        "patchSetId": 1
      },
      "lineNbr": 191,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-02-05T13:05:33Z",
      "side": 1,
      "message": "`lchan-\u003eprim` should remain allocated and assigned until `bid \u003d\u003d 3` (4th burst) - this is when we want to confirm sending UL BLOCK.req to the upper layers, because burst timing matters.",
      "parentUuid": "6d956dbd_1ecf9ec8",
      "range": {
        "startLine": 191,
        "startChar": 1,
        "endLine": 191,
        "endChar": 2
      },
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "36334cb9_19f1eed4",
        "filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
        "patchSetId": 1
      },
      "lineNbr": 191,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2024-02-05T14:43:00Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "4d8458da_dc9c81e3",
      "range": {
        "startLine": 191,
        "startChar": 1,
        "endLine": 191,
        "endChar": 2
      },
      "revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}