{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "47506186_d27c1bcf",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2023-01-30T19:56:15Z",
      "side": 1,
      "message": "The \u0027gsmtap\u0027 prefix in each command looks redundant to me, given that they all belong to \u0027gsmtap\u0027 node.",
      "range": {
        "startLine": 13,
        "startChar": 1,
        "endLine": 13,
        "endChar": 7
      },
      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3ae97f48_a444eef3",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2023-01-30T20:01:33Z",
      "side": 1,
      "message": "I still prefer the way it looks this way, the commands are more self descriptive and easy to match in other apps too.",
      "parentUuid": "47506186_d27c1bcf",
      "range": {
        "startLine": 13,
        "startChar": 1,
        "endLine": 13,
        "endChar": 7
      },
      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7707255a_df939daf",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2023-01-30T20:04:56Z",
      "side": 1,
      "message": "But there is no dedicated \u0027gsmtap\u0027 node in other apps, so it already does not match. The command style in both osmo-bts (gsmtap-sapi) and osmo-pcu (gsmtap-category) does not match either, you\u0027re just mixing them up here.",
      "parentUuid": "3ae97f48_a444eef3",
      "range": {
        "startLine": 13,
        "startChar": 1,
        "endLine": 13,
        "endChar": 7
      },
      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5f13da34_ed918a95",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 26,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2023-01-30T20:02:26Z",
      "side": 1,
      "message": "I don\u0027t like the inconsistency between \u0027gsmtap-sapi\u0027 and \u0027gsmtap-category\u0027. My proposal:\n\n  gsmtap\n    remote-host HOST\n    lchan (bcch|ccch|rach|agch|...)\n    lchan (enable-all|disable-all)\n    pchan pdch (dl-dummy|dl-ctrl|...)\n    pchan pdch (enable-all|disable-all)",
      "range": {
        "startLine": 26,
        "startChar": 1,
        "endLine": 26,
        "endChar": 16
      },
      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f147e573_6bd89028",
        "filename": "src/host/layer23/include/osmocom/bb/common/l23_app.h",
        "patchSetId": 2
      },
      "lineNbr": 19,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2023-01-30T19:56:15Z",
      "side": 1,
      "message": "BTS?",
      "range": {
        "startLine": 19,
        "startChar": 7,
        "endLine": 19,
        "endChar": 10
      },
      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c7ee473c_79a94526",
        "filename": "src/host/layer23/include/osmocom/bb/common/l23_app.h",
        "patchSetId": 2
      },
      "lineNbr": 19,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2023-01-30T20:01:33Z",
      "side": 1,
      "message": "Ack, I\u0027ll fix",
      "parentUuid": "f147e573_6bd89028",
      "range": {
        "startLine": 19,
        "startChar": 7,
        "endLine": 19,
        "endChar": 10
      },
      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}