From edb57e7d6a37b6180d12430ccfbf542f6c5e09fb Mon Sep 17 00:00:00 2001 From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Date: Tue, 31 Jan 2023 11:04:41 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (2 comments) Patch-set: 2 --- 4f36345180c9556086ef8fd4f3d0bd22af9d2abd | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/4f36345180c9556086ef8fd4f3d0bd22af9d2abd b/4f36345180c9556086ef8fd4f3d0bd22af9d2abd index e7dd080be..d8389246b 100644 --- a/4f36345180c9556086ef8fd4f3d0bd22af9d2abd +++ b/4f36345180c9556086ef8fd4f3d0bd22af9d2abd @@ -71,6 +71,30 @@ "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": true, + "key": { + "uuid": "c88183a4_f02fdff1", + "filename": "/COMMIT_MSG", + "patchSetId": 2 + }, + "lineNbr": 13, + "author": { + "id": 1000074 + }, + "writtenOn": "2023-01-31T11:04:41Z", + "side": 1, + "message": "I\u0027m not mixing them here, I\u0027m establishing 2 layers of granularity. First based on lchan, and then further specify in the lchan which kind of messages we want (this is important in gprs because there may be lots of DUMMY messages).", + "parentUuid": "7707255a_df939daf", + "range": { + "startLine": 13, + "startChar": 1, + "endLine": 13, + "endChar": 7 + }, + "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -94,6 +118,30 @@ "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": true, + "key": { + "uuid": "86c174e5_70ce782d", + "filename": "/COMMIT_MSG", + "patchSetId": 2 + }, + "lineNbr": 26, + "author": { + "id": 1000074 + }, + "writtenOn": "2023-01-31T11:04:41Z", + "side": 1, + "message": "I\u0027m not really liking this proposal, it differs too much from separations done in other apps.", + "parentUuid": "5f13da34_ed918a95", + "range": { + "startLine": 26, + "startChar": 1, + "endLine": 26, + "endChar": 16 + }, + "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": {