phone-side
/
osmocom-bb
mirror of https://gerrit.osmocom.org/osmocom-bb
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000231 \u003c1000231@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010 2024-02-05 13:05:33 +00:00 committed by Gerrit Code Review
parent b9d747e562
commit df88fe2ea4
1 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
892d7a52bcfc73b1bf3b46593c439a910ad7b014
View File

@ -52,6 +52,29 @@
"revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "c5a6b507_55d351ff",
"filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
"patchSetId": 1
},
"lineNbr": 164,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-05T13:05:33Z",
"side": 1,
"message": "I will add an `ASSERT` to make sure `lchan-\u003eprim` is NULL here.",
"range": {
"startLine": 164,
"startChar": 1,
"endLine": 164,
"endChar": 18
},
"revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -74,6 +97,30 @@
},
"revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4d8458da_dc9c81e3",
"filename": "src/host/trxcon/src/sched_lchan_pdtch.c",
"patchSetId": 1
},
"lineNbr": 191,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-05T13:05:33Z",
"side": 1,
"message": "`lchan-\u003eprim` should remain allocated and assigned until `bid \u003d\u003d 3` (4th burst) - this is when we want to confirm sending UL BLOCK.req to the upper layers, because burst timing matters.",
"parentUuid": "6d956dbd_1ecf9ec8",
"range": {
"startLine": 191,
"startChar": 1,
"endLine": 191,
"endChar": 2
},
"revId": "892d7a52bcfc73b1bf3b46593c439a910ad7b014",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}