From d7cc89357004b21da7793c9918c7cdb1ef82d1cb Mon Sep 17 00:00:00 2001
From: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Date: Tue, 31 Jan 2023 11:37:04 +0000
Subject: [PATCH] Update patch set 3

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"fixeria replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"fixeria replied on the change"}
---
 32266a9ad3384e0792f4e4fd662a00ad2cc2be79 | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/32266a9ad3384e0792f4e4fd662a00ad2cc2be79 b/32266a9ad3384e0792f4e4fd662a00ad2cc2be79
index a7ccf0fb8..283968e2b 100644
--- a/32266a9ad3384e0792f4e4fd662a00ad2cc2be79
+++ b/32266a9ad3384e0792f4e4fd662a00ad2cc2be79
@@ -1,5 +1,28 @@
 {
   "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f90af13e_f22ce9ad",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 3
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-01-31T11:37:04Z",
+      "side": 1,
+      "message": "Question: if I have \u0027gsmtap-sapi pdtch\u0027 in my config file, does this enable all GPRS categories? Similarly, if I do \u0027no gsmtap-sapi pdtch\u0027 and then \u0027gsmtap-category gprs dl-ctrl\u0027, will I see only the dl-ctrl messages or nothing? Oh, there is also \u0027pacch\u0027...\n\nHere is another proposal, hopefully making all my questions above void:\n\n  gsmtap\n   ...\n   gsmtap-sapi tch/f\n   gsmtap-sapi tch/h\n   gsmtap-sapi pdch (enable-all|disable-all)\n   gsmtap-sapi pdch (dl-dummy|dl-ctrl|...)\n\nThis way it looks more logical to me, and somehow consistent.\n\nP.S. there is no SAPI in GSMTAP.\nP.P.S. This probably comes from osmo-bts-sysmo, where the L1 prims have SAPI field.",
+      "range": {
+        "startLine": 23,
+        "startChar": 1,
+        "endLine": 24,
+        "endChar": 18
+      },
+      "revId": "32266a9ad3384e0792f4e4fd662a00ad2cc2be79",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {