From d72dc337758672b63edaef051b4e0f1cd22027fb Mon Sep 17 00:00:00 2001
From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Date: Tue, 31 Jan 2023 12:04:19 +0000
Subject: [PATCH] Update patch set 4

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
---
 4f36345180c9556086ef8fd4f3d0bd22af9d2abd | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/4f36345180c9556086ef8fd4f3d0bd22af9d2abd b/4f36345180c9556086ef8fd4f3d0bd22af9d2abd
index fc0e3ffd4..c88bf4ad6 100644
--- a/4f36345180c9556086ef8fd4f3d0bd22af9d2abd
+++ b/4f36345180c9556086ef8fd4f3d0bd22af9d2abd
@@ -238,6 +238,30 @@
       "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "aff45344_a90148a2",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2023-01-31T12:04:19Z",
+      "side": 1,
+      "message": "There\u0027s several topics here:\n\n* \"sapi\" naming: I can rename this from \"gsmtap-sapi\" to \"gsm-channel\" or \"lchan\" as fixeria suggests, since indeed the \"sapi\" thing seems to come from l1 in sysmobts.\n\n* \"sapi\" vs \"category\":\nIt\u0027s not really CS vs PS we are discussing here. The idea is that this VTY config severes purpose for any layer23 app, which is both CS and PS. The idea here is that in general the \"sapi\" level (aka now \"lchan\", eg \"lchan pdtch\") serves the purpose of enabling/disabling gsmtap sending messages received/sent on that lchan.\n\nFor GPRS, we really want to have finer granularity on higher layer than simply enabling or disabling the entire lchan, and hence it is why we have an extra set of commands to enable/disable which type of messages are logged.\n\n\nSo MY PROPOSAL:\n- (I already updated the code using the enum/value_string from libosmcoore)\n- rename \"gsmtap-sapi\" to \"lchan\" and \"gsmtap-category\" to \"category gprs\". I don\u0027t like the idea of having \"category pdtch\" here because for instance for \"dl-unknown\" one doesn\u0027t really know whether it\u0027s PDTCH or PACCH. In fact the PACCH is all a bit blurry to me, having to check too many levels to find out whether it\u0027s PACCH vs PDTCH.",
+      "parentUuid": "f587d582_2af9ccc2",
+      "range": {
+        "startLine": 26,
+        "startChar": 1,
+        "endLine": 26,
+        "endChar": 16
+      },
+      "revId": "4f36345180c9556086ef8fd4f3d0bd22af9d2abd",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {