phone-side
/
osmocom-bb
mirror of https://gerrit.osmocom.org/osmocom-bb
9
0
Fork 0
Code Issues Releases Wiki Activity

mobile/sms: Simplify the string format routines 

It seems the original code didn't allocate \0 for the string. Just use
talloc_asprintf and get a new string...

Change-Id: I8ffb50b04d2d6196caf0231711f3467abc8c5ea5
This commit is contained in:
Holger Hans Peter Freyther 2018-06-02 11:14:51 +08:00
parent 61fe379446
commit a81c83fc2c
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/host/layer23/src/mobile/gsm411_sms.c
View File

@ -182,7 +182,6 @@ static int gsm340_rx_sms_deliver(struct osmocom_ms *ms, struct msgb *msg,
struct gsm_sms *gsms)
{
const char osmocomsms[] = ".osmocom/bb/sms.txt";
int len;
const char *home;
char *sms_file;
char vty_text[sizeof(gsms->text)], *p;
@ -206,11 +205,9 @@ fail:
"your home directory.\n", osmocomsms);
return GSM411_RP_CAUSE_MT_MEM_EXCEEDED;
}
len = strlen(home) + 1 + sizeof(osmocomsms);
sms_file = talloc_size(l23_ctx, len);
sms_file = talloc_asprintf(l23_ctx, "%s/%s", home, osmocomsms);
if (!sms_file)
goto fail;
snprintf(sms_file, len, "%s/%s", home, osmocomsms);
fp = fopen(sms_file, "a");
if (!fp) {