phone-side
/
osmocom-bb
mirror of https://gerrit.osmocom.org/osmocom-bb
9
0
Fork 0
Code Issues Releases Wiki Activity

common/l1ctl.c: fix: drop TCH frame length / magic check 

It was assumed that only FR frames (with magic 0xd) can be carried
by the L1CTL_TRAFFIC messages, but there are also EFR, HR, and AMR
frames, and dropping them is not a good idea.

Change-Id: I4b7b85d94f11deb7525b63f3549a182c6e76da08
This commit is contained in:
Vadim Yanitskiy 2018-05-12 03:05:50 +07:00
parent 3ff8807c9e
commit 8d093f5e29
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/host/layer23/src/common/l1ctl.c
View File

@ -826,20 +826,6 @@ int l1ctl_tx_traffic_req(struct osmocom_ms *ms, struct msgb *msg,
DEBUGP(DL1C, "TRAFFIC REQ (len=%zu): %s\n", frame_len,
osmo_hexdump(frame, frame_len));
if (frame_len != 33) {
LOGP(DL1C, LOGL_ERROR, "Traffic Request has incorrect length "
"(%u != 33)\n", frame_len);
msgb_free(msg);
return -EINVAL;
}
if ((frame[0] >> 4) != 0xd) {
LOGP(DL1C, LOGL_ERROR, "Traffic Request has incorrect magic "
"(%u != 0xd)\n", frame[0] >> 4);
msgb_free(msg);
return -EINVAL;
}
// printf("TX %s\n", osmo_hexdump(frame, frame_len));
/* prepend uplink info header */