From 759f532843e90b7141f1077366177b5db72cee42 Mon Sep 17 00:00:00 2001
From: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Date: Tue, 31 Jan 2023 11:06:25 +0000
Subject: [PATCH] Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"fixeria replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"fixeria replied on the change"}
---
 4052c00efba2dd05a3bd5332fcc2b079747c09d1 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/4052c00efba2dd05a3bd5332fcc2b079747c09d1 b/4052c00efba2dd05a3bd5332fcc2b079747c09d1
index 6c86b2694..8690a2c4a 100644
--- a/4052c00efba2dd05a3bd5332fcc2b079747c09d1
+++ b/4052c00efba2dd05a3bd5332fcc2b079747c09d1
@@ -16,6 +16,24 @@
       "message": "you are missing calling \"continue;\" here if error is returned.",
       "revId": "4052c00efba2dd05a3bd5332fcc2b079747c09d1",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "7f8ca305_51789386",
+        "filename": "src/host/trxcon/src/trxcon_fsm.c",
+        "patchSetId": 1
+      },
+      "lineNbr": 453,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-01-31T11:06:25Z",
+      "side": 1,
+      "message": "I think a better idea would be to validate AMR params before trying to apply them here. Otherwise we set lchan-\u003etch_mode above, fail to apply the AMR params and thus do not set req-\u003eapplied, which is weird.",
+      "parentUuid": "ccf819e0_e3dc3bce",
+      "revId": "4052c00efba2dd05a3bd5332fcc2b079747c09d1",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file