phone-side
/
osmocom-bb
mirror of https://gerrit.osmocom.org/osmocom-bb
9
0
Fork 0
Code Issues Releases Wiki Activity

mobile/gsm480_ss.c: use secure gsm_7bit_(en|de)code_n_ussd 

Since some 'gsm_7bit_*' functions were deprecated and replaced by
more secure ones with the '_n_' suffix in names, it's better to
use the updated functions.

Change-Id: If8a1983592f5800e3981f29962eb333ac9473f40
This commit is contained in:
Vadim Yanitskiy 2017-11-02 16:41:14 +07:00
parent 584cc7a26b
commit 37872f1032
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/host/layer23/src/mobile/gsm480_ss.c
View File

@ -532,7 +532,7 @@ static int gsm480_tx_ussd(struct gsm_trans *trans, uint8_t msg_type,
}
/* Encode service request */
length = gsm_7bit_encode(msg->data, text);
gsm_7bit_encode_n_ussd(msg->data, msgb_tailroom(msg), text, &length);
msgb_put(msg, length);
/* Then wrap it as an Octet String */
@ -772,11 +772,7 @@ static int gsm480_rx_ussd(struct gsm_trans *trans, const uint8_t *data,
return -EINVAL;
}
num_chars = tag_len * 8 / 7;
/* Prevent a mobile-originated buffer-overrun! */
if (num_chars > sizeof(text) - 1)
num_chars = sizeof(text) - 1;
text[sizeof(text) - 1] = '\0';
gsm_7bit_decode(text, tag_data, num_chars);
gsm_7bit_decode_n_ussd(text, sizeof(text), tag_data, num_chars);
for (i = 0; text[i]; i++) {
if (text[i] == '\r')