From 45ab1a6d81457dbbedaf24758978dcb725e8ca99 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander@aleksander.es>
Date: Wed, 4 Feb 2015 20:57:06 +0100
Subject: [PATCH] wds: last call TX/RX stats in 'Get Packet Statistics' don't
 have prerequisite

These values may be given along with a QMI error (e.g. out-of-call), so don't
assume that a success operation is a prerequisite to read them.

    [04 Feb 2015, 20:55:07] [Debug]   [/dev/cdc-wdm1] Received message...
    >>>>>> RAW:
    >>>>>>   length = 42
    >>>>>>   data   = 01:29:00:80:01:08:02:0D:00:24:00:1D:00:02:04:00:01:00:0F:00:1C:08:00:2B:17:00:00:00:00:00:00:1B:08:00:87:28:00:00:00:00:00:00

    [04 Feb 2015, 20:55:07] [Debug]   [/dev/cdc-wdm1] Received message (translated)...
    >>>>>> QMUX:
    >>>>>>   length  = 41
    >>>>>>   flags   = 0x80
    >>>>>>   service = "wds"
    >>>>>>   client  = 8
    >>>>>> QMI:
    >>>>>>   flags       = "response"
    >>>>>>   transaction = 13
    >>>>>>   tlv_length  = 29
    >>>>>>   message     = "Get Packet Statistics" (0x0024)
    >>>>>> TLV:
    >>>>>>   type       = "Result" (0x02)
    >>>>>>   length     = 4
    >>>>>>   value      = 01:00:0F:00
    >>>>>>   translated = FAILURE: OutOfCall
    >>>>>> TLV:
    >>>>>>   type       = "Last Call Rx Bytes Ok" (0x1c)
    >>>>>>   length     = 8
    >>>>>>   value      = 2B:17:00:00:00:00:00:00
    >>>>>>   translated = 5931
    >>>>>> TLV:
    >>>>>>   type       = "Last Call Tx Bytes Ok" (0x1b)
    >>>>>>   length     = 8
    >>>>>>   value      = 87:28:00:00:00:00:00:00
    >>>>>>   translated = 10375
---
 data/qmi-service-wds.json | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/data/qmi-service-wds.json b/data/qmi-service-wds.json
index be0a7e6..0629f7f 100644
--- a/data/qmi-service-wds.json
+++ b/data/qmi-service-wds.json
@@ -260,18 +260,17 @@
                      "type"          : "TLV",
                      "format"        : "guint64",
                      "prerequisites" : [ { "common-ref" : "Success" } ] },
+                   // Note: last call TX/RX given along with QMI Error 'out of call'
                    { "name"          : "Last Call Tx Bytes Ok",
                      "id"            : "0x1B",
                      "mandatory"     : "no",
                      "type"          : "TLV",
-                     "format"        : "guint64",
-                     "prerequisites" : [ { "common-ref" : "Success" } ] },
+                     "format"        : "guint64" },
                    { "name"          : "Last Call Rx Bytes Ok",
                      "id"            : "0x1C",
                      "mandatory"     : "no",
                      "type"          : "TLV",
-                     "format"        : "guint64",
-                     "prerequisites" : [ { "common-ref" : "Success" } ] },
+                     "format"        : "guint64" },
                    { "name"          : "Tx Packets Dropped",
                      "id"            : "0x1D",
                      "mandatory"     : "no",