osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui
History
Kevin Grigorenko 3b2954208a Add a "Sum" column to the Service Response Time (SRT) window. 
The Service Response Time (SRT) window currently provides the
columns: Index, Procedure, Calls, Min SRT, Max SRT, and Avg SRT.
A Sum column has been found useful in some customer situations
to understand the total time spent doing a set of procedures.
For example, in one case we were trying to isolate whether most
time was being spent on a client thread or in the act of making
outbound calls. We knew the start and end time of the client call,
so with the "Sum" of time spent in that period, we could isolate
a particular set of procedures driving the slow down.

Additional changes made in this patch:
* Add " (s)" to Min, Max, Avg, and Sum columns to make it clear
  that times are in seconds.
* Refactor out width and height constants used in calls to
  gtk_window_set_default_size in most of the SRT users into
  #define SRT_PREFERRED_WIDTH and SRT_PREFERRED_HEIGHT. Also
  increase the common width of 550 to 650 to account for the
  additional column.

Change-Id: I20f152eecbcd0bbf69f71c6c6b9f9463e8867e23
Reviewed-on: https://code.wireshark.org/review/7047
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2015-02-10 06:18:41 +00:00
..
cli Use G_GINT64_MODIFIER when formatting g{u}int64 values. 2015-02-09 19:32:54 +00:00
gtk Add a "Sum" column to the Service Response Time (SRT) window. 2015-02-10 06:18:41 +00:00
qt Don't call the Bluetooth code's UUID type "uuid_t". 2015-02-07 22:52:06 +00:00
win32 (Trivial) Fix printf-related 'Mismatch on sign' warnings 2015-02-09 18:57:14 +00:00
CMakeLists.txt Multicast Stream: Move mcast_stream.[ch] to ui 2015-02-08 22:22:33 +00:00
Makefile.am Support out-of-source checkapi 2014-04-25 04:23:46 +00:00
Makefile.common Multicast Stream: Move mcast_stream.[ch] to ui 2015-02-08 22:22:33 +00:00
Makefile.nmake Add '*.nativecodeanalysis.xml' to 'clean' targets 2015-01-02 01:45:16 +00:00
alert_box.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
alert_box.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
capture.c Clean up ftype-conversion and dfilter error message string handling. 2015-01-18 10:22:59 +00:00
capture.h Qt: Add a CaptureFile class. 2014-12-20 17:39:29 +00:00
capture_globals.h Move capture_session.h to capchild; what it declares is defined there. 2014-06-30 05:09:31 +00:00
capture_ui_utils.c isdigit -> g_ascii_isdigit to make the build work. 2014-10-17 08:52:10 +00:00
capture_ui_utils.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
console.c (Trivial) Fix printf-related 'Mismatch on sign' warnings 2015-02-09 18:57:14 +00:00
console.h Move the console log handling code to ui/console.[ch]. 2014-09-26 14:15:45 +00:00
decode_as_utils.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
decode_as_utils.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
doxygen.cfg.in Continue to remove $Id$ from top of file 2014-03-31 18:48:06 +00:00
export_object.c Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
export_object.h Adjust some whitespace to match editor modelines. 2014-10-06 03:42:51 +00:00
export_object_dicom.c Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
export_object_http.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
export_object_smb.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
export_object_tftp.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
file_dialog.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
filters.c Use g_ascii_isspace() instead of isascii() && isspace(). 2014-10-17 06:54:54 +00:00
filters.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
follow.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
follow.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
help_url.c Qt: Add the RTP Streams dialog. 2015-01-30 06:48:32 +00:00
help_url.h Qt: Add the RTP Streams dialog. 2015-01-30 06:48:32 +00:00
iface_lists.c Replace ep_address_to_str with address_to_str. 2015-01-06 07:38:18 +00:00
iface_lists.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
io_graph_item.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
io_graph_item.h Strip some trailing whitespace; Fix some indentation; Add editor-modelines as needed. 2014-07-11 03:20:54 +00:00
language.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
language.h Qt: Dynamic languages 2014-11-04 08:21:55 +00:00
last_open_dir.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
main_statusbar.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
mcast_stream.c Multicast Stream: Move mcast_stream.[ch] to ui 2015-02-08 22:22:33 +00:00
mcast_stream.h Multicast Stream: Move mcast_stream.[ch] to ui 2015-02-08 22:22:33 +00:00
packet_list_utils.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
packet_list_utils.h Fix warning when generate documentation (doxygen) 2014-04-14 20:20:38 +00:00
persfilepath_opt.c Don't use <ctype.h> macros, and eliminate an include of <ctype.h>. 2014-10-17 06:41:58 +00:00
persfilepath_opt.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
preference_utils.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
preference_utils.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
profile.c Remove some apparently-unnecessary includes of emem.h. 2015-01-18 19:47:20 +00:00
profile.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
progress_dlg.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
proto_hier_stats.c Qt: Add the Protocol Hierarchy statistics dialog. 2015-02-04 02:06:01 +00:00
proto_hier_stats.h Qt: Add the Protocol Hierarchy statistics dialog. 2015-02-04 02:06:01 +00:00
recent.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
recent.h Adjust some whitespace to match editor modelines. 2014-10-06 03:42:51 +00:00
recent_utils.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
rtp_analysis.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
rtp_stream.c Fix RTP crash on RTP analysis attempt 2015-02-07 02:16:06 +00:00
rtp_stream.h Fix RTP crash on RTP analysis attempt 2015-02-07 02:16:06 +00:00
simple_dialog.h Adjust some whitespace to match editor modelines. 2014-10-06 03:42:51 +00:00
software_update.c Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
software_update.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
ssl_key_export.c Consistently use the "g_string_free returns a C string pointer" idiom. 2015-01-13 23:14:13 +00:00
ssl_key_export.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
tap-megaco-common.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
tap-megaco-common.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
tap-rtp-common.c Fix some indent typo (after g2bf7878e) 2015-02-02 12:37:06 +00:00
tap-rtp-common.h Qt: Add the RTP Streams dialog. 2015-01-30 06:48:32 +00:00
tap-sctp-analysis.c Convert val_to_str -> val_to_str_wmem. 2015-02-04 06:58:49 +00:00
tap-sctp-analysis.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
tap-sequence-analysis.c Replace ep_display_to_address with wmem equivalent display_to_address. 2015-01-05 13:55:04 +00:00
tap-sequence-analysis.h Qt: Initial VoIP Calls dialog. 2014-12-09 21:25:33 +00:00
tap-tcp-stream.c Clean up ftype-conversion and dfilter error message string handling. 2015-01-18 10:22:59 +00:00
tap-tcp-stream.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
tap_export_pdu.c Consistently use the "g_string_free returns a C string pointer" idiom. 2015-01-13 23:14:13 +00:00
tap_export_pdu.h Cleanup the "export PDU" common code. 2014-07-15 20:15:59 +00:00
text_import.c Handle "I can't map this for that file format" better. 2014-12-18 00:03:26 +00:00
text_import.h Revert "Refactor Wiretap" 2014-05-09 05:21:01 +00:00
text_import_scanner.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
text_import_scanner.l Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
time_shift.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
time_shift.h Always put editor-modelines at the end of the file ... 2014-10-14 20:08:29 +00:00
traffic_table_ui.c Remove emem from GeoIP 2015-01-18 04:14:03 +00:00
traffic_table_ui.h Qt: Add the "Map" button to the Endpoints dialog. 2014-09-17 20:04:28 +00:00
ui_util.h Qt: Packet list column sorting. 2014-10-06 21:10:11 +00:00
utf8_entities.h Qt: Add the Protocol Hierarchy statistics dialog. 2015-02-04 02:06:01 +00:00
util.c Remove unneeded includes from ui folder 2015-01-01 23:11:10 +00:00
util.h Remove all $Id$ from top of file 2014-03-04 14:27:33 +00:00
voip_calls.c Convert val_to_str -> val_to_str_wmem. 2015-02-04 06:58:49 +00:00
voip_calls.h Consolidate RTP stream structs. 2014-12-20 16:49:05 +00:00