osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/epan/dissectors/asn1
History
Guy Harris 86af1d6707 e2ap: fix a compiler warning due to a strange maxofRICrequestID value. 
The minimum and maximum length arguments to
dissect_per_constrained_set_of() are currently both ints.

According to O-RAN.WG3.E2AP-v02.03, section 9.3.7 "Constant
definitions", maxofRICrequestID is 1024, not 2^32-1; however, we were
specifying it as 2^32-1 (4294967295).

2^32-1 won't fit into an int, and Apple clang version 14.0.0
(clang-1400.0.29.102) warns about that:

    ./asn1/e2ap/e2ap.cnf:647:54: error: implicit conversion from 'long' to 'int' changes value from 4294967295 to -1 [-Werror,-Wconstant-conversion]
                                                      1, maxofRICrequestID, FALSE);
                                                         ^~~~~~~~~~~~~~~~~
    ./asn1/e2ap/packet-e2ap-val.h:7:40: note: expanded from macro 'maxofRICrequestID'
    #define maxofRICrequestID              4294967295
                                           ^~~~~~~~~~

The handling of MIN and MAX should be done with separate "minimum is
MIN" and "maximum is MAX" flags, and we might want either to have
asn2wrs.py reject attempts to have constraints with integer minimum and
maximum values outside the range [-2^31, 2^31-1], make the types for
sizes unsigned, or allow 64-bit constraints (and still limit the
constraint values, so we don't have to dive down a bignum rathole).

But, for now, we just change maxofRICrequestID to match what the 2022-10
version of the spec, 2.03, appears to say.

(I can't find the 2.01 version online, so I don't know whether it was
1024 in 2.01, or if it was changed in 2.02 or 2.03.)
 		2022-10-27 23:57:51 -07:00
..
HI2Operations Lift restriction on upper case protocol display filter names 2021-11-02 08:35:24 +00:00
acp133
…
acse asn1: convert most dissectors to pinfo->pool 2021-07-26 15:30:11 +00:00
ain asn2wrs: Rename duplicated filter names 2020-12-15 10:54:58 +00:00
ansi_map tap: Adding flags for tap_packet 2022-06-10 05:46:15 +00:00
ansi_tcap ASN1: Convert I/O from GLib to stdio.h 2021-12-17 19:34:54 +00:00
atn-cm
…
atn-cpdlc
…
atn-ulcs ASN.1 PER + ATN-ULCS: Add checks for nulls in sequences. 2022-02-03 20:10:33 +00:00
c1222 Fix some spelling errors. 2021-11-18 04:43:51 +00:00
camel Camel: Dissect TimeAndTimezone 2022-10-21 14:05:03 +00:00
cbrs-oids
…
cdt asn1: convert most dissectors to pinfo->pool 2021-07-26 15:30:11 +00:00
charging_ase
…
cmip Fix duplicated filter names. 2020-12-15 14:43:43 +00:00
cmp Fix duplicated filter names. 2020-12-15 14:43:43 +00:00
cms CMS: get rid of globals 2022-01-07 03:17:07 +00:00
credssp Dissector names are not protocol names. 2022-09-10 22:37:11 -07:00
crmf
…
dap Fix duplicated filter names. 2020-12-15 14:43:43 +00:00
disp Fix duplicated filter names. 2020-12-15 14:43:43 +00:00
dop asn1: convert most dissectors to pinfo->pool 2021-07-26 15:30:11 +00:00
dsp
…
e1ap E1AP: upgrade dissector to v17.2.0 2022-09-26 15:33:55 +02:00
e2ap e2ap: fix a compiler warning due to a strange maxofRICrequestID value. 2022-10-27 23:57:51 -07:00
ess asn1: convert most dissectors to pinfo->pool 2021-07-26 15:30:11 +00:00
f1ap tap: Adding flags for tap_packet 2022-06-10 05:46:15 +00:00
ftam asn1: fix missing dissector generation 2022-03-29 12:05:27 +00:00
gdt GDT: add dissector for SCTP PPID 49 protocol 2022-02-07 20:20:43 +00:00
glow
…
goose BER: Add a function to add a BER encoded boilerplate. 2022-03-29 11:23:07 +00:00
gprscdr gprscdr: Update to 3GPP TS 32.298 V17.4.0 2022-10-06 16:00:22 +00:00
gsm_map tap: Adding flags for tap_packet 2022-06-10 05:46:15 +00:00
h225 Rename a bunch of things with "conversation". 2022-08-25 20:02:20 -07:00
h235
…
h245 ASN1: Convert I/O from GLib to stdio.h 2021-12-17 19:34:54 +00:00
h248 h248: Add missing dot in H.248 protocol name 2022-10-20 13:20:01 +00:00
h282 Fix duplicated filter names. 2020-12-16 15:13:31 +01:00
h283
…
h323 wmem: convert more asn1 dissectors to pinfo->pool 2021-08-19 15:07:44 +00:00
h450
…
h450-ros Cast away the return value of g_strlcpy() and g_strlcat(). 2021-04-30 03:19:19 -07:00
h460
…
h501 Fix duplicated filter names. 2020-12-16 15:13:31 +01:00
hnbap prefs: More port prefs to auto prefs with ranges 2022-08-06 18:51:07 -04:00
idmp IDMP: Initialize some variables. 2021-10-18 20:19:35 +00:00
ieee1609dot2 Replace g_snprintf() with snprintf() (dissectors) 2021-12-19 20:25:11 +00:00
ilp Fix duplicated filters 2020-12-17 17:31:26 +00:00
inap Fix duplicated filters 2020-12-17 17:31:26 +00:00
isdn-sup
…
its ITS: use custom value format for more ITS elements 2022-03-15 08:52:28 +00:00
kerberos Rename a bunch of things with "conversation". 2022-08-25 20:02:20 -07:00
lcsap prefs: More port prefs to auto prefs with ranges 2022-08-06 18:51:07 -04:00
ldap LDAP: Validate DNS name string encoding 2022-10-20 12:03:52 +00:00
lix2 Fix some file permissions 2021-12-08 20:33:29 +00:00
lnpdqp asn1: fix missing dissector generation 2022-03-29 12:05:27 +00:00
logotypecertextn
…
lpp LPP: upgrade dissector to v17.2.0 2022-10-04 14:59:37 +00:00
lppa LPPa: upgrade dissector to v16.1.0 2020-12-16 12:02:37 +01:00
lppe LPPe: upgrade dissector to OMA-TS-LPPe-V1_0-20200630-D 2021-08-20 18:19:23 +02:00
lte-rrc LTE RRC: upgrade dissector to v17.2.0 2022-10-04 17:34:17 +00:00
m2ap M2AP, M3AP: Use ECGI specific MCC/MNC fields 2021-05-15 05:57:37 +00:00
m3ap M2AP, M3AP: Use ECGI specific MCC/MNC fields 2021-05-15 05:57:37 +00:00
mms ASN1: Convert I/O from GLib to stdio.h 2021-12-17 19:34:54 +00:00
mpeg-audio
…
mpeg-pes MPEG PES: Update conformance file for unify PES header bit fields 2022-01-06 09:12:55 -05:00
mudurl
…
nbap Rename a bunch of things with "conversation". 2022-08-25 20:02:20 -07:00
ngap NGAP: upgrade dissector to v17.2.0 2022-09-26 14:16:27 +02:00
nist-csor
…
novell_pkis
…
nr-rrc NR RRC: upgrade dissector to v17.2.0 2022-10-05 08:50:43 +02:00
nrppa PER:Add function to add "PER encoded lable" to the tree. 2022-04-12 08:33:36 +02:00
ns_cert_exts
…
ocsp
…
p1 epan: Remove STR_ASCII and STR_UNICODE 2021-12-03 04:35:56 +00:00
p7 Fix duplicated filter names 2021-01-14 12:22:21 +00:00
p22 epan: Remove STR_ASCII and STR_UNICODE 2021-12-03 04:35:56 +00:00
p772
…
pcap prefs: More cleanup, auto prefs 2022-08-09 06:21:05 +00:00
pkcs1 asn1: fix missing dissector generation 2022-03-29 12:05:27 +00:00
pkcs10
…
pkcs12 wmem: convert more asn1 dissectors to pinfo->pool 2021-08-19 15:07:44 +00:00
pkinit
…
pkix1explicit epan: Remove STR_ASCII and STR_UNICODE 2021-12-03 04:35:56 +00:00
pkix1implicit
…
pkixac
…
pkixproxy
…
pkixqualified Add support for SRVName SAN extension for TLS certificates 2021-02-25 10:21:24 +01:00
pkixtsp pkixtsp: support opening standalone query/response files 2021-02-06 14:05:52 +00:00
pres asn1: convert most dissectors to pinfo->pool 2021-07-26 14:00:09 -04:00
q932 prefs: More cleanup, auto prefs 2022-08-09 06:21:05 +00:00
q932-ros Cast away the return value of g_strlcpy() and g_strlcat(). 2021-04-30 03:19:19 -07:00
qsig
…
ranap prefs: More cleanup, auto prefs 2022-08-09 06:21:05 +00:00
rnsap Prettify and standardize LAC, RAC, SAC, TAC in several ASN.1 dissectors 2021-03-30 21:48:00 -04:00
ros ldap, ros: restore a missing word in a comment 2022-01-04 07:13:45 +00:00
rrc Rename a bunch of things with "conversation". 2022-08-25 20:02:20 -07:00
rrlp
…
rtse epan: Remove STR_ASCII and STR_UNICODE 2021-12-03 04:35:56 +00:00
rua Prefs: Convert some SCTP port preferences to auto prefs 2022-08-06 00:17:14 -04:00
s1ap gtpv2: Update to 3GPP TS 29.274 V18.0.0 2022-10-06 21:19:49 +00:00
sabp SABP: Update ASN.1 template 2022-01-06 14:28:20 +00:00
sbc-ap epan: Remove STR_ASCII and STR_UNICODE 2021-12-03 04:35:56 +00:00
smrse
…
snmp Rename a bunch of things with "conversation". 2022-08-25 20:02:20 -07:00
spnego asn1: convert most dissectors to pinfo->pool 2021-07-26 14:00:09 -04:00
sv SV / IEC 61850: Accommodate Ethernet trailers 2021-09-15 14:27:29 -07:00
t38 Rename a bunch of things with "conversation". 2022-08-25 20:02:20 -07:00
t124 asn1: convert most dissectors to pinfo->pool 2021-07-26 14:00:09 -04:00
t125 rdp: many improvements and fixes 2021-06-15 08:42:47 +00:00
tcap Corrects repeated words throughout the code. 2021-12-22 11:01:11 +00:00
tcg-cp-oids
…
tetra
…
ulp ASN1: Convert I/O from GLib to stdio.h 2021-12-17 19:34:54 +00:00
wlancertextn
…
x2ap X2AP: Make it possible to dissct private IEs 2022-10-22 21:40:23 +02:00
x509af x509af: Call dissect_ber_bitstring() with hf_index 2022-02-03 11:18:16 +00:00
x509ce X509ce: Use FT_ABSOLUTE_TIME for baseUpdateTime, invalidityDate 2022-01-25 13:42:00 +00:00
x509if X509if: Increase MAX_RDN_STR_LEN to 128 2022-07-11 15:07:09 +00:00
x509sat Move wmem string utility functions to wsutil 2021-12-19 10:47:50 +00:00
x721
…
xnap XnAP: upgrade dissector to v17.2.0 2022-09-26 15:12:37 +02:00
z3950 asn1: fix missing dissector generation 2022-03-29 12:05:27 +00:00
.gitignore
…
CMakeLists.txt GDT: add dissector for SCTP PPID 49 protocol 2022-02-07 20:20:43 +00:00
CMakeListsCustom.example.txt
…